Re: [PATCH -next RFC] block: support to account io_ticks precisely

Re: [PATCH -next RFC] block: support to account io_ticks precisely

[kernel test robot]

Hi Yu,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20231205]

url:    https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/block-support-to-account-io_ticks-precisely/20231205-174024
base:   next-20231205
patch link:    https://lore.kernel.org/r/20231205093743.1823351-1-yukuai1%40huaweicloud.com
patch subject: [PATCH -next RFC] block: support to account io_ticks precisely
config: i386-buildonly-randconfig-002-20231206 (https://download.01.org/0day-ci/archive/20231206/202312062106.irqU9bgB-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312062106.irqU9bgB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312062106.irqU9bgB-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/blk-sysfs.c:489:11: warning: unused variable 'err' [-Wunused-variable]
           int ret, err;
                    ^
   1 warning generated.


vim +/err +489 block/blk-sysfs.c

   484	
   485	static ssize_t
   486	queue_iostats_store(struct request_queue *q, const char *page, size_t count)
   487	{
   488		unsigned long nr;
 > 489		int ret, err;
   490	
   491		ret = queue_var_store(&nr, page, count);
   492		if (ret < 0)
   493			return ret;
   494	
   495		if (nr > 2)
   496			return -EINVAL;
   497	
   498		if (nr == 0) {
   499			blk_queue_flag_clear(QUEUE_FLAG_IO_STAT, q);
   500			blk_queue_flag_clear(QUEUE_FLAG_PRECISE_IO_STAT, q);
   501		} else if (nr == 1) {
   502			blk_queue_flag_set(QUEUE_FLAG_IO_STAT, q);
   503			blk_queue_flag_clear(QUEUE_FLAG_PRECISE_IO_STAT, q);
   504		} else {
   505			blk_queue_flag_set(QUEUE_FLAG_IO_STAT, q);
   506			blk_queue_flag_set(QUEUE_FLAG_PRECISE_IO_STAT, q);
   507		}
   508	
   509		return count;
   510	}
   511	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki