drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: warning: variable 'loc' set but not used

kernel test robot
2024-01-06T15:56:19Z

Hi Ben,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 95c8a35f1c017327eab3b6a2ff5c04255737c856
commit: 4b569ded09fdadb0c14f797c8dae4e8bc4bbad9f drm/nouveau/acr/ga102: initial support
date: 1 year, 2 months ago
config: x86_64-buildonly-randconfig-002-20240105 (https://download.01.org/0day-ci/archive/20240106/202401062340.4wmRg7ye-lkp@intel.com/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240106/202401062340.4wmRg7ye-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401062340.4wmRg7ye-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: warning: variable 'loc' set but not used [-Wunused-but-set-variable]
221 | u32 loc, sig, cnt, *meta;
| ^
1 warning generated.

vim +/loc +221 drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c

179
180 int
181 nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,
182 struct nvkm_falcon *falcon,
183 enum nvkm_acr_lsf_id id,
184 const char *path, int ver,
185 const struct nvkm_acr_lsf_func *func)
186 {
187 const struct firmware *fw;
188 struct nvkm_acr_lsfw *lsfw;
189 const struct nvfw_ls_desc_v2 *desc;
190 int ret = 0;
191
192 lsfw = nvkm_acr_lsfw_load_sig_image_desc_(subdev, falcon, id, path, ver, func, &fw);
193 if (IS_ERR(lsfw))
194 return PTR_ERR(lsfw);
195
196 desc = nvfw_ls_desc_v2(subdev, fw->data);
197
198 lsfw->secure_bootloader = desc->secure_bootloader;
199 lsfw->bootloader_size = ALIGN(desc->bootloader_size, 256);
200 lsfw->bootloader_imem_offset = desc->bootloader_imem_offset;
201
202 lsfw->app_size = ALIGN(desc->app_size, 256);
203 lsfw->app_start_offset = desc->app_start_offset;
204 lsfw->app_imem_entry = desc->app_imem_entry;
205 lsfw->app_resident_code_offset = desc->app_resident_code_offset;
206 lsfw->app_resident_code_size = desc->app_resident_code_size;
207 lsfw->app_resident_data_offset = desc->app_resident_data_offset;
208 lsfw->app_resident_data_size = desc->app_resident_data_size;
209 lsfw->app_imem_offset = desc->app_imem_offset;
210 lsfw->app_dmem_offset = desc->app_dmem_offset;
211
212 lsfw->ucode_size = ALIGN(lsfw->app_resident_data_offset, 256) + lsfw->bootloader_size;
213 lsfw->data_size = lsfw->app_size + lsfw->bootloader_size - lsfw->ucode_size;
214
215 nvkm_firmware_put(fw);
216
217 if (lsfw->secure_bootloader) {
218 const struct firmware *hsbl;
219 const struct nvfw_ls_hsbl_bin_hdr *hdr;
220 const struct nvfw_ls_hsbl_hdr *hshdr;
> 221 u32 loc, sig, cnt, *meta;
222
223 ret = nvkm_firmware_load_name(subdev, path, "hs_bl_sig", ver, &hsbl);
224 if (ret)
225 return ret;
226
227 hdr = nvfw_ls_hsbl_bin_hdr(subdev, hsbl->data);
228 hshdr = nvfw_ls_hsbl_hdr(subdev, hsbl->data + hdr->header_offset);
229 meta = (u32 *)(hsbl->data + hshdr->meta_data_offset);
230 loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
231 sig = *(u32 *)(hsbl->data + hshdr->patch_sig);
232 cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
233
234 lsfw->fuse_ver = meta[0];
235 lsfw->engine_id = meta[1];
236 lsfw->ucode_id = meta[2];
237 lsfw->sig_size = hshdr->sig_prod_size / cnt;
238 lsfw->sig_nr = cnt;
239 lsfw->sigs = kmemdup(hsbl->data + hshdr->sig_prod_offset + sig,
240 lsfw->sig_nr * lsfw->sig_size, GFP_KERNEL);
241 nvkm_firmware_put(hsbl);
242 if (!lsfw->sigs)
243 ret = -ENOMEM;
244 }
245
246 return ret;
247 }
248

--
0-DAY CI Kernel Test Service