llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version
@ 2024-01-10  2:58 Sergey Senozhatsky
  2024-01-10  2:58 ` [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL Sergey Senozhatsky
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2024-01-10  2:58 UTC (permalink / raw)
  To: Miguel Ojeda, Kees Cook
  Cc: Gustavo A . R . Silva, Nathan Chancellor, Nick Desaulniers,
	Bill Wendling, Justin Stitt, linux-kernel, llvm,
	Sergey Senozhatsky

GCC is expected to implement this feature in version 15,
so bump the version.

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 include/linux/compiler_attributes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
index 28566624f008..215882a1341a 100644
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -95,7 +95,7 @@
 #endif
 
 /*
- * Optional: only supported since gcc >= 14
+ * Optional: only supported since gcc >= 15
  * Optional: only supported since clang >= 18
  *
  *   gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
-- 
2.43.0.472.g3155946c3a-goog


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL
  2024-01-10  2:58 [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Sergey Senozhatsky
@ 2024-01-10  2:58 ` Sergey Senozhatsky
  2024-01-10  3:02   ` Nathan Chancellor
  2024-01-11  0:46   ` Kees Cook
  2024-01-10  3:01 ` [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Nathan Chancellor
  2024-01-11  0:46 ` Kees Cook
  2 siblings, 2 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2024-01-10  2:58 UTC (permalink / raw)
  To: Miguel Ojeda, Kees Cook
  Cc: Gustavo A . R . Silva, Nathan Chancellor, Nick Desaulniers,
	Bill Wendling, Justin Stitt, linux-kernel, llvm,
	Sergey Senozhatsky

The URL in question 404 now, fix it up (and switch to github).

Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
 include/linux/compiler_attributes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
index 215882a1341a..289810685fc5 100644
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -99,7 +99,7 @@
  * Optional: only supported since clang >= 18
  *
  *   gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
- * clang: https://reviews.llvm.org/D148381
+ * clang: https://github.com/llvm/llvm-project/pull/76348
  */
 #if __has_attribute(__counted_by__)
 # define __counted_by(member)		__attribute__((__counted_by__(member)))
-- 
2.43.0.472.g3155946c3a-goog


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version
  2024-01-10  2:58 [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Sergey Senozhatsky
  2024-01-10  2:58 ` [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL Sergey Senozhatsky
@ 2024-01-10  3:01 ` Nathan Chancellor
  2024-01-11  0:46 ` Kees Cook
  2 siblings, 0 replies; 8+ messages in thread
From: Nathan Chancellor @ 2024-01-10  3:01 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Miguel Ojeda, Kees Cook, Gustavo A . R . Silva, Nick Desaulniers,
	Bill Wendling, Justin Stitt, linux-kernel, llvm

On Wed, Jan 10, 2024 at 11:58:17AM +0900, Sergey Senozhatsky wrote:
> GCC is expected to implement this feature in version 15,
> so bump the version.
> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  include/linux/compiler_attributes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index 28566624f008..215882a1341a 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -95,7 +95,7 @@
>  #endif
>  
>  /*
> - * Optional: only supported since gcc >= 14
> + * Optional: only supported since gcc >= 15
>   * Optional: only supported since clang >= 18
>   *
>   *   gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
> -- 
> 2.43.0.472.g3155946c3a-goog
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL
  2024-01-10  2:58 ` [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL Sergey Senozhatsky
@ 2024-01-10  3:02   ` Nathan Chancellor
  2024-01-10  3:08     ` Sergey Senozhatsky
  2024-01-11  0:46   ` Kees Cook
  1 sibling, 1 reply; 8+ messages in thread
From: Nathan Chancellor @ 2024-01-10  3:02 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Miguel Ojeda, Kees Cook, Gustavo A . R . Silva, Nick Desaulniers,
	Bill Wendling, Justin Stitt, linux-kernel, llvm

On Wed, Jan 10, 2024 at 11:58:18AM +0900, Sergey Senozhatsky wrote:
> The URL in question 404 now, fix it up (and switch to github).
> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

I sent a patch series today for the rest of the tree, which includes a
link to what happened here:

https://lore.kernel.org/20240109-update-llvm-links-v1-1-eb09b59db071@kernel.org/
https://lore.kernel.org/20240109-update-llvm-links-v1-2-eb09b59db071@kernel.org/

> ---
>  include/linux/compiler_attributes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index 215882a1341a..289810685fc5 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -99,7 +99,7 @@
>   * Optional: only supported since clang >= 18
>   *
>   *   gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896
> - * clang: https://reviews.llvm.org/D148381
> + * clang: https://github.com/llvm/llvm-project/pull/76348
>   */
>  #if __has_attribute(__counted_by__)
>  # define __counted_by(member)		__attribute__((__counted_by__(member)))
> -- 
> 2.43.0.472.g3155946c3a-goog
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL
  2024-01-10  3:02   ` Nathan Chancellor
@ 2024-01-10  3:08     ` Sergey Senozhatsky
  0 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2024-01-10  3:08 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Sergey Senozhatsky, Miguel Ojeda, Kees Cook,
	Gustavo A . R . Silva, Nick Desaulniers, Bill Wendling,
	Justin Stitt, linux-kernel, llvm

On (24/01/09 20:02), Nathan Chancellor wrote:
> On Wed, Jan 10, 2024 at 11:58:18AM +0900, Sergey Senozhatsky wrote:
> > The URL in question 404 now, fix it up (and switch to github).
> > 
> > Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> 
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> 
> I sent a patch series today for the rest of the tree, which includes a
> link to what happened here:

Thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version
  2024-01-10  2:58 [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Sergey Senozhatsky
  2024-01-10  2:58 ` [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL Sergey Senozhatsky
  2024-01-10  3:01 ` [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Nathan Chancellor
@ 2024-01-11  0:46 ` Kees Cook
  2024-01-23 19:58   ` Miguel Ojeda
  2 siblings, 1 reply; 8+ messages in thread
From: Kees Cook @ 2024-01-11  0:46 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Miguel Ojeda, Gustavo A . R . Silva, Nathan Chancellor,
	Nick Desaulniers, Bill Wendling, Justin Stitt, linux-kernel, llvm

On Wed, Jan 10, 2024 at 11:58:17AM +0900, Sergey Senozhatsky wrote:
> GCC is expected to implement this feature in version 15,
> so bump the version.
> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Yup, this is good. Miguel, I can take these patches if you want?

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL
  2024-01-10  2:58 ` [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL Sergey Senozhatsky
  2024-01-10  3:02   ` Nathan Chancellor
@ 2024-01-11  0:46   ` Kees Cook
  1 sibling, 0 replies; 8+ messages in thread
From: Kees Cook @ 2024-01-11  0:46 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: Miguel Ojeda, Gustavo A . R . Silva, Nathan Chancellor,
	Nick Desaulniers, Bill Wendling, Justin Stitt, linux-kernel, llvm

On Wed, Jan 10, 2024 at 11:58:18AM +0900, Sergey Senozhatsky wrote:
> The URL in question 404 now, fix it up (and switch to github).
> 
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>

Thanks!

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version
  2024-01-11  0:46 ` Kees Cook
@ 2024-01-23 19:58   ` Miguel Ojeda
  0 siblings, 0 replies; 8+ messages in thread
From: Miguel Ojeda @ 2024-01-23 19:58 UTC (permalink / raw)
  To: Kees Cook
  Cc: Sergey Senozhatsky, Miguel Ojeda, Gustavo A . R . Silva,
	Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
	linux-kernel, llvm

On Thu, Jan 11, 2024 at 1:46 AM Kees Cook <keescook@chromium.org> wrote:
>
> Yup, this is good. Miguel, I can take these patches if you want?
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Thanks Kees -- just applied them on top of v6.8-rc1 so they should be
in -next soon, but if you need to pick them up for another reason,
please go ahead.

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-01-23 19:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10  2:58 [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Sergey Senozhatsky
2024-01-10  2:58 ` [PATCHv2 2/2] Compiler Attributes: counted_by: fixup clang URL Sergey Senozhatsky
2024-01-10  3:02   ` Nathan Chancellor
2024-01-10  3:08     ` Sergey Senozhatsky
2024-01-11  0:46   ` Kees Cook
2024-01-10  3:01 ` [PATCHv2 1/2] Compiler Attributes: counted_by: bump min gcc version Nathan Chancellor
2024-01-11  0:46 ` Kees Cook
2024-01-23 19:58   ` Miguel Ojeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).