From: kernel test robot <lkp@intel.com>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [alobakin:pr/22 1/2] drivers/net/ethernet/intel/idpf/idpf_xsk.c:565:1: warning: unused label 'xsk_pool_if_up'
Date: Fri, 19 Jan 2024 19:25:36 +0800 [thread overview]
Message-ID: <202401191938.aPZsOozB-lkp@intel.com> (raw)
tree: https://github.com/alobakin/linux pr/22
head: 5b85f55897260cca2ecea3bb5f11555a5cc5f3ea
commit: c1d37109c5b20998384649a68f7e461fd59613d9 [1/2] Fix AF_XDP Tx & Rx for multi XSk instances
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20240119/202401191938.aPZsOozB-lkp@intel.com/config)
compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project d92ce344bf641e6bb025b41b3f1a77dd25e2b3e9)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240119/202401191938.aPZsOozB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401191938.aPZsOozB-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/idpf/idpf_xsk.c:565:1: warning: unused label 'xsk_pool_if_up' [-Wunused-label]
565 | xsk_pool_if_up:
| ^~~~~~~~~~~~~~~
1 warning generated.
vim +/xsk_pool_if_up +565 drivers/net/ethernet/intel/idpf/idpf_xsk.c
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 520
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 521 /**
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 522 * idpf_xsk_pool_setup - enable/disable a BUFF POOL region
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 523 * @vport: current vport of interest
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 524 * @pool: pointer to a requested BUFF POOL region
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 525 * @qid: queue id
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 526 *
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 527 * Returns 0 on success, negative on failure
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 528 */
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 529 int idpf_xsk_pool_setup(struct idpf_vport *vport, struct xsk_buff_pool *pool,
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 530 u32 qid)
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 531 {
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 532 bool if_running, pool_present = !!pool;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 533 int err = 0, pool_failure = 0, num_qs;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 534 struct idpf_q_vector *q_vector;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 535 struct idpf_queue *rxq, **qs;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 536
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 537 if_running = netif_running(vport->netdev) &&
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 538 idpf_xdp_is_prog_ena(vport);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 539
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 540 if (if_running) {
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 541 rxq = idpf_find_rxq(vport, qid);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 542 q_vector = rxq->q_vector;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 543
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 544 qs = idpf_create_queue_list(vport, qid, &num_qs);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 545 if (!qs) {
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 546 err = -ENOMEM;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 547 goto xsk_exit;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 548 }
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 549
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 550 err = idpf_qp_dis(vport, q_vector, qs, num_qs, qid);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 551 if (err) {
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 552 netdev_err(vport->netdev, "Cannot disable queues for XSK setup, error = %d\n",
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 553 err);
c1d37109c5b2099 Michal Kubiak 2024-01-10 554 //goto xsk_pool_if_up;
c1d37109c5b2099 Michal Kubiak 2024-01-10 555 //TODO: Fix FW!!!!
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 556 }
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 557 }
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 558
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 559 pool_failure = pool_present ? idpf_xsk_pool_enable(vport, qid) :
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 560 idpf_xsk_pool_disable(vport, qid);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 561
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 562 if (!idpf_xdp_is_prog_ena(vport))
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 563 netdev_warn(vport->netdev, "RSS may schedule pkts to q occupied by AF XDP\n");
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 564
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 @565 xsk_pool_if_up:
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 566 if (if_running) {
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 567 err = idpf_qp_ena(vport, q_vector, qs, num_qs, qid);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 568 if (!err && pool_present)
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 569 napi_schedule(&rxq->q_vector->napi);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 570 else if (err)
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 571 netdev_err(vport->netdev,
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 572 "Could not enable queues after XSK setup, error = %d\n",
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 573 err);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 574 kfree(qs);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 575 }
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 576
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 577 if (pool_failure) {
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 578 netdev_err(vport->netdev, "Could not %sable BUFF POOL, error = %d\n",
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 579 pool_present ? "en" : "dis", pool_failure);
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 580 err = pool_failure;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 581 }
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 582
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 583 xsk_exit:
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 584 return err;
4550e7f47e2e0f3 Michal Kubiak 2023-11-27 585 }
cf0706903cff863 Michal Kubiak 2023-12-07 586
:::::: The code at line 565 was first introduced by commit
:::::: 4550e7f47e2e0f3e1beff777eec679467092567d idpf: add XSk pool initialization
:::::: TO: Michal Kubiak <michal.kubiak@intel.com>
:::::: CC: Alexander Lobakin <aleksander.lobakin@intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-01-19 11:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401191938.aPZsOozB-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=michal.kubiak@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox