* [PATCH] mfd: rave-sp: Avoid unnecessary use of comma operator
@ 2024-01-23 9:59 Simon Horman
2024-01-25 13:38 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2024-01-23 9:59 UTC (permalink / raw)
To: Lee Jones
Cc: Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
linux-kernel, llvm, Simon Horman
Although it does not seem to have any untoward side-effects,
the use of ';' to separate to assignments seems more appropriate than ','.
Flagged by clang-17 -Wcomma
No functional change intended.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/mfd/rave-sp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
index da50eba10014..aca552890553 100644
--- a/drivers/mfd/rave-sp.c
+++ b/drivers/mfd/rave-sp.c
@@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
ackid = atomic_inc_return(&sp->ackid);
reply.ackid = ackid;
- reply.code = rave_sp_reply_code((u8)command),
+ reply.code = rave_sp_reply_code((u8)command);
mutex_lock(&sp->bus_lock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] mfd: rave-sp: Avoid unnecessary use of comma operator
2024-01-23 9:59 [PATCH] mfd: rave-sp: Avoid unnecessary use of comma operator Simon Horman
@ 2024-01-25 13:38 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2024-01-25 13:38 UTC (permalink / raw)
To: Lee Jones, Simon Horman
Cc: Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
linux-kernel, llvm
On Tue, 23 Jan 2024 09:59:48 +0000, Simon Horman wrote:
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>
> Flagged by clang-17 -Wcomma
>
> No functional change intended.
> Compile tested only.
>
> [...]
Applied, thanks!
[1/1] mfd: rave-sp: Avoid unnecessary use of comma operator
commit: 67421634ade0979dafd3e3f21c9b63bc93ef4760
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-25 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-23 9:59 [PATCH] mfd: rave-sp: Avoid unnecessary use of comma operator Simon Horman
2024-01-25 13:38 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).