From: kernel test robot <lkp@intel.com>
To: Janne Grunau <j@jannau.net>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Hector Martin <marcan@marcan.st>
Subject: [asahilinux:bits/090-spi-hid 9/21] drivers/hid/spi-hid/spi-hid-apple-core.c:151: warning: Function parameter or struct member 'id' not described in 'spihid_msg_hdr'
Date: Fri, 26 Jan 2024 04:45:35 +0800 [thread overview]
Message-ID: <202401260412.qXoWWG7Z-lkp@intel.com> (raw)
tree: https://github.com/AsahiLinux/linux bits/090-spi-hid
head: 253645613d55bc9e62bb0b1811d009cd987f301f
commit: 372d4679f7251105cfe589c326eb5ee9b3d4f8a1 [9/21] WIP: HID: transport: spi: add Apple SPI transport
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240126/202401260412.qXoWWG7Z-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401260412.qXoWWG7Z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401260412.qXoWWG7Z-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/hid/spi-hid/spi-hid-apple-core.c:151: warning: Function parameter or struct member 'id' not described in 'spihid_msg_hdr'
>> drivers/hid/spi-hid/spi-hid-apple-core.c:151: warning: Excess struct member 'msgid' description in 'spihid_msg_hdr'
vim +151 drivers/hid/spi-hid/spi-hid-apple-core.c
119
120 /**
121 * struct spihid_msg_hdr - common header of protocol messages.
122 *
123 * Each message begins with fixed header, followed by a message-type specific
124 * payload, and ends with a 16-bit crc. Because of the varying lengths of the
125 * payload, the crc is defined at the end of each payload struct, rather than
126 * in this struct.
127 *
128 * @unknown0: request type? output, input (0x10), feature, protocol
129 * @unknown1: maybe report id?
130 * @unknown2: mostly zero, in info request maybe device num
131 * @msgid: incremented on each message, rolls over after 255; there is a
132 * separate counter for each message type.
133 * @rsplen: response length (the exact nature of this field is quite
134 * speculative). On a request/write this is often the same as
135 * @length, though in some cases it has been seen to be much larger
136 * (e.g. 0x400); on a response/read this the same as on the
137 * request; for reads that are not responses it is 0.
138 * @length: length of the remainder of the data in the whole message
139 * structure (after re-assembly in case of being split over
140 * multiple spi-packets), minus the trailing crc. The total size
141 * of a message is therefore @length + 10.
142 */
143
144 struct spihid_msg_hdr {
145 u8 unknown0;
146 u8 unknown1;
147 u8 unknown2;
148 u8 id;
149 __le16 rsplen;
150 __le16 length;
> 151 };
152
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-01-25 20:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401260412.qXoWWG7Z-lkp@intel.com \
--to=lkp@intel.com \
--cc=j@jannau.net \
--cc=llvm@lists.linux.dev \
--cc=marcan@marcan.st \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).