* Re: [PATCH 3/3] watchdog/softlockup: add parameter to control the reporting of time-consuming hardirq
[not found] <20240123121223.22318-4-yaoma@linux.alibaba.com>
@ 2024-01-26 5:25 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-01-26 5:25 UTC (permalink / raw)
To: Bitao Hu, dianders, akpm, pmladek, tglx, maz, liusong
Cc: llvm, oe-kbuild-all, linux-kernel, Bitao Hu
Hi Bitao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/irq/core]
[also build test WARNING on akpm-mm/mm-everything linus/master v6.8-rc1 next-20240125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bitao-Hu/watchdog-softlockup-low-overhead-detection-of-interrupt-storm/20240123-201509
base: tip/irq/core
patch link: https://lore.kernel.org/r/20240123121223.22318-4-yaoma%40linux.alibaba.com
patch subject: [PATCH 3/3] watchdog/softlockup: add parameter to control the reporting of time-consuming hardirq
config: i386-buildonly-randconfig-003-20240126 (https://download.01.org/0day-ci/archive/20240126/202401261359.eaU4UnjQ-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261359.eaU4UnjQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401261359.eaU4UnjQ-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/watchdog.c:1088:5: warning: no previous prototype for function 'proc_softlockup_irqtrace' [-Wmissing-prototypes]
1088 | int proc_softlockup_irqtrace(struct ctl_table *table, int write,
| ^
kernel/watchdog.c:1088:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1088 | int proc_softlockup_irqtrace(struct ctl_table *table, int write,
| ^
| static
1 warning generated.
vim +/proc_softlockup_irqtrace +1088 kernel/watchdog.c
1084
1085 /*
1086 * /proc/sys/kernel/softlockup_irqtrace
1087 */
> 1088 int proc_softlockup_irqtrace(struct ctl_table *table, int write,
1089 void *buffer, size_t *lenp, loff_t *ppos)
1090 {
1091 int err, old;
1092
1093 mutex_lock(&watchdog_mutex);
1094
1095 old = READ_ONCE(softlockup_irqtrace);
1096 err = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
1097
1098 if (!err && write && old != READ_ONCE(softlockup_irqtrace))
1099 proc_watchdog_update();
1100
1101 mutex_unlock(&watchdog_mutex);
1102 return err;
1103 }
1104
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread