llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [sailus-media-tree:master 18/18] drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode'
@ 2024-01-26  8:47 kernel test robot
  2024-01-26 15:47 ` Sergey Senozhatsky
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-01-26  8:47 UTC (permalink / raw)
  To: Jason Chen
  Cc: llvm, oe-kbuild-all, linux-media, Sakari Ailus,
	Sergey Senozhatsky

tree:   git://linuxtv.org/sailus/media_tree.git master
head:   f76be7216c3df5f563353bd7a6aaf5076b118943
commit: f76be7216c3df5f563353bd7a6aaf5076b118943 [18/18] media: ov08x40: Reduce start streaming time
config: i386-randconfig-003-20240126 (https://download.01.org/0day-ci/archive/20240126/202401261628.dWEtdXLE-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261628.dWEtdXLE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401261628.dWEtdXLE-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode'
    1783 |         if (ov08x->cur_mode->exposure_shift == 1) {
         |             ~~~~~~~~~~~~~~~  ^
   1 error generated.


vim +1783 drivers/media/i2c/ov08x40.c

  1749	
  1750	static int ov08x40_start_streaming(struct ov08x40 *ov08x)
  1751	{
  1752		struct i2c_client *client = v4l2_get_subdevdata(&ov08x->sd);
  1753		const struct ov08x40_reg_list *reg_list;
  1754		int ret, link_freq_index;
  1755	
  1756		/* Get out of from software reset */
  1757		ret = ov08x40_write_reg(ov08x, OV08X40_REG_SOFTWARE_RST,
  1758					OV08X40_REG_VALUE_08BIT, OV08X40_SOFTWARE_RST);
  1759		if (ret) {
  1760			dev_err(&client->dev, "%s failed to set powerup registers\n",
  1761				__func__);
  1762			return ret;
  1763		}
  1764	
  1765		link_freq_index = ov08x->cur_mode->link_freq_index;
  1766		reg_list = &link_freq_configs[link_freq_index].reg_list;
  1767	
  1768		ret = ov08x40_write_reg_list(ov08x, reg_list);
  1769		if (ret) {
  1770			dev_err(&client->dev, "%s failed to set plls\n", __func__);
  1771			return ret;
  1772		}
  1773	
  1774		/* Apply default values of current mode */
  1775		reg_list = &ov08x->cur_mode->reg_list;
  1776		ret = ov08x40_write_reg_list(ov08x, reg_list);
  1777		if (ret) {
  1778			dev_err(&client->dev, "%s failed to set mode\n", __func__);
  1779			return ret;
  1780		}
  1781	
  1782		/* Use i2c burst to write register on full size registers */
> 1783		if (ov08x->cur_mode->exposure_shift == 1) {
  1784			ret = ov08x40_burst_fill_regs(ov08x, OV08X40_REG_XTALK_FIRST_A,
  1785						      OV08X40_REG_XTALK_LAST_A, 0x75);
  1786			if (ret == 0)
  1787				ret = ov08x40_burst_fill_regs(ov08x,
  1788							      OV08X40_REG_XTALK_FIRST_B,
  1789							      OV08X40_REG_XTALK_LAST_B,
  1790							      0x75);
  1791		}
  1792	
  1793		if (ret) {
  1794			dev_err(&client->dev, "%s failed to set regs\n", __func__);
  1795			return ret;
  1796		}
  1797	
  1798		/* Apply customized values from user */
  1799		ret =  __v4l2_ctrl_handler_setup(ov08x->sd.ctrl_handler);
  1800		if (ret)
  1801			return ret;
  1802	
  1803		return ov08x40_write_reg(ov08x, OV08X40_REG_MODE_SELECT,
  1804					 OV08X40_REG_VALUE_08BIT,
  1805					 OV08X40_MODE_STREAMING);
  1806	}
  1807	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [sailus-media-tree:master 18/18] drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode'
  2024-01-26  8:47 [sailus-media-tree:master 18/18] drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode' kernel test robot
@ 2024-01-26 15:47 ` Sergey Senozhatsky
  2024-01-29 11:12   ` Sakari Ailus
  0 siblings, 1 reply; 3+ messages in thread
From: Sergey Senozhatsky @ 2024-01-26 15:47 UTC (permalink / raw)
  To: kernel test robot
  Cc: Jason Chen, llvm, oe-kbuild-all, linux-media, Sakari Ailus,
	Sergey Senozhatsky

On (24/01/26 16:47), kernel test robot wrote:
> tree:   git://linuxtv.org/sailus/media_tree.git master
> head:   f76be7216c3df5f563353bd7a6aaf5076b118943
> commit: f76be7216c3df5f563353bd7a6aaf5076b118943 [18/18] media: ov08x40: Reduce start streaming time
> config: i386-randconfig-003-20240126 (https://download.01.org/0day-ci/archive/20240126/202401261628.dWEtdXLE-lkp@intel.com/config)
> compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261628.dWEtdXLE-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401261628.dWEtdXLE-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode'
>     1783 |         if (ov08x->cur_mode->exposure_shift == 1) {
>          |             ~~~~~~~~~~~~~~~  ^
>    1 error generated.

This CL depends on https://patchwork.kernel.org/patch/13426393

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [sailus-media-tree:master 18/18] drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode'
  2024-01-26 15:47 ` Sergey Senozhatsky
@ 2024-01-29 11:12   ` Sakari Ailus
  0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2024-01-29 11:12 UTC (permalink / raw)
  To: Sergey Senozhatsky
  Cc: kernel test robot, Jason Chen, llvm, oe-kbuild-all, linux-media

On Sat, Jan 27, 2024 at 12:47:14AM +0900, Sergey Senozhatsky wrote:
> On (24/01/26 16:47), kernel test robot wrote:
> > tree:   git://linuxtv.org/sailus/media_tree.git master
> > head:   f76be7216c3df5f563353bd7a6aaf5076b118943
> > commit: f76be7216c3df5f563353bd7a6aaf5076b118943 [18/18] media: ov08x40: Reduce start streaming time
> > config: i386-randconfig-003-20240126 (https://download.01.org/0day-ci/archive/20240126/202401261628.dWEtdXLE-lkp@intel.com/config)
> > compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261628.dWEtdXLE-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202401261628.dWEtdXLE-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode'
> >     1783 |         if (ov08x->cur_mode->exposure_shift == 1) {
> >          |             ~~~~~~~~~~~~~~~  ^
> >    1 error generated.
> 
> This CL depends on https://patchwork.kernel.org/patch/13426393

Thanks, Sergey, I've taken it in my tree now.

-- 
Sakari Ailus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-29 11:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-26  8:47 [sailus-media-tree:master 18/18] drivers/media/i2c/ov08x40.c:1783:23: error: no member named 'exposure_shift' in 'struct ov08x40_mode' kernel test robot
2024-01-26 15:47 ` Sergey Senozhatsky
2024-01-29 11:12   ` Sakari Ailus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).