From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Mike Isely <isely@pobox.com>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 1/3] media: pci: sta2x11: Fix Wcast-function-type-strict warnings
Date: Sun, 28 Jan 2024 02:12:20 +0000 [thread overview]
Message-ID: <20240128-fix-clang-warnings-v1-1-1d946013a421@chromium.org> (raw)
In-Reply-To: <20240128-fix-clang-warnings-v1-0-1d946013a421@chromium.org>
Building with LLVM=1 throws the following warning:
drivers/media/pci/sta2x11/sta2x11_vip.c:1057:6: warning: cast from 'irqreturn_t (*)(int, struct sta2x11_vip *)' (aka 'enum irqreturn (*)(int, struct sta2x11_vip *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void *)') converts to incompatible function type [-Wcast-function-type-strict]
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/pci/sta2x11/sta2x11_vip.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pci/sta2x11/sta2x11_vip.c b/drivers/media/pci/sta2x11/sta2x11_vip.c
index e4cf9d63e926..0a3827575753 100644
--- a/drivers/media/pci/sta2x11/sta2x11_vip.c
+++ b/drivers/media/pci/sta2x11/sta2x11_vip.c
@@ -757,7 +757,7 @@ static const struct video_device video_dev_template = {
/**
* vip_irq - interrupt routine
* @irq: Number of interrupt ( not used, correct number is assumed )
- * @vip: local data structure containing all information
+ * @data: local data structure containing all information
*
* check for both frame interrupts set ( top and bottom ).
* check FIFO overflow, but limit number of log messages after open.
@@ -767,9 +767,10 @@ static const struct video_device video_dev_template = {
*
* IRQ_HANDLED, interrupt done.
*/
-static irqreturn_t vip_irq(int irq, struct sta2x11_vip *vip)
+static irqreturn_t vip_irq(int irq, void *data)
{
unsigned int status;
+ struct sta2x11_vip *vip = data;
status = reg_read(vip, DVP_ITS);
--
2.43.0.429.g432eaa2c6b-goog
next prev parent reply other threads:[~2024-01-28 2:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 2:12 [PATCH 0/3] media: Fix warnings building with LLVM=1 Ricardo Ribalda
2024-01-28 2:12 ` Ricardo Ribalda [this message]
2024-02-01 22:08 ` [PATCH 1/3] media: pci: sta2x11: Fix Wcast-function-type-strict warnings Nathan Chancellor
2024-01-28 2:12 ` [PATCH 2/3] media: usb: pvrusb2: " Ricardo Ribalda
2024-02-01 22:09 ` Nathan Chancellor
2024-01-28 2:12 ` [PATCH 3/3] media: mediatek: vcodedc: " Ricardo Ribalda
2024-02-01 22:16 ` Nathan Chancellor
2024-02-01 22:25 ` Sami Tolvanen
2024-02-02 12:58 ` AngeloGioacchino Del Regno
2024-02-02 20:15 ` Nícolas F. R. A. Prado
2024-02-04 20:55 ` Nathan Chancellor
2024-02-05 14:53 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240128-fix-clang-warnings-v1-1-1d946013a421@chromium.org \
--to=ribalda@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=isely@pobox.com \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).