* [jlayton:flsplit2 11/42] fs/fuse/file.c:2512:7: error: no member named 'fl_pid' in 'struct file_lock'; did you mean 'fl_end'?
@ 2024-01-28 12:48 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-01-28 12:48 UTC (permalink / raw)
To: Jeff Layton; +Cc: llvm, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git flsplit2
head: 43c094289e51b0d2e1b3a8b7a6cda14ddcaec4ba
commit: 48df0dcdbded452c1d8cc84652f8705a574bb1fc [11/42] filelock: split common fields into struct file_lock_core
config: x86_64-rhel-8.3-bpf (https://download.01.org/0day-ci/archive/20240128/202401282011.odbgKcIu-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240128/202401282011.odbgKcIu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401282011.odbgKcIu-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/fuse/file.c:2512:7: error: no member named 'fl_pid' in 'struct file_lock'; did you mean 'fl_end'?
2512 | fl->fl_pid = pid_nr_ns(find_pid_ns(ffl->pid, fc->pid_ns), &init_pid_ns);
| ^~~~~~
| fl_end
include/linux/filelock.h:127:9: note: 'fl_end' declared here
127 | loff_t fl_end;
| ^
>> fs/fuse/file.c:2519:6: error: no member named 'fl_type' in 'struct file_lock'
2519 | fl->fl_type = ffl->type;
| ~~ ^
>> fs/fuse/file.c:2533:44: error: no member named 'fl_owner' in 'struct file_lock'
2533 | inarg->owner = fuse_lock_owner_id(fc, fl->fl_owner);
| ~~ ^
fs/fuse/file.c:2536:23: error: no member named 'fl_type' in 'struct file_lock'
2536 | inarg->lk.type = fl->fl_type;
| ~~ ^
fs/fuse/file.c:2573:20: error: no member named 'fl_flags' in 'struct file_lock'
2573 | int opcode = (fl->fl_flags & FL_SLEEP) ? FUSE_SETLKW : FUSE_SETLK;
| ~~ ^
fs/fuse/file.c:2574:24: error: no member named 'fl_type' in 'struct file_lock'
2574 | struct pid *pid = fl->fl_type != F_UNLCK ? task_tgid(current) : NULL;
| ~~ ^
fs/fuse/file.c:2584:11: error: no member named 'fl_flags' in 'struct file_lock'
2584 | if ((fl->fl_flags & FL_CLOSE_POSIX) == FL_CLOSE_POSIX)
| ~~ ^
7 errors generated.
vim +2512 fs/fuse/file.c
55752a3aba1387 Miklos Szeredi 2019-01-24 2489
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2490 static int convert_fuse_file_lock(struct fuse_conn *fc,
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2491 const struct fuse_file_lock *ffl,
7142125937e148 Miklos Szeredi 2006-06-25 2492 struct file_lock *fl)
7142125937e148 Miklos Szeredi 2006-06-25 2493 {
7142125937e148 Miklos Szeredi 2006-06-25 2494 switch (ffl->type) {
7142125937e148 Miklos Szeredi 2006-06-25 2495 case F_UNLCK:
7142125937e148 Miklos Szeredi 2006-06-25 2496 break;
7142125937e148 Miklos Szeredi 2006-06-25 2497
7142125937e148 Miklos Szeredi 2006-06-25 2498 case F_RDLCK:
7142125937e148 Miklos Szeredi 2006-06-25 2499 case F_WRLCK:
7142125937e148 Miklos Szeredi 2006-06-25 2500 if (ffl->start > OFFSET_MAX || ffl->end > OFFSET_MAX ||
7142125937e148 Miklos Szeredi 2006-06-25 2501 ffl->end < ffl->start)
7142125937e148 Miklos Szeredi 2006-06-25 2502 return -EIO;
7142125937e148 Miklos Szeredi 2006-06-25 2503
7142125937e148 Miklos Szeredi 2006-06-25 2504 fl->fl_start = ffl->start;
7142125937e148 Miklos Szeredi 2006-06-25 2505 fl->fl_end = ffl->end;
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2506
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2507 /*
9d5b86ac13c573 Benjamin Coddington 2017-07-16 2508 * Convert pid into init's pid namespace. The locks API will
9d5b86ac13c573 Benjamin Coddington 2017-07-16 2509 * translate it into the caller's pid namespace.
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2510 */
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2511 rcu_read_lock();
9d5b86ac13c573 Benjamin Coddington 2017-07-16 @2512 fl->fl_pid = pid_nr_ns(find_pid_ns(ffl->pid, fc->pid_ns), &init_pid_ns);
0b6e9ea041e6c9 Seth Forshee 2014-07-02 2513 rcu_read_unlock();
7142125937e148 Miklos Szeredi 2006-06-25 2514 break;
7142125937e148 Miklos Szeredi 2006-06-25 2515
7142125937e148 Miklos Szeredi 2006-06-25 2516 default:
7142125937e148 Miklos Szeredi 2006-06-25 2517 return -EIO;
7142125937e148 Miklos Szeredi 2006-06-25 2518 }
7142125937e148 Miklos Szeredi 2006-06-25 @2519 fl->fl_type = ffl->type;
7142125937e148 Miklos Szeredi 2006-06-25 2520 return 0;
7142125937e148 Miklos Szeredi 2006-06-25 2521 }
7142125937e148 Miklos Szeredi 2006-06-25 2522
7078187a795f86 Miklos Szeredi 2014-12-12 2523 static void fuse_lk_fill(struct fuse_args *args, struct file *file,
a9ff4f87056cd3 Miklos Szeredi 2007-10-18 2524 const struct file_lock *fl, int opcode, pid_t pid,
7078187a795f86 Miklos Szeredi 2014-12-12 2525 int flock, struct fuse_lk_in *inarg)
7142125937e148 Miklos Szeredi 2006-06-25 2526 {
6131ffaa1f0914 Al Viro 2013-02-27 2527 struct inode *inode = file_inode(file);
9c8ef5614da226 Miklos Szeredi 2006-06-25 2528 struct fuse_conn *fc = get_fuse_conn(inode);
7142125937e148 Miklos Szeredi 2006-06-25 2529 struct fuse_file *ff = file->private_data;
7078187a795f86 Miklos Szeredi 2014-12-12 2530
7078187a795f86 Miklos Szeredi 2014-12-12 2531 memset(inarg, 0, sizeof(*inarg));
7078187a795f86 Miklos Szeredi 2014-12-12 2532 inarg->fh = ff->fh;
7078187a795f86 Miklos Szeredi 2014-12-12 @2533 inarg->owner = fuse_lock_owner_id(fc, fl->fl_owner);
7078187a795f86 Miklos Szeredi 2014-12-12 2534 inarg->lk.start = fl->fl_start;
7078187a795f86 Miklos Szeredi 2014-12-12 2535 inarg->lk.end = fl->fl_end;
7078187a795f86 Miklos Szeredi 2014-12-12 2536 inarg->lk.type = fl->fl_type;
7078187a795f86 Miklos Szeredi 2014-12-12 2537 inarg->lk.pid = pid;
a9ff4f87056cd3 Miklos Szeredi 2007-10-18 2538 if (flock)
7078187a795f86 Miklos Szeredi 2014-12-12 2539 inarg->lk_flags |= FUSE_LK_FLOCK;
d5b4854357f478 Miklos Szeredi 2019-09-10 2540 args->opcode = opcode;
d5b4854357f478 Miklos Szeredi 2019-09-10 2541 args->nodeid = get_node_id(inode);
d5b4854357f478 Miklos Szeredi 2019-09-10 2542 args->in_numargs = 1;
d5b4854357f478 Miklos Szeredi 2019-09-10 2543 args->in_args[0].size = sizeof(*inarg);
d5b4854357f478 Miklos Szeredi 2019-09-10 2544 args->in_args[0].value = inarg;
7142125937e148 Miklos Szeredi 2006-06-25 2545 }
7142125937e148 Miklos Szeredi 2006-06-25 2546
:::::: The code at line 2512 was first introduced by commit
:::::: 9d5b86ac13c573795525ecac6ed2db39ab23e2a8 fs/locks: Remove fl_nspid and use fs-specific l_pid for remote locks
:::::: TO: Benjamin Coddington <bcodding@redhat.com>
:::::: CC: Jeff Layton <jlayton@redhat.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-28 12:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-28 12:48 [jlayton:flsplit2 11/42] fs/fuse/file.c:2512:7: error: no member named 'fl_pid' in 'struct file_lock'; did you mean 'fl_end'? kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).