[brauner-vfs:b4/vfs-bdev-file-bd_inode 35/37] fs/jbd2/journal.c:1649: warning: Function parameter or struct member 'bdev_file' not described in 'jbd2_journal_init_dev'

kernel test robot
2024-01-29T18:38:10Z

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git b4/vfs-bdev-file-bd_inode
head: 92279a7f8c418cb71e6fb335e4af2c7565944a11
commit: d8db7fccf2cac31fb2021ddc1dc989d2c878099d [35/37] fs & block: remove bdev->bd_inode
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240130/202401300233.HpFwSXl6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240130/202401300233.HpFwSXl6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401300233.HpFwSXl6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/jbd2/journal.c:1649: warning: Function parameter or struct member 'bdev_file' not described in 'jbd2_journal_init_dev'
fs/jbd2/journal.c:1649: warning: Excess function parameter 'bdev' description in 'jbd2_journal_init_dev'

vim +1649 fs/jbd2/journal.c

470decc613ab20 Dave Kleikamp 2006-10-11 1622
f7f4bccb729844 Mingming Cao 2006-10-11 1623 /* jbd2_journal_init_dev and jbd2_journal_init_inode:
470decc613ab20 Dave Kleikamp 2006-10-11 1624 *
470decc613ab20 Dave Kleikamp 2006-10-11 1625 * Create a journal structure assigned some fixed set of disk blocks to
470decc613ab20 Dave Kleikamp 2006-10-11 1626 * the journal. We don't actually touch those disk blocks yet, but we
470decc613ab20 Dave Kleikamp 2006-10-11 1627 * need to set up all of the mapping information to tell the journaling
470decc613ab20 Dave Kleikamp 2006-10-11 1628 * system where the journal blocks are.
470decc613ab20 Dave Kleikamp 2006-10-11 1629 *
470decc613ab20 Dave Kleikamp 2006-10-11 1630 */
470decc613ab20 Dave Kleikamp 2006-10-11 1631
470decc613ab20 Dave Kleikamp 2006-10-11 1632 /**
5648ba5b2dc0d0 Randy Dunlap 2008-04-17 1633 * journal_t * jbd2_journal_init_dev() - creates and initialises a journal structure
470decc613ab20 Dave Kleikamp 2006-10-11 1634 * @bdev: Block device on which to create the journal
470decc613ab20 Dave Kleikamp 2006-10-11 1635 * @fs_dev: Device which hold journalled filesystem for this journal.
470decc613ab20 Dave Kleikamp 2006-10-11 1636 * @start: Block nr Start of journal.
470decc613ab20 Dave Kleikamp 2006-10-11 1637 * @len: Length of the journal in blocks.
470decc613ab20 Dave Kleikamp 2006-10-11 1638 * @blocksize: blocksize of journalling device
5648ba5b2dc0d0 Randy Dunlap 2008-04-17 1639 *
5648ba5b2dc0d0 Randy Dunlap 2008-04-17 1640 * Returns: a newly created journal_t *
470decc613ab20 Dave Kleikamp 2006-10-11 1641 *
f7f4bccb729844 Mingming Cao 2006-10-11 1642 * jbd2_journal_init_dev creates a journal which maps a fixed contiguous
470decc613ab20 Dave Kleikamp 2006-10-11 1643 * range of blocks on an arbitrary block device.
470decc613ab20 Dave Kleikamp 2006-10-11 1644 *
470decc613ab20 Dave Kleikamp 2006-10-11 1645 */
d8db7fccf2cac3 Christian Brauner 2024-01-28 1646 journal_t *jbd2_journal_init_dev(struct file *bdev_file,
d8db7fccf2cac3 Christian Brauner 2024-01-28 1647 struct file *fs_dev,
18eba7aae080d4 Mingming Cao 2006-10-11 1648 unsigned long long start, int len, int blocksize)
470decc613ab20 Dave Kleikamp 2006-10-11 @1649 {
f0c9fd5458bacf Geliang Tang 2016-09-15 1650 journal_t *journal;
470decc613ab20 Dave Kleikamp 2006-10-11 1651
d8db7fccf2cac3 Christian Brauner 2024-01-28 1652 journal = journal_init_common(bdev_file, fs_dev, start, len, blocksize);
8e6cf5fbb7b47d Zhang Yi 2023-08-11 1653 if (IS_ERR(journal))
8e6cf5fbb7b47d Zhang Yi 2023-08-11 1654 return ERR_CAST(journal);
470decc613ab20 Dave Kleikamp 2006-10-11 1655
900d156bac2bc4 Christoph Hellwig 2022-07-13 1656 snprintf(journal->j_devname, sizeof(journal->j_devname),
900d156bac2bc4 Christoph Hellwig 2022-07-13 1657 "%pg", journal->j_dev);
81ae394bdc473c Rasmus Villemoes 2015-06-25 1658 strreplace(journal->j_devname, '/', '!');
4b905671d2ea09 Jan Kara 2009-01-06 1659 jbd2_stats_proc_init(journal);
4b905671d2ea09 Jan Kara 2009-01-06 1660
470decc613ab20 Dave Kleikamp 2006-10-11 1661 return journal;
470decc613ab20 Dave Kleikamp 2006-10-11 1662 }
470decc613ab20 Dave Kleikamp 2006-10-11 1663

:::::: The code at line 1649 was first introduced by commit
:::::: 470decc613ab2048b619a01028072d932d9086ee [PATCH] jbd2: initial copy of files from jbd

:::::: TO: Dave Kleikamp <shaggy@austin.ibm.com>
:::::: CC: Linus Torvalds <torvalds@g5.osdl.org>

--
0-DAY CI Kernel Test Service