Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

kernel test robot
2024-01-31T07:54:15Z

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131]
[cannot apply to drm-misc/drm-misc-next rafael-pm/devprop]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-video-Handle-fetching-EDID-that-is-longer-than-256-bytes/20240131-032909
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240130192608.11666-3-mario.limonciello%40amd.com
patch subject: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper
config: i386-buildonly-randconfig-002-20240131 (https://download.01.org/0day-ci/archive/20240131/202401311541.bDe2glWR-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240131/202401311541.bDe2glWR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401311541.bDe2glWR-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/platform/x86/dell/dell-wmi-ddv.c:647:12: error: call to undeclared function 'acpi_device_uid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
647 | uid_str = acpi_device_uid(acpi_dev);
| ^
>> drivers/platform/x86/dell/dell-wmi-ddv.c:647:10: error: incompatible integer to pointer conversion assigning to 'const char *' from 'int' [-Wint-conversion]
647 | uid_str = acpi_device_uid(acpi_dev);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/platform/x86/dell/dell-wmi-ddv.c:660:35: error: call to undeclared function 'to_acpi_device'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
660 | ret = dell_wmi_ddv_battery_index(to_acpi_device(dev->parent), &index);
| ^
>> drivers/platform/x86/dell/dell-wmi-ddv.c:660:35: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'struct acpi_device *' [-Wint-conversion]
660 | ret = dell_wmi_ddv_battery_index(to_acpi_device(dev->parent), &index);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/dell/dell-wmi-ddv.c:643:59: note: passing argument to parameter 'acpi_dev' here
643 | static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index)
| ^
drivers/platform/x86/dell/dell-wmi-ddv.c:679:35: error: call to undeclared function 'to_acpi_device'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
679 | ret = dell_wmi_ddv_battery_index(to_acpi_device(dev->parent), &index);
| ^
drivers/platform/x86/dell/dell-wmi-ddv.c:679:35: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'struct acpi_device *' [-Wint-conversion]
679 | ret = dell_wmi_ddv_battery_index(to_acpi_device(dev->parent), &index);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/dell/dell-wmi-ddv.c:643:59: note: passing argument to parameter 'acpi_dev' here
643 | static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index)
| ^
drivers/platform/x86/dell/dell-wmi-ddv.c:705:35: error: call to undeclared function 'to_acpi_device'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
705 | ret = dell_wmi_ddv_battery_index(to_acpi_device(battery->dev.parent), &index);
| ^
drivers/platform/x86/dell/dell-wmi-ddv.c:705:35: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'struct acpi_device *' [-Wint-conversion]
705 | ret = dell_wmi_ddv_battery_index(to_acpi_device(battery->dev.parent), &index);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/dell/dell-wmi-ddv.c:643:59: note: passing argument to parameter 'acpi_dev' here
643 | static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index)
| ^
8 errors generated.

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ACPI_WMI
Depends on [n]: X86_PLATFORM_DEVICES [=y] && ACPI [=n]
Selected by [m]:
- DRM [=m] && HAS_IOMEM [=y] && (AGP [=n] || AGP [=n]=n) && !EMULATED_CMPXCHG && HAS_DMA [=y] && X86 [=y]

vim +660 drivers/platform/x86/dell/dell-wmi-ddv.c

3b7eeff93d2912 Armin Wolf 2023-02-09 642
a77272c1604186 Armin Wolf 2022-09-27 643 static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index)
a77272c1604186 Armin Wolf 2022-09-27 644 {
a77272c1604186 Armin Wolf 2022-09-27 645 const char *uid_str;
a77272c1604186 Armin Wolf 2022-09-27 646
a77272c1604186 Armin Wolf 2022-09-27 @647 uid_str = acpi_device_uid(acpi_dev);
a77272c1604186 Armin Wolf 2022-09-27 648 if (!uid_str)
a77272c1604186 Armin Wolf 2022-09-27 649 return -ENODEV;
a77272c1604186 Armin Wolf 2022-09-27 650
a77272c1604186 Armin Wolf 2022-09-27 651 return kstrtou32(uid_str, 10, index);
a77272c1604186 Armin Wolf 2022-09-27 652 }
a77272c1604186 Armin Wolf 2022-09-27 653
a77272c1604186 Armin Wolf 2022-09-27 654 static ssize_t temp_show(struct device *dev, struct device_attribute *attr, char *buf)
a77272c1604186 Armin Wolf 2022-09-27 655 {
a77272c1604186 Armin Wolf 2022-09-27 656 struct dell_wmi_ddv_data *data = container_of(attr, struct dell_wmi_ddv_data, temp_attr);
a77272c1604186 Armin Wolf 2022-09-27 657 u32 index, value;
a77272c1604186 Armin Wolf 2022-09-27 658 int ret;
a77272c1604186 Armin Wolf 2022-09-27 659
a77272c1604186 Armin Wolf 2022-09-27 @660 ret = dell_wmi_ddv_battery_index(to_acpi_device(dev->parent), &index);
a77272c1604186 Armin Wolf 2022-09-27 661 if (ret < 0)
a77272c1604186 Armin Wolf 2022-09-27 662 return ret;
a77272c1604186 Armin Wolf 2022-09-27 663
a77272c1604186 Armin Wolf 2022-09-27 664 ret = dell_wmi_ddv_query_integer(data->wdev, DELL_DDV_BATTERY_TEMPERATURE, index, &value);
a77272c1604186 Armin Wolf 2022-09-27 665 if (ret < 0)
a77272c1604186 Armin Wolf 2022-09-27 666 return ret;
a77272c1604186 Armin Wolf 2022-09-27 667
0331b1b0ba6537 Armin Wolf 2023-02-18 668 /* Use 2731 instead of 2731.5 to avoid unnecessary rounding */
0331b1b0ba6537 Armin Wolf 2023-02-18 669 return sysfs_emit(buf, "%d\n", value - 2731);
a77272c1604186 Armin Wolf 2022-09-27 670 }
a77272c1604186 Armin Wolf 2022-09-27 671