Re: [PATCH 06/11] s390/boot: vmlinux.lds.S: Handle '.rela' sections

Fangrui Song
2024-02-14T21:32:24Z

On Wed, Feb 14, 2024 at 4:18 AM Heiko Carstens <hca@linux.ibm.com> wrote:
>
> On Mon, Feb 12, 2024 at 09:18:34PM -0800, Fangrui Song wrote:
> > > ASSERT(SIZEOF(.plt) == 0, "Unexpected run-time procedure linkages detected!")
> > > + .rela.dyn : {
> > > + *(.rela.*) *(.rela_*)
> > > + }
> > > + ASSERT(SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations (.rela) detected!")
> ...
> > Commit 5354e84598f264793265cc99b4be2a2295826c86 ("x86/build: Add
> > asserts for unwanted sections")
> > specifies `*(.rela.*) *(.rela_*)` but it's not clear why `.rela_*` is
> > included. We only need .rela.* (see also ld.bfd --verbose)
> >
> > This patch LGTM with this changed.
>
> I'll keep it as it is, just to be consistent with x86.

Sent https://lore.kernel.org/all/20240214212929.3753766-1-maskray@google.com/
("[PATCH] x86/build: Simplify patterns for unwanted section")
to simplify the patterns in x86 vmlinux.lds.S:)

--
宋方睿