Re: [PATCH 06/11] s390/boot: vmlinux.lds.S: Handle '.rela' sections

Heiko Carstens
2024-02-14T12:18:11Z

On Mon, Feb 12, 2024 at 09:18:34PM -0800, Fangrui Song wrote:
> > ASSERT(SIZEOF(.plt) == 0, "Unexpected run-time procedure linkages detected!")
> > + .rela.dyn : {
> > + *(.rela.*) *(.rela_*)
> > + }
> > + ASSERT(SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations (.rela) detected!")
...
> Commit 5354e84598f264793265cc99b4be2a2295826c86 ("x86/build: Add
> asserts for unwanted sections")
> specifies `*(.rela.*) *(.rela_*)` but it's not clear why `.rela_*` is
> included. We only need .rela.* (see also ld.bfd --verbose)
>
> This patch LGTM with this changed.

I'll keep it as it is, just to be consistent with x86.