* Re: [PATCH 1/3] tee: optee: Move pool_op helper functions
[not found] <20240213145239.379875-2-balint.dobszay@arm.com>
@ 2024-02-14 13:11 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-02-14 13:11 UTC (permalink / raw)
To: Balint Dobszay, op-tee, linux-doc, linux-kernel, linux-arm-kernel
Cc: llvm, oe-kbuild-all, jens.wiklander, sumit.garg, corbet,
balint.dobszay, sudeep.holla, gyorgy.szing
Hi Balint,
kernel test robot noticed the following build errors:
[auto build test ERROR on lwn/docs-next]
[also build test ERROR on soc/for-next linus/master v6.8-rc4 next-20240214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Balint-Dobszay/tee-optee-Move-pool_op-helper-functions/20240213-225716
base: git://git.lwn.net/linux.git docs-next
patch link: https://lore.kernel.org/r/20240213145239.379875-2-balint.dobszay%40arm.com
patch subject: [PATCH 1/3] tee: optee: Move pool_op helper functions
config: i386-buildonly-randconfig-002-20240214 (https://download.01.org/0day-ci/archive/20240214/202402142000.xRg35j1i-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240214/202402142000.xRg35j1i-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402142000.xRg35j1i-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/tee/tee_shm.c:227:15: error: call to undeclared function 'virt_to_phys'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
227 | shm->paddr = virt_to_phys(shm->kaddr);
| ^
1 error generated.
vim +/virt_to_phys +227 drivers/tee/tee_shm.c
204
205 int tee_shm_pool_op_alloc_helper(struct tee_shm_pool *pool, struct tee_shm *shm,
206 size_t size, size_t align,
207 int (*shm_register)(struct tee_context *ctx,
208 struct tee_shm *shm,
209 struct page **pages,
210 size_t num_pages,
211 unsigned long start))
212 {
213 size_t nr_pages = roundup(size, PAGE_SIZE) / PAGE_SIZE;
214 struct page **pages;
215 unsigned int i;
216 int rc = 0;
217
218 /*
219 * Ignore alignment since this is already going to be page aligned
220 * and there's no need for any larger alignment.
221 */
222 shm->kaddr = alloc_pages_exact(nr_pages * PAGE_SIZE,
223 GFP_KERNEL | __GFP_ZERO);
224 if (!shm->kaddr)
225 return -ENOMEM;
226
> 227 shm->paddr = virt_to_phys(shm->kaddr);
228 shm->size = nr_pages * PAGE_SIZE;
229
230 pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
231 if (!pages) {
232 rc = -ENOMEM;
233 goto err;
234 }
235
236 for (i = 0; i < nr_pages; i++)
237 pages[i] = virt_to_page((u8 *)shm->kaddr + i * PAGE_SIZE);
238
239 shm->pages = pages;
240 shm->num_pages = nr_pages;
241
242 if (shm_register) {
243 rc = shm_register(shm->ctx, shm, pages, nr_pages,
244 (unsigned long)shm->kaddr);
245 if (rc)
246 goto err;
247 }
248
249 return 0;
250 err:
251 free_pages_exact(shm->kaddr, shm->size);
252 shm->kaddr = NULL;
253 return rc;
254 }
255 EXPORT_SYMBOL_GPL(tee_shm_pool_op_alloc_helper);
256
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread