Re: [PATCH v2 2/3] scripts: generate_rust_target: enable building on RISC-V

Conor Dooley
2024-02-27T10:17:42Z

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Fri, Feb 23, 2024 at 03:39:47PM +0100, Miguel Ojeda wrote:

> Conor Dooley <conor@kernel.org> wrote:

> Thanks for this Connor!

> arm64 is sending these for 6.9:
>
> https://git.kernel.org/arm64/c/f82811e22b48
> https://git.kernel.org/arm64/c/724a75ac9542
>
> So it would be nice to see if it may be already possible to enable it
> via a builtin target + flags instead of the custom target, e.g. arm64
> does:
>
> KBUILD_RUSTFLAGS += --target=aarch64-unknown-none -Ctarget-feature="-neon"
>
> and so on.
>
> If it does not work, it would be good to know what would be needed for
> RISC-V and put it into the unstable features / wanted features list
> for Rust.

Sure, I'll take a look.

> Either way, it is not a blocker (although you will need a rebase after
> arm64 lands to use the `target.json` in the right places).

Nah, I think that is silly. Either this goes in as-is, and there's
fixup done by Linus, or the thing should be converted to match arm64,
assuming that that is possible.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]