[PATCH 4/7] ARM: proc: Use inlines instead of defines

Linus Walleij
2024-02-25T20:08:17Z

We currently access the per-cpu vtable with defines such
as:

define cpu_proc_init PROC_VTABLE(_proc_init)

Convert all of these instances to static inlines instead:

static inline __nocfi void cpu_proc_init(void)
{
PROC_VTABLE(_proc_init)();
}

This has the upside that we can add the __nocfi tag to
the inline function so CFI can skip over this and work,
and we can simplify some platform code that was looking
into the symbol table to be able to call cpu_reset(),
now we can just call it instead.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/common/mcpm_entry.c | 10 ++------
arch/arm/include/asm/proc-fns.h | 57 +++++++++++++++++++++++++++++++++--------
arch/arm/mach-sunxi/mc_smp.c | 7 +----
3 files changed, 50 insertions(+), 24 deletions(-)

diff --git a/arch/arm/common/mcpm_entry.c b/arch/arm/common/mcpm_entry.c
index e013ff1168d3..3e19f246caff 100644
--- a/arch/arm/common/mcpm_entry.c
+++ b/arch/arm/common/mcpm_entry.c
@@ -234,13 +234,10 @@ int mcpm_cpu_power_up(unsigned int cpu, unsigned int cluster)
return ret;
}

-typedef typeof(cpu_reset) phys_reset_t;
-
void mcpm_cpu_power_down(void)
{
unsigned int mpidr, cpu, cluster;
bool cpu_going_down, last_man;
- phys_reset_t phys_reset;

mpidr = read_cpuid_mpidr();
cpu = MPIDR_AFFINITY_LEVEL(mpidr, 0);
@@ -298,8 +295,7 @@ void mcpm_cpu_power_down(void)
* the kernel as if the power_up method just had deasserted reset
* on the CPU.
*/
- phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset);
- phys_reset(__pa_symbol(mcpm_entry_point), false);
+ cpu_reset(__pa_symbol(mcpm_entry_point), false);

/* should never get here */
BUG();
@@ -376,7 +372,6 @@ static int __init nocache_trampoline(unsigned long _arg)
unsigned int mpidr = read_cpuid_mpidr();
unsigned int cpu = MPIDR_AFFINITY_LEVEL(mpidr, 0);
unsigned int cluster = MPIDR_AFFINITY_LEVEL(mpidr, 1);
- phys_reset_t phys_reset;

mcpm_set_entry_vector(cpu, cluster, cpu_resume_no_hyp);
setup_mm_for_reboot();
@@ -387,8 +382,7 @@ static int __init nocache_trampoline(unsigned long _arg)
__mcpm_outbound_leave_critical(cluster, CLUSTER_DOWN);
__mcpm_cpu_down(cpu, cluster);

- phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset);
- phys_reset(__pa_symbol(mcpm_entry_point), false);
+ cpu_reset(__pa_symbol(mcpm_entry_point), false);
BUG();
}

diff --git a/arch/arm/include/asm/proc-fns.h b/arch/arm/include/asm/proc-fns.h
index 280396483f5d..9bd6bf5f901a 100644
--- a/arch/arm/include/asm/proc-fns.h
+++ b/arch/arm/include/asm/proc-fns.h
@@ -131,18 +131,55 @@ static inline void init_proc_vtable(const struct processor *p)
}
#endif

-#define cpu_proc_init PROC_VTABLE(_proc_init)
-#define cpu_check_bugs PROC_VTABLE(check_bugs)
-#define cpu_proc_fin PROC_VTABLE(_proc_fin)
-#define cpu_reset PROC_VTABLE(reset)
-#define cpu_do_idle PROC_VTABLE(_do_idle)
-#define cpu_dcache_clean_area PROC_TABLE(dcache_clean_area)
-#define cpu_set_pte_ext PROC_TABLE(set_pte_ext)
-#define cpu_do_switch_mm PROC_VTABLE(switch_mm)
+static inline void __nocfi cpu_proc_init(void)
+{
+ PROC_VTABLE(_proc_init)();
+}
+static inline void __nocfi cpu_check_bugs(void)
+{
+ PROC_VTABLE(check_bugs)();
+}
+static inline void __nocfi cpu_proc_fin(void)
+{
+ PROC_VTABLE(_proc_fin)();
+}
+static inline void __nocfi cpu_reset(unsigned long addr, bool hvc)
+{
+ PROC_VTABLE(reset)(addr, hvc);
+}
+static inline int __nocfi cpu_do_idle(void)
+{
+ return PROC_VTABLE(_do_idle)();
+}
+static inline void __nocfi cpu_dcache_clean_area(void *addr, int size)
+{
+ PROC_TABLE(dcache_clean_area)(addr, size);
+}
+#ifdef CONFIG_ARM_LPAE
+static inline void __nocfi cpu_set_pte_ext(pte_t *ptep, pte_t pte)
+{
+ PROC_TABLE(set_pte_ext)(ptep, pte);
+}
+#else
+static inline void __nocfi cpu_set_pte_ext(pte_t *ptep, pte_t pte, unsigned int ext)
+{
+ PROC_TABLE(set_pte_ext)(ptep, pte, ext);
+}
+#endif
+static inline void __nocfi cpu_do_switch_mm(phys_addr_t pgd_phys, struct mm_struct *mm)
+{
+ PROC_VTABLE(switch_mm)(pgd_phys, mm);
+}

/* These two are private to arch/arm/kernel/suspend.c */
-#define cpu_do_suspend PROC_VTABLE(do_suspend)
-#define cpu_do_resume PROC_VTABLE(do_resume)
+static inline void __nocfi cpu_do_suspend(void *p)
+{
+ PROC_VTABLE(do_suspend)(p);
+}
+static inline void __nocfi cpu_do_resume(void *p)
+{
+ PROC_VTABLE(do_resume)(p);
+}
#endif

extern void cpu_resume(void);
diff --git a/arch/arm/mach-sunxi/mc_smp.c b/arch/arm/mach-sunxi/mc_smp.c
index 277f6aa8e6c2..791eabb7d433 100644
--- a/arch/arm/mach-sunxi/mc_smp.c
+++ b/arch/arm/mach-sunxi/mc_smp.c
@@ -646,17 +646,12 @@ static bool __init sunxi_mc_smp_cpu_table_init(void)
*
* We need the trampoline code to enable CCI-400 on the first cluster
*/
-typedef typeof(cpu_reset) phys_reset_t;
-
static int __init nocache_trampoline(unsigned long __unused)
{
- phys_reset_t phys_reset;
-
setup_mm_for_reboot();
sunxi_cluster_cache_disable_without_axi();

- phys_reset = (phys_reset_t)(unsigned long)__pa_symbol(cpu_reset);
- phys_reset(__pa_symbol(sunxi_mc_smp_resume), false);
+ cpu_reset(__pa_symbol(sunxi_mc_smp_resume), false);
BUG();
}

--
2.34.1