llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [jlayton:kdevops 32/32] fs/nfs/dir.c:3016:55: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long'
Date: Wed, 13 Mar 2024 23:44:06 +0800	[thread overview]
Message-ID: <202403132338.CWHUYS6y-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git kdevops
head:   4ec306101c72fc8541ddf40bd996f0cd289db377
commit: 244db11a7d6835249946adae4255d53cb0edf7f6 [32/32] DEBUG: more printks
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20240313/202403132338.CWHUYS6y-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 503c55e17037436dcd45ac69dea8967e67e3f5e8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240313/202403132338.CWHUYS6y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403132338.CWHUYS6y-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from fs/nfs/dir.c:30:
   In file included from include/linux/mm.h:2188:
   include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     522 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> fs/nfs/dir.c:3016:55: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
    3016 |                 trace_printk("%s: cache_validity=0x%x\n", __func__, nfsi->cache_validity);
         |                                                    ~~               ^~~~~~~~~~~~~~~~~~~~
         |                                                    %lx
   2 warnings generated.


vim +3016 fs/nfs/dir.c

  2996	
  2997	static int nfs_access_get_cached_locked(struct inode *inode, const struct cred *cred, u32 *mask, bool may_block)
  2998	{
  2999		struct nfs_inode *nfsi = NFS_I(inode);
  3000		u64 login_time = nfs_access_login_time(current, cred);
  3001		struct nfs_access_entry *cache;
  3002		bool retry = true;
  3003		int err;
  3004	
  3005		spin_lock(&inode->i_lock);
  3006		for(;;) {
  3007			if (nfsi->cache_validity & NFS_INO_INVALID_ACCESS)
  3008				goto out_zap;
  3009			cache = nfs_access_search_rbtree(inode, cred);
  3010			err = -ENOENT;
  3011			if (cache == NULL)
  3012				goto out;
  3013			/* Found an entry, is our attribute cache valid? */
  3014			if (!nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS))
  3015				break;
> 3016			trace_printk("%s: cache_validity=0x%x\n", __func__, nfsi->cache_validity);
  3017			if (!retry)
  3018				break;
  3019			err = -ECHILD;
  3020			if (!may_block)
  3021				goto out;
  3022			spin_unlock(&inode->i_lock);
  3023			err = __nfs_revalidate_inode(NFS_SERVER(inode), inode);
  3024			if (err)
  3025				return err;
  3026			spin_lock(&inode->i_lock);
  3027			retry = false;
  3028		}
  3029		err = -ENOENT;
  3030		if ((s64)(login_time - cache->timestamp) > 0)
  3031			goto out;
  3032		*mask = cache->mask;
  3033		list_move_tail(&cache->lru, &nfsi->access_cache_entry_lru);
  3034		err = 0;
  3035	out:
  3036		spin_unlock(&inode->i_lock);
  3037		return err;
  3038	out_zap:
  3039		spin_unlock(&inode->i_lock);
  3040		nfs_access_zap_cache(inode);
  3041		return -ENOENT;
  3042	}
  3043	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-03-13 15:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202403132338.CWHUYS6y-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jlayton@kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).