Re: [RFC PATCH v15 17/21] fsverity: consume builtin signature via LSM hook

Re: [RFC PATCH v15 17/21] fsverity: consume builtin signature via LSM hook

[kernel test robot]

Hi Fan,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master next-20240315]
[cannot apply to device-mapper-dm/for-next lwn/docs-next v6.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Fan-Wu/security-add-ipe-lsm/20240316-114235
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/1710560151-28904-18-git-send-email-wufan%40linux.microsoft.com
patch subject: [RFC PATCH v15 17/21] fsverity: consume builtin signature via LSM hook
config: x86_64-buildonly-randconfig-006-20240317 (https://download.01.org/0day-ci/archive/20240317/202403171729.j4sXFWcI-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240317/202403171729.j4sXFWcI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403171729.j4sXFWcI-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from fs/verity/open.c:11:
   include/linux/security.h:1029:33: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
    1029 |                                               enum lsm_intgr_type, type,
         |                                                                    ^
         |                                                                    int
   include/linux/security.h:1029:31: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
    1029 |                                               enum lsm_intgr_type, type,
         |                                                                  ^
   include/linux/security.h:1519:32: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
    1519 |                                              enum lsm_intgr_type, type,
         |                                                                   ^
         |                                                                   int
   include/linux/security.h:1519:30: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
    1519 |                                              enum lsm_intgr_type, type,
         |                                                                 ^
>> fs/verity/open.c:182:36: error: too few arguments to function call, expected 5, have 4
     180 |         return security_inode_setintegrity(inode, LSM_INTGR_FSV_SIG,
         |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~
     181 |                                            desc->signature,
     182 |                                            le32_to_cpu(desc->sig_size));
         |                                                                       ^
   include/linux/security.h:1028:19: note: 'security_inode_setintegrity' declared here
    1028 | static inline int security_inode_setintegrity(struct inode *inode,
         |                   ^                           ~~~~~~~~~~~~~~~~~~~~
    1029 |                                               enum lsm_intgr_type, type,
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~
    1030 |                                               const void *value, size_t size)
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings and 3 errors generated.


vim +182 fs/verity/open.c

   175	
   176	#ifdef CONFIG_FS_VERITY_BUILTIN_SIGNATURES
   177	static int fsverity_inode_setintegrity(struct inode *inode,
   178					       const struct fsverity_descriptor *desc)
   179	{
   180		return security_inode_setintegrity(inode, LSM_INTGR_FSV_SIG,
   181						   desc->signature,
 > 182						   le32_to_cpu(desc->sig_size));
   183	}
   184	#else
   185	static inline int fsverity_inode_setintegrity(struct inode *inode,
   186						      const struct fsverity_descriptor *desc)
   187	{
   188		return 0;
   189	}
   190	#endif /* CONFIG_FS_VERITY_BUILTIN_SIGNATURES */
   191	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki