From: Steven Rostedt <rostedt@goodmis.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, llvm@lists.linux.dev,
patches@lists.linux.dev,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare
Date: Tue, 19 Mar 2024 18:15:09 -0400 [thread overview]
Message-ID: <20240319181509.25bacdc5@gandalf.local.home> (raw)
In-Reply-To: <20240319-tracing-fully-silence-wstring-compare-v1-0-81adb44403f5@kernel.org>
On Tue, 19 Mar 2024 09:07:51 -0700
Nathan Chancellor <nathan@kernel.org> wrote:
> Hi all,
>
> This series fully resolves the new instance of -Wstring-compare from
> within the __assign_str() macro. The first patch resolves a build
> failure with GCC that would be seen with just the second patch applied.
> The second patch actually hides the warning.
>
> NOTE: This is based on trace/for-next, which does not contain the
> minimum LLVM version bump that occurred later in the current merge
> window, so this uses
>
> __diag_ignore(clang, 11, ...
>
> instead of
>
> __diag_ignore(clang, 13, ...
>
> which will be required when this is merged into Linus's tree. If you can
> base this series on a tree that has the merge commit e5eb28f6d1af ("Merge
> tag 'mm-nonmm-stable-2024-03-14-09-36' of
> git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm") in it, then that
> change can be done at application time, rather than merge time (or I can
> send a v2). It would be really nice for this to make the merge window so
> that this warning does not proliferate into other trees that base on
> -rc1.
>
I'm guessing this isn't needed with the last update.
-- Steve
next prev parent reply other threads:[~2024-03-19 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 16:07 [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare Nathan Chancellor
2024-03-19 16:07 ` [PATCH 1/2] compiler_types: Ensure __diag_clang() is always available Nathan Chancellor
2024-03-20 0:35 ` Justin Stitt
2024-03-19 16:07 ` [PATCH 2/2] tracing: Ignore -Wstring-compare with diagnostic macros Nathan Chancellor
2024-03-20 0:30 ` Justin Stitt
2024-03-20 0:37 ` Steven Rostedt
2024-03-19 22:15 ` Steven Rostedt [this message]
2024-03-19 22:27 ` [PATCH 0/2] tracing: Fully silence instance of -Wstring-compare Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240319181509.25bacdc5@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=llvm@lists.linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox