From: Jakub Kicinski <kuba@kernel.org>
To: Sean Christopherson <seanjc@google.com>
Cc: Kees Cook <keescook@chromium.org>, Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL
Date: Tue, 9 Apr 2024 16:09:20 -0700 [thread overview]
Message-ID: <20240409160920.3bfe3eeb@kernel.org> (raw)
In-Reply-To: <20240409224256.1581292-1-seanjc@google.com>
On Tue, 9 Apr 2024 15:42:56 -0700 Sean Christopherson wrote:
> - ksft_test_result_code(t->exit_code, test_name,
> - diagnostic ? "%s" : "", diagnostic);
> + ksft_test_result_code(t->exit_code, test_name, "%s", diagnostic);
Have you tested that to make sure it doesn't change the output?
.. warning: ^^ leading question ;)
next prev parent reply other threads:[~2024-04-09 23:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 22:42 [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL Sean Christopherson
2024-04-09 23:09 ` Jakub Kicinski [this message]
2024-04-09 23:46 ` Kees Cook
2024-04-09 23:53 ` Jakub Kicinski
2024-04-10 0:14 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409160920.3bfe3eeb@kernel.org \
--to=kuba@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).