Re: [PATCH 2/3] s390/smsgiucv_app: Remove function pointer cast

Arnd Bergmann
2024-04-17T18:56:48Z

On Wed, Apr 17, 2024, at 20:24, Nathan Chancellor wrote:
> Clang warns (or errors with CONFIG_WERROR) after enabling
> -Wcast-function-type-strict by default:
>
> drivers/s390/net/smsgiucv_app.c:176:26: error: cast from 'void
> (*)(const void *)' to 'void (*)(struct device *)' converts to
> incompatible function type [-Werror,-Wcast-function-type-strict]
> 176 | smsg_app_dev->release = (void (*)(struct device *))
> kfree;
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> Add a standalone function to fix the warning properly, which addresses
> the root of the warning that these casts are not safe for kCFI.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>