Re: [PATCH v3 2/4] media: v4l: Support obtaining link frequency via get_mbus_config

kernel test robot
2024-04-29T17:44:01Z

Hi Sakari,

kernel test robot noticed the following build errors:

[auto build test ERROR on 12e3384b874e9f67c3e98ce501561fe5a54a0add]

url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-Support-passing-sub-device-argument-to-v4l2_get_link_freq/20240429-234508
base: 12e3384b874e9f67c3e98ce501561fe5a54a0add
patch link: https://lore.kernel.org/r/20240429153704.1005192-3-sakari.ailus%40linux.intel.com
patch subject: [PATCH v3 2/4] media: v4l: Support obtaining link frequency via get_mbus_config
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240430/202404300105.00zkm4JV-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240430/202404300105.00zkm4JV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404300105.00zkm4JV-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/media/v4l2-core/v4l2-common.c:512:2: error: use of undeclared identifier 'ret'
ret = v4l2_subdev_call(sd, pad, get_mbus_config, pad->index,
^
drivers/media/v4l2-core/v4l2-common.c:514:6: error: use of undeclared identifier 'ret'
if (ret < 0 && ret != -ENOIOCTLCMD)
^
drivers/media/v4l2-core/v4l2-common.c:514:17: error: use of undeclared identifier 'ret'
if (ret < 0 && ret != -ENOIOCTLCMD)
^
drivers/media/v4l2-core/v4l2-common.c:515:10: error: use of undeclared identifier 'ret'
return ret;
^
4 errors generated.

vim +/ret +512 drivers/media/v4l2-core/v4l2-common.c

504
505 s64 __v4l2_get_link_freq_pad(struct media_pad *pad, unsigned int mul,
506 unsigned int div)
507 {
508 struct v4l2_mbus_config mbus_config = {};
509 struct v4l2_subdev *sd;
510
511 sd = media_entity_to_v4l2_subdev(pad->entity);
> 512 ret = v4l2_subdev_call(sd, pad, get_mbus_config, pad->index,
513 &mbus_config);
514 if (ret < 0 && ret != -ENOIOCTLCMD)
515 return ret;
516
517 return mbus_config.link_freq ?:
518 __v4l2_get_link_freq_ctrl(sd->ctrl_handler, mul, div);
519 }
520 EXPORT_SYMBOL_GPL(__v4l2_get_link_freq_pad);
521

--
0-DAY CI Kernel Test Service