Re: [PATCH net-next 0/2] gve: Minor cleanups

Larysa Zaremba
2024-05-07T17:08:22Z

On Fri, May 03, 2024 at 09:31:25PM +0100, Simon Horman wrote:
> Hi,
>
> This short patchset provides two minor cleanups for the gve driver.
>
> These were found by tooling as mentioned in each patch,
> and otherwise by inspection.
>
> No change in run time behaviour is intended.
> Each patch is compile tested only.
>

Both patches look fine to me.

Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>

> ---
> Simon Horman (2):
> gve: Avoid unnecessary use of comma operator
> gve: Use ethtool_sprintf/puts() to fill stats strings
>
> drivers/net/ethernet/google/gve/gve_adminq.c | 4 +--
> drivers/net/ethernet/google/gve/gve_ethtool.c | 42 +++++++++++----------------
> 2 files changed, 19 insertions(+), 27 deletions(-)
>
> base-commit: 5829614a7b3b2cc9820efb2d29a205c00d748fcf
>
>