Re: [PATCH net-next 1/2] gve: Avoid unnecessary use of comma operator

Dan Carpenter
2024-05-03T20:40:23Z

On Fri, May 03, 2024 at 09:31:26PM +0100, Simon Horman wrote:
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>

Huh. Interesting. I wrote a check for that in Smatch. The only place
where it would matter would be in an if statement.

if (foo)
frob1(),
frob2();

It's unexpected that frob2() is included in the if statement. But I
was never able to find any of these actual bugs so I gave up.

regards,
dan carpenter