public inbox for llvm@lists.linux.dev
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: angquan yu <angquan21@gmail.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Binbin Wu <binbin.wu@linux.intel.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Sohil Mehta <sohil.mehta@intel.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Valentin Obst <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev, x86@kernel.org,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 7/7] selftests/x86: fix printk() format warnings
Date: Thu,  2 May 2024 20:02:14 -0700	[thread overview]
Message-ID: <20240503030214.86681-8-jhubbard@nvidia.com> (raw)
In-Reply-To: <20240503030214.86681-1-jhubbard@nvidia.com>

First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang finds and warns about several cases of using the wrong integer
size in various printk() format strings.

Fix each by matching it with the size of the associated variable.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/x86/sigreturn.c     |  2 +-
 tools/testing/selftests/x86/test_vsyscall.c | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/x86/sigreturn.c b/tools/testing/selftests/x86/sigreturn.c
index 5d7961a5f7f6..0b75b29f794b 100644
--- a/tools/testing/selftests/x86/sigreturn.c
+++ b/tools/testing/selftests/x86/sigreturn.c
@@ -487,7 +487,7 @@ static void sigtrap(int sig, siginfo_t *info, void *ctx_void)
 	greg_t asm_ss = ctx->uc_mcontext.gregs[REG_CX];
 	if (asm_ss != sig_ss && sig == SIGTRAP) {
 		/* Sanity check failure. */
-		printf("[FAIL]\tSIGTRAP: ss = %hx, frame ss = %hx, ax = %llx\n",
+		printf("[FAIL]\tSIGTRAP: ss = %hx, frame ss = %x, ax = %llx\n",
 		       ss, *ssptr(ctx), (unsigned long long)asm_ss);
 		nerrs++;
 	}
diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
index bef6abac331c..63aa3abcd741 100644
--- a/tools/testing/selftests/x86/test_vsyscall.c
+++ b/tools/testing/selftests/x86/test_vsyscall.c
@@ -328,7 +328,7 @@ static int test_getcpu(int cpu)
 
 	if (ret_sys == 0) {
 		if (cpu_sys != cpu) {
-			printf("[FAIL]\tsyscall reported CPU %hu but should be %d\n", cpu_sys, cpu);
+			printf("[FAIL]\tsyscall reported CPU %u but should be %d\n", cpu_sys, cpu);
 			nerrs++;
 		}
 
@@ -347,14 +347,14 @@ static int test_getcpu(int cpu)
 			}
 
 			if (cpu_vdso != cpu) {
-				printf("[FAIL]\tvDSO reported CPU %hu but should be %d\n", cpu_vdso, cpu);
+				printf("[FAIL]\tvDSO reported CPU %u but should be %d\n", cpu_vdso, cpu);
 				nerrs++;
 			} else {
 				printf("[OK]\tvDSO reported correct CPU\n");
 			}
 
 			if (node_vdso != node) {
-				printf("[FAIL]\tvDSO reported node %hu but should be %hu\n", node_vdso, node);
+				printf("[FAIL]\tvDSO reported node %u but should be %u\n", node_vdso, node);
 				nerrs++;
 			} else {
 				printf("[OK]\tvDSO reported correct node\n");
@@ -373,14 +373,14 @@ static int test_getcpu(int cpu)
 			}
 
 			if (cpu_vsys != cpu) {
-				printf("[FAIL]\tvsyscall reported CPU %hu but should be %d\n", cpu_vsys, cpu);
+				printf("[FAIL]\tvsyscall reported CPU %u but should be %d\n", cpu_vsys, cpu);
 				nerrs++;
 			} else {
 				printf("[OK]\tvsyscall reported correct CPU\n");
 			}
 
 			if (node_vsys != node) {
-				printf("[FAIL]\tvsyscall reported node %hu but should be %hu\n", node_vsys, node);
+				printf("[FAIL]\tvsyscall reported node %u but should be %u\n", node_vsys, node);
 				nerrs++;
 			} else {
 				printf("[OK]\tvsyscall reported correct node\n");
-- 
2.45.0


      parent reply	other threads:[~2024-05-03  3:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03  3:02 [PATCH 0/7] selftests/x86: fix build errors and warnings found via clang John Hubbard
2024-05-03  3:02 ` [PATCH 1/7] selftests/x86: fix Makefile dependencies to work with clang John Hubbard
2024-05-03  3:02 ` [PATCH 2/7] selftests/x86: build test_FISTTP.c " John Hubbard
2024-05-03  3:02 ` [PATCH 3/7] selftests/x86: build fsgsbase_restore.c " John Hubbard
2024-05-03  3:02 ` [PATCH 4/7] selftests/x86: build sysret_rip.c " John Hubbard
2024-05-03  3:02 ` [PATCH 5/7] selftests/x86: avoid -no-pie warnings from clang during compilation John Hubbard
2024-05-03  3:02 ` [PATCH 6/7] selftests/x86: remove (or use) unused variables and functions John Hubbard
2024-05-03  3:02 ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240503030214.86681-8-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=adobriyan@gmail.com \
    --cc=angquan21@gmail.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kernel@valentinobst.de \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mingo@kernel.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=shuah@kernel.org \
    --cc=sohil.mehta@intel.com \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox