From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A456963A5 for ; Wed, 15 May 2024 01:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715735306; cv=none; b=lGqC4fTJCdZ9K2NGe/SUfEUGGkBvXhl1smIxM5S3ld3XjBBZUyr8ATJtuzRgoT8mTby0V8e3yA76JCnl3hdyR7N1sb2fgIUZxh7RYkskPvGNVCAI/dlTQPXVpYl2wvByXV+AN2yZEpFOveYDA2T4pHD7XMh5zz5Qa7UboBUHwTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715735306; c=relaxed/simple; bh=oyJWajRkLDqCw9oJG9U+0dlQmfxVnFzaN8r6oj7GOCA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GxRF/Iy5T0MlWiACM8gwEBhMNQjjAlB5PWFDVGSXf0bqqcllFVCYhS3mYloSnY2rLfCD0DoOfHXz4xRmVj9Ma8+ar6Iy2q7FQCwpdeHvBWdp1JgH/0phIKs3nfKe6bEvk4Cu7A4bJZFGnFRoykiTV4+4qbuGFlwCd+OX5gdoTMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U29sKAQ6; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U29sKAQ6" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e3c3aa8938so43673975ad.1 for ; Tue, 14 May 2024 18:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715735304; x=1716340104; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+ArnKmY2SNEE019PWvX0oi4RldbPZEm9aOqhpk2Km3M=; b=U29sKAQ6nyhSgOYWfwH513FrTBY1m70XAaXZR50k0WNCAYPc8x6VOvDpFls19UX5Cm s7Ti8AJ+XBr9khHvJ82FdhUUfM8huZXM/8cYvMzXHLkgAw8Ct51UWOWEz2nR36236ee4 LZUWxmlLcrAktyIr9cKAw/cWYtIIPnk5z9pyw+Q1IO/KN6eiBWkP8A7PHKVNbYozwK1X ZrDxv5JN4lgbYuB43La9TMAVFqkiBTP59N3z+cBgJegwFdqecBaJi7bUNZ3Cl18r7GaP q1+zBl1vMf0aEfWXDylz+KYKAStNHdN5rvR4YcQFwKEUZMVr3Cz+GvxW3bZBmxepV7MY UgWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715735304; x=1716340104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ArnKmY2SNEE019PWvX0oi4RldbPZEm9aOqhpk2Km3M=; b=ik84QrLOzn3jDDNA6EW+YeLtmqBaGq+MK9Px48NxlYQqtjQnUsfI5/FkMg6YMC/KxM egenIYhePJaDsLSiwFbNH3/raMEFZ73Zq8/bdGJY1k6RX1yVAFaXXdNLPdVgcNlm0x+J WpWWjbvIuXIs6E//HFGch2ORCn4t2nNdrRITIhs3wDGlKGcGKdniTHGhldY9HVGrlyLa o/ikT3JVhW0Igtqc2mhGUEYySRlI9cVUdbgmmpMSEFHE8U6eVNkFAYZgu9xZ5hpzpUjx 5CKESTqLnMjaYN+84UJuruDizOFHtiHD/W+rGWzVN2tk9SkE3WD7hyHDFaLMuOu+SjaH atOQ== X-Forwarded-Encrypted: i=1; AJvYcCWOzJHvW+rh/RMO2r9uTYfzuI/Ss2izZ1SQW5V1eijPKEQu68jjJNpS9OksvFJKAR22qjYMGIgUsIJzvJ3RxnMeRAYUUA== X-Gm-Message-State: AOJu0YyiyTrWkuoRLJmbvVZ+0VJL4d6fMjxn6HTFWhxgUJ2SUyyPdCoV Mw5L5/U3WnWrWLu9q9t8nj418T/ZTo6zjsaCE/oJCBVCJgCBjzFzG+u4C8etxGA= X-Google-Smtp-Source: AGHT+IF135Fit2u4At4WSiYKdWhQq3a1gyLpgbaK6/+dOWZFE+pWu2CSdp35tRjLjy2zY6YVBFNOkA== X-Received: by 2002:a17:903:11c4:b0:1e4:9c2f:d343 with SMTP id d9443c01a7336-1ef43c0fd9dmr166471975ad.7.1715735304007; Tue, 14 May 2024 18:08:24 -0700 (PDT) Received: from server.ucalgary.ca (S0106f85e42401d5e.cg.shawcable.net. [174.0.240.170]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d16cfsm104973325ad.18.2024.05.14.18.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 18:08:23 -0700 (PDT) From: Abhinav Saxena To: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Cc: Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Abhinav Saxena Subject: [RFC PATCH 2/4] selftests/binderfs: Update close_prot_errno_disarm macro to do{...}while(false) structure for safety Date: Wed, 15 May 2024 01:08:03 +0000 Message-Id: <20240515010805.605511-3-xandfury@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240515010805.605511-1-xandfury@gmail.com> References: <20240515010805.605511-1-xandfury@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enclosing the close_prot_errno_disarm macro in do {...} while (false) structure could prevent potential bugs and undefined behavior. Example code: #define BINDERFUNC(x) f(x); g(x); if (condition) BINDERFUNC(x); When BINDERFUNC(x) expands, g(x) would be executed outside of if block. Enclosing the macro under do{...}while(false) adds a scope to the macro, making it safer. Signed-off-by: Abhinav Saxena --- .../filesystems/binderfs/binderfs_test.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c index 447ec4296e69..4a149e3d4ba4 100644 --- a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c +++ b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c @@ -28,13 +28,15 @@ #define PTR_TO_INT(p) ((int)((intptr_t)(p))) #define INT_TO_PTR(u) ((void *)((intptr_t)(u))) -#define close_prot_errno_disarm(fd) \ - if (fd >= 0) { \ - int _e_ = errno; \ - close(fd); \ - errno = _e_; \ - fd = -EBADF; \ - } +#define close_prot_errno_disarm(fd) \ + do { \ + if (fd >= 0) { \ + int _e_ = errno; \ + close(fd); \ + errno = _e_; \ + fd = -EBADF; \ + } \ + } while (false) static void change_mountns(struct __test_metadata *_metadata) { -- 2.34.1