[jic23-cxl-staging:arm-numa-fixes 10/11] arch/arm64/mm/init.c:54:12: warning: no previous prototype for function 'numa_fill_memblks'

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/cxl-staging.git arm-numa-fixes
head:   d077bf9570e8024f6d670d5662b62778715084fc
commit: f4ce7f00375d478828eebf7618d56dce35607227 [10/11] arm64: mm: numa_fill_memblks() to add a memblock.reserved region if match.
config: arm64-randconfig-002-20240515 (https://download.01.org/0day-ci/archive/20240516/202405160319.ggK7PjJZ-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d3455f4ddd16811401fa153298fadd2f59f6914e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240516/202405160319.ggK7PjJZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405160319.ggK7PjJZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from arch/arm64/mm/init.c:12:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:2210:
   include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     522 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> arch/arm64/mm/init.c:54:12: warning: no previous prototype for function 'numa_fill_memblks' [-Wmissing-prototypes]
      54 | int __init numa_fill_memblks(u64 start, u64 end)
         |            ^
   arch/arm64/mm/init.c:54:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      54 | int __init numa_fill_memblks(u64 start, u64 end)
         | ^
         | static 
   arch/arm64/mm/init.c:89:5: error: redefinition of 'memory_add_physaddr_to_nid'
      89 | int memory_add_physaddr_to_nid(u64 start)
         |     ^
   arch/arm64/include/asm/sparsemem.h:32:36: note: expanded from macro 'memory_add_physaddr_to_nid'
      32 | #define memory_add_physaddr_to_nid memory_add_physaddr_to_nid
         |                                    ^
   include/linux/numa.h:47:19: note: previous definition is here
      47 | static inline int memory_add_physaddr_to_nid(u64 start)
         |                   ^
   arch/arm64/mm/init.c:101:5: error: redefinition of 'phys_to_target_node'
     101 | int phys_to_target_node(phys_addr_t start)
         |     ^
   arch/arm64/include/asm/sparsemem.h:34:29: note: expanded from macro 'phys_to_target_node'
      34 | #define phys_to_target_node phys_to_target_node
         |                             ^
   include/linux/numa.h:51:19: note: previous definition is here
      51 | static inline int phys_to_target_node(u64 start)
         |                   ^
   2 warnings and 2 errors generated.


vim +/numa_fill_memblks +54 arch/arm64/mm/init.c

    49	
    50	/*
    51	 * Scan existing memblocks and if this region overlaps with a region with
    52	 * a nid set, add a reserved memblock.
    53	 */
  > 54	int __init numa_fill_memblks(u64 start, u64 end)
    55	{
    56		struct memblock_region *region;
    57	
    58		for_each_mem_region(region) {
    59			int nid = memblock_get_region_node(region);
    60	
    61			if (nid == NUMA_NO_NODE)
    62				continue;
    63			if (!(end < region->base || start >= region->base + region->size)) {
    64				memblock_add_reserved_node(start, end - start, nid,
    65							   MEMBLOCK_RSRV_NOINIT);
    66				return 0;
    67			}
    68		}
    69	
    70		memblock_add_reserved_node(start, end - start, NUMA_NO_NODE,
    71					   MEMBLOCK_RSRV_NOINIT);
    72	
    73		return NUMA_NO_MEMBLK;
    74	}
    75	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki