From: kernel test robot <lkp@intel.com>
To: Hector Martin <marcan@marcan.st>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, Janne Grunau <j@jannau.net>
Subject: [arm-platforms:kvm-arm64/mmu-pgt 309/874] drivers/tty/serial/samsung_tty.c:2085:3: warning: misleading indentation; statement is not part of the previous 'if'
Date: Sat, 18 May 2024 15:59:46 +0800 [thread overview]
Message-ID: <202405181545.QHb8P5Ei-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git kvm-arm64/mmu-pgt
head: 1ed29f79e7c6441ef29c25a43d7c82d91e884dcc
commit: 05c68699aca4de1b69a49a8a6b2b80ff2956cf12 [309/874] tty: serial: samsung_tty: Support runtime PM
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240518/202405181545.QHb8P5Ei-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240518/202405181545.QHb8P5Ei-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405181545.QHb8P5Ei-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/tty/serial/samsung_tty.c:2085:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
uart_remove_one_port(&s3c24xx_uart_drv, port);
^
drivers/tty/serial/samsung_tty.c:2083:2: note: previous statement is here
if (port)
^
1 warning generated.
vim +/if +2085 drivers/tty/serial/samsung_tty.c
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2077
77772addc1f110 drivers/tty/serial/samsung_tty.c Uwe Kleine-König 2023-11-10 2078 static void s3c24xx_serial_remove(struct platform_device *dev)
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2079 {
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2080 struct uart_port *port = s3c24xx_dev_to_port(&dev->dev);
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2081 struct s3c24xx_uart_port *ourport = to_ourport(port);
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2082
b1617c7888476e drivers/tty/serial/samsung_tty.c Tudor Ambarus 2024-01-19 2083 if (port)
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2084 pm_runtime_get_sync(&dev->dev);
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 @2085 uart_remove_one_port(&s3c24xx_uart_drv, port);
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2086
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2087 clk_disable_unprepare(ourport->clk);
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2088 if (!IS_ERR(ourport->baudclk))
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2089 clk_disable_unprepare(ourport->baudclk);
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2090
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2091 pm_runtime_disable(&dev->dev);
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2092 pm_runtime_set_suspended(&dev->dev);
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2093 pm_runtime_put_noidle(&dev->dev);
05c68699aca4de drivers/tty/serial/samsung_tty.c Hector Martin 2021-09-20 2094
6f134c3c770355 drivers/tty/serial/samsung.c Tushar Behera 2014-01-20 2095 uart_unregister_driver(&s3c24xx_uart_drv);
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2096 }
b497549a035c2a drivers/serial/samsung.c Ben Dooks 2008-07-03 2097
:::::: The code at line 2085 was first introduced by commit
:::::: b497549a035c2a81b71c7a27f2b00c8a16c09423 [ARM] S3C24XX: Split serial driver into core and per-cpu drivers
:::::: TO: Ben Dooks <ben-linux@fluff.org>
:::::: CC: Ben Dooks <ben-linux@fluff.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-05-18 8:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405181545.QHb8P5Ei-lkp@intel.com \
--to=lkp@intel.com \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=marcan@marcan.st \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox