From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872B410F2; Sat, 25 May 2024 04:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716611111; cv=none; b=eayaGzaQDgf1rVXHdZf1YZELYXG+JZcPakvPVgYvTyYSIHyAzxG1ydSxlwvYoITQRbBJjRpibAm1glQs3YM2IO6wFz7xHrkwHUhD/l8bjZhwSWSgIJ04LzXh6qMT4ny348E3bugWPqhlDh+T/Pm75QyiRrKcU6w5lLzCf6mVj5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716611111; c=relaxed/simple; bh=TPQMrZsBoP7RCgzOMhTGeMoLZbkYV+G5dpFhbVqguzM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AU3f9KCYuaOv7iUnCWHmLRWoP2ZgKpyZJTvyghJZXIaAaI/ZPp4h6MS5PoPR457VmOzQj+Kht+pY9uQGkkmE/5yqE2bZjITRH+skPL3zxD5I5X9J8EuNrwIh1vFhw/4BUY7CL0ouYAIk6jTDok0xGYAOTcx4KT0AUsXhaa+wLVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KJ9B26ou; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KJ9B26ou" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716611109; x=1748147109; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TPQMrZsBoP7RCgzOMhTGeMoLZbkYV+G5dpFhbVqguzM=; b=KJ9B26ouAyzNnCMKWhcnT5oJHc2fRLpRFQuM2xv+DFC6o/FeR1X8R3GV NuRtdyCc6FJiV72pZARFX4CRKVh1U7NE4mnfxVdcVOOFIbDESixado5gK JB6fSmpw5D07HpczKhs+e6UdsuGwvNdry+PRNqlhpXIvJiquN+md0R2jc W6T879XFH9UHWB0gIY7AQIwqvJLN9wZmka1QHrUvw6BAtB9d5BOKUUROZ fmshz+VxdOD5gTyTmJzQ7xGOUWRk1ARAvZp757+jj2If5J/tYoQ20foF+ N7JSEYY3fc1lH/pmyC4W9cGDLVCRlwetA3/FrN5ZRFWlkWesZQTnu7T+Y w==; X-CSE-ConnectionGUID: F3/MgqbURC2VyZiPN/6b8Q== X-CSE-MsgGUID: dOtei23oRf+TSNZRZeIeEw== X-IronPort-AV: E=McAfee;i="6600,9927,11082"; a="13182376" X-IronPort-AV: E=Sophos;i="6.08,187,1712646000"; d="scan'208";a="13182376" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 21:25:09 -0700 X-CSE-ConnectionGUID: lJl9FDWcRtK480aJrFsXqw== X-CSE-MsgGUID: gxT47ohFT8iYEkbhwBbnIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,187,1712646000"; d="scan'208";a="34100623" Received: from unknown (HELO 0610945e7d16) ([10.239.97.151]) by orviesa010.jf.intel.com with ESMTP; 24 May 2024 21:25:07 -0700 Received: from kbuild by 0610945e7d16 with local (Exim 4.96) (envelope-from ) id 1sAixt-0006VV-1N; Sat, 25 May 2024 04:25:05 +0000 Date: Sat, 25 May 2024 12:24:05 +0800 From: kernel test robot To: "Russell King (Oracle)" Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code Message-ID: <202405251257.hL6jMiJW-lkp@intel.com> References: Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Russell, [This is a private test report for your RFC patch.] kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-stmmac-remove-pcs_ctrl_ane-method-and-associated-code/20240525-090556 base: net-next/main patch link: https://lore.kernel.org/r/E1s6C4O-00Ck6O-9D%40rmk-PC.armlinux.org.uk patch subject: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code config: arm-defconfig (https://download.01.org/0day-ci/archive/20240525/202405251257.hL6jMiJW-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240525/202405251257.hL6jMiJW-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202405251257.hL6jMiJW-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:628:3: error: implicit declaration of function 'stmmac_pcs_ctrl_ane' is invalid in C99 [-Werror,-Wimplicit-function-declaration] stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0); ^ drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:628:3: note: did you mean 'stmmac_pcs_clean'? drivers/net/ethernet/stmicro/stmmac/stmmac.h:381:6: note: 'stmmac_pcs_clean' declared here void stmmac_pcs_clean(struct net_device *ndev); ^ 1 error generated. vim +/stmmac_pcs_ctrl_ane +628 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c a7c30e62d4b895 Vinod Koul 2019-01-21 607 981d947bcd382c Sneh Shah 2023-12-12 608 /* On interface toggle MAC registers gets reset. 981d947bcd382c Sneh Shah 2023-12-12 609 * Configure MAC block for SGMII on ethernet phy link up 981d947bcd382c Sneh Shah 2023-12-12 610 */ 463120c31c58bb Bartosz Golaszewski 2023-06-19 611 static int ethqos_configure_sgmii(struct qcom_ethqos *ethqos) 463120c31c58bb Bartosz Golaszewski 2023-06-19 612 { a818bd12538c14 Sneh Shah 2024-02-20 613 struct net_device *dev = platform_get_drvdata(ethqos->pdev); a818bd12538c14 Sneh Shah 2024-02-20 614 struct stmmac_priv *priv = netdev_priv(dev); 463120c31c58bb Bartosz Golaszewski 2023-06-19 615 int val; 463120c31c58bb Bartosz Golaszewski 2023-06-19 616 463120c31c58bb Bartosz Golaszewski 2023-06-19 617 val = readl(ethqos->mac_base + MAC_CTRL_REG); 463120c31c58bb Bartosz Golaszewski 2023-06-19 618 463120c31c58bb Bartosz Golaszewski 2023-06-19 619 switch (ethqos->speed) { a818bd12538c14 Sneh Shah 2024-02-20 620 case SPEED_2500: a818bd12538c14 Sneh Shah 2024-02-20 621 val &= ~ETHQOS_MAC_CTRL_PORT_SEL; a818bd12538c14 Sneh Shah 2024-02-20 622 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG, a818bd12538c14 Sneh Shah 2024-02-20 623 RGMII_CONFIG2_RGMII_CLK_SEL_CFG, a818bd12538c14 Sneh Shah 2024-02-20 624 RGMII_IO_MACRO_CONFIG2); a818bd12538c14 Sneh Shah 2024-02-20 625 if (ethqos->serdes_speed != SPEED_2500) a818bd12538c14 Sneh Shah 2024-02-20 626 phy_set_speed(ethqos->serdes_phy, SPEED_2500); a818bd12538c14 Sneh Shah 2024-02-20 627 ethqos->serdes_speed = SPEED_2500; a818bd12538c14 Sneh Shah 2024-02-20 @628 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0); a818bd12538c14 Sneh Shah 2024-02-20 629 break; 463120c31c58bb Bartosz Golaszewski 2023-06-19 630 case SPEED_1000: 463120c31c58bb Bartosz Golaszewski 2023-06-19 631 val &= ~ETHQOS_MAC_CTRL_PORT_SEL; 463120c31c58bb Bartosz Golaszewski 2023-06-19 632 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG, 463120c31c58bb Bartosz Golaszewski 2023-06-19 633 RGMII_CONFIG2_RGMII_CLK_SEL_CFG, 463120c31c58bb Bartosz Golaszewski 2023-06-19 634 RGMII_IO_MACRO_CONFIG2); a818bd12538c14 Sneh Shah 2024-02-20 635 if (ethqos->serdes_speed != SPEED_1000) a818bd12538c14 Sneh Shah 2024-02-20 636 phy_set_speed(ethqos->serdes_phy, SPEED_1000); a818bd12538c14 Sneh Shah 2024-02-20 637 ethqos->serdes_speed = SPEED_1000; a818bd12538c14 Sneh Shah 2024-02-20 638 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0); 463120c31c58bb Bartosz Golaszewski 2023-06-19 639 break; 463120c31c58bb Bartosz Golaszewski 2023-06-19 640 case SPEED_100: 463120c31c58bb Bartosz Golaszewski 2023-06-19 641 val |= ETHQOS_MAC_CTRL_PORT_SEL | ETHQOS_MAC_CTRL_SPEED_MODE; a818bd12538c14 Sneh Shah 2024-02-20 642 if (ethqos->serdes_speed != SPEED_1000) a818bd12538c14 Sneh Shah 2024-02-20 643 phy_set_speed(ethqos->serdes_phy, SPEED_1000); a818bd12538c14 Sneh Shah 2024-02-20 644 ethqos->serdes_speed = SPEED_1000; a818bd12538c14 Sneh Shah 2024-02-20 645 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0); 463120c31c58bb Bartosz Golaszewski 2023-06-19 646 break; 463120c31c58bb Bartosz Golaszewski 2023-06-19 647 case SPEED_10: 463120c31c58bb Bartosz Golaszewski 2023-06-19 648 val |= ETHQOS_MAC_CTRL_PORT_SEL; 463120c31c58bb Bartosz Golaszewski 2023-06-19 649 val &= ~ETHQOS_MAC_CTRL_SPEED_MODE; 981d947bcd382c Sneh Shah 2023-12-12 650 rgmii_updatel(ethqos, RGMII_CONFIG_SGMII_CLK_DVDR, 981d947bcd382c Sneh Shah 2023-12-12 651 FIELD_PREP(RGMII_CONFIG_SGMII_CLK_DVDR, 981d947bcd382c Sneh Shah 2023-12-12 652 SGMII_10M_RX_CLK_DVDR), 981d947bcd382c Sneh Shah 2023-12-12 653 RGMII_IO_MACRO_CONFIG); a818bd12538c14 Sneh Shah 2024-02-20 654 if (ethqos->serdes_speed != SPEED_1000) a818bd12538c14 Sneh Shah 2024-02-20 655 phy_set_speed(ethqos->serdes_phy, ethqos->speed); a818bd12538c14 Sneh Shah 2024-02-20 656 ethqos->serdes_speed = SPEED_1000; a818bd12538c14 Sneh Shah 2024-02-20 657 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0); 463120c31c58bb Bartosz Golaszewski 2023-06-19 658 break; 463120c31c58bb Bartosz Golaszewski 2023-06-19 659 } 463120c31c58bb Bartosz Golaszewski 2023-06-19 660 463120c31c58bb Bartosz Golaszewski 2023-06-19 661 writel(val, ethqos->mac_base + MAC_CTRL_REG); 463120c31c58bb Bartosz Golaszewski 2023-06-19 662 463120c31c58bb Bartosz Golaszewski 2023-06-19 663 return val; 463120c31c58bb Bartosz Golaszewski 2023-06-19 664 } 463120c31c58bb Bartosz Golaszewski 2023-06-19 665 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki