From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: angquan yu <angquan21@gmail.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
Binbin Wu <binbin.wu@linux.intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Sohil Mehta <sohil.mehta@intel.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev, x86@kernel.org,
John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v3 3/7] selftests/x86: build fsgsbase_restore.c with clang
Date: Fri, 31 May 2024 12:38:34 -0700 [thread overview]
Message-ID: <20240531193838.108454-4-jhubbard@nvidia.com> (raw)
In-Reply-To: <20240531193838.108454-1-jhubbard@nvidia.com>
When building with clang, via:
make LLVM=1 -C tools/testing/selftests
Fix this by moving the inline asm to "pure" assembly, in two new files:
clang_helpers_32.S, clang_helpers_64.S.
As a bonus, the pure asm avoids the need for ifdefs, and is now very
simple and easy on the eyes.
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
tools/testing/selftests/x86/Makefile | 2 ++
tools/testing/selftests/x86/clang_helpers_32.S | 11 +++++++++++
tools/testing/selftests/x86/clang_helpers_64.S | 12 ++++++++++++
tools/testing/selftests/x86/fsgsbase_restore.c | 11 +++++------
4 files changed, 30 insertions(+), 6 deletions(-)
create mode 100644 tools/testing/selftests/x86/clang_helpers_32.S
create mode 100644 tools/testing/selftests/x86/clang_helpers_64.S
diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index c1269466e0f8..99bc2ef84f5a 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -113,6 +113,8 @@ endef
$(eval $(call extra-files,sysret_ss_attrs_64,thunks.S))
$(eval $(call extra-files,ptrace_syscall_32,raw_syscall_helper_32.S))
$(eval $(call extra-files,test_syscall_vdso_32,thunks_32.S))
+$(eval $(call extra-files,fsgsbase_restore_64,clang_helpers_64.S))
+$(eval $(call extra-files,fsgsbase_restore_32,clang_helpers_32.S))
# check_initial_reg_state is special: it needs a custom entry, and it
# needs to be static so that its interpreter doesn't destroy its initial
diff --git a/tools/testing/selftests/x86/clang_helpers_32.S b/tools/testing/selftests/x86/clang_helpers_32.S
new file mode 100644
index 000000000000..dc16271bac70
--- /dev/null
+++ b/tools/testing/selftests/x86/clang_helpers_32.S
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * 32-bit assembly helpers for asm operations that lack support in both gcc and
+ * clang. For example, clang asm does not support segment prefixes.
+ */
+.global dereference_seg_base
+dereference_seg_base:
+ mov %fs:(0), %eax
+ ret
+
+.section .note.GNU-stack,"",%progbits
diff --git a/tools/testing/selftests/x86/clang_helpers_64.S b/tools/testing/selftests/x86/clang_helpers_64.S
new file mode 100644
index 000000000000..0d81c71cad97
--- /dev/null
+++ b/tools/testing/selftests/x86/clang_helpers_64.S
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * 64-bit assembly helpers for asm operations that lack support in both gcc and
+ * clang. For example, clang asm does not support segment prefixes.
+ */
+.global dereference_seg_base
+
+dereference_seg_base:
+ mov %gs:(0), %rax
+ ret
+
+.section .note.GNU-stack,"",%progbits
diff --git a/tools/testing/selftests/x86/fsgsbase_restore.c b/tools/testing/selftests/x86/fsgsbase_restore.c
index 6fffadc51579..224058c1e4b2 100644
--- a/tools/testing/selftests/x86/fsgsbase_restore.c
+++ b/tools/testing/selftests/x86/fsgsbase_restore.c
@@ -39,12 +39,11 @@
# define SEG "%fs"
#endif
-static unsigned int dereference_seg_base(void)
-{
- int ret;
- asm volatile ("mov %" SEG ":(0), %0" : "=rm" (ret));
- return ret;
-}
+/*
+ * Defined in clang_helpers_[32|64].S, because unlike gcc, clang inline asm does
+ * not support segmentation prefixes.
+ */
+unsigned int dereference_seg_base(void);
static void init_seg(void)
{
--
2.45.1
next prev parent reply other threads:[~2024-05-31 19:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 19:38 [PATCH v3 0/7] selftests/x86: fix build errors and warnings found via clang John Hubbard
2024-05-31 19:38 ` [PATCH v3 1/7] selftests/x86: fix Makefile dependencies to work with clang John Hubbard
2024-05-31 19:38 ` [PATCH v3 2/7] selftests: x86: test_FISTTP: use fisttps instead of ambiguous fisttp John Hubbard
2024-05-31 19:38 ` John Hubbard [this message]
2024-05-31 19:38 ` [PATCH v3 4/7] selftests/x86: build sysret_rip.c with clang John Hubbard
2024-05-31 19:38 ` [PATCH v3 5/7] selftests/x86: avoid -no-pie warnings from clang during compilation John Hubbard
2024-06-07 22:23 ` John Hubbard
2024-05-31 19:38 ` [PATCH v3 6/7] selftests/x86: remove (or use) unused variables and functions John Hubbard
2024-05-31 19:38 ` [PATCH v3 7/7] selftests/x86: fix printk warnings reported by clang John Hubbard
2024-06-28 20:06 ` [PATCH v3 0/7] selftests/x86: fix build errors and warnings found via clang John Hubbard
2024-07-02 10:28 ` Muhammad Usama Anjum
2024-07-04 3:08 ` John Hubbard
2024-07-04 5:48 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531193838.108454-4-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=adobriyan@gmail.com \
--cc=angquan21@gmail.com \
--cc=binbin.wu@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kernel@valentinobst.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=shuah@kernel.org \
--cc=sohil.mehta@intel.com \
--cc=usama.anjum@collabora.com \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).