From: kernel test robot <lkp@intel.com>
To: Yan Zhai <yan@cloudflare.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC v2 net-next 1/7] net: add rx_sk to trace_kfree_skb
Date: Sat, 1 Jun 2024 20:56:47 +0800 [thread overview]
Message-ID: <202406012054.AjuaAUPn-lkp@intel.com> (raw)
In-Reply-To: <451ae2a5c2ddb3c127cfddaf4a6579d6e85791f3.1717206060.git.yan@cloudflare.com>
Hi Yan,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Yan-Zhai/net-add-rx_sk-to-trace_kfree_skb/20240601-094726
base: net-next/main
patch link: https://lore.kernel.org/r/451ae2a5c2ddb3c127cfddaf4a6579d6e85791f3.1717206060.git.yan%40cloudflare.com
patch subject: [RFC v2 net-next 1/7] net: add rx_sk to trace_kfree_skb
config: arm-randconfig-002-20240601 (https://download.01.org/0day-ci/archive/20240601/202406012054.AjuaAUPn-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project bafda89a0944d947fc4b3b5663185e07a397ac30)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240601/202406012054.AjuaAUPn-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406012054.AjuaAUPn-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from net/core/drop_monitor.c:10:
In file included from include/linux/netdevice.h:38:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/arm/include/asm/cacheflush.h:10:
In file included from include/linux/mm.h:2253:
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> net/core/drop_monitor.c:1162:32: error: incompatible function pointer types passing 'void (*const)(void *, struct sk_buff *, void *, enum skb_drop_reason)' to parameter of type 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)' [-Wincompatible-function-pointer-types]
1162 | rc = register_trace_kfree_skb(ops->kfree_skb_probe, NULL);
| ^~~~~~~~~~~~~~~~~~~~
include/trace/events/skb.h:24:1: note: passing argument to parameter 'probe' here
24 | TRACE_EVENT(kfree_skb,
| ^
include/linux/tracepoint.h:568:2: note: expanded from macro 'TRACE_EVENT'
568 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
| ^
include/linux/tracepoint.h:434:2: note: expanded from macro 'DECLARE_TRACE'
434 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
| ^
include/linux/tracepoint.h:270:31: note: expanded from macro '__DECLARE_TRACE'
270 | register_trace_##name(void (*probe)(data_proto), void *data) \
| ^
net/core/drop_monitor.c:1177:29: error: incompatible function pointer types passing 'void (*const)(void *, struct sk_buff *, void *, enum skb_drop_reason)' to parameter of type 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)' [-Wincompatible-function-pointer-types]
1177 | unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
| ^~~~~~~~~~~~~~~~~~~~
include/trace/events/skb.h:24:1: note: passing argument to parameter 'probe' here
24 | TRACE_EVENT(kfree_skb,
| ^
include/linux/tracepoint.h:568:2: note: expanded from macro 'TRACE_EVENT'
568 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
| ^
include/linux/tracepoint.h:434:2: note: expanded from macro 'DECLARE_TRACE'
434 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
| ^
include/linux/tracepoint.h:283:33: note: expanded from macro '__DECLARE_TRACE'
283 | unregister_trace_##name(void (*probe)(data_proto), void *data) \
| ^
net/core/drop_monitor.c:1200:29: error: incompatible function pointer types passing 'void (*const)(void *, struct sk_buff *, void *, enum skb_drop_reason)' to parameter of type 'void (*)(void *, struct sk_buff *, void *, enum skb_drop_reason, struct sock *)' [-Wincompatible-function-pointer-types]
1200 | unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
| ^~~~~~~~~~~~~~~~~~~~
include/trace/events/skb.h:24:1: note: passing argument to parameter 'probe' here
24 | TRACE_EVENT(kfree_skb,
| ^
include/linux/tracepoint.h:568:2: note: expanded from macro 'TRACE_EVENT'
568 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
| ^
include/linux/tracepoint.h:434:2: note: expanded from macro 'DECLARE_TRACE'
434 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
| ^
include/linux/tracepoint.h:283:33: note: expanded from macro '__DECLARE_TRACE'
283 | unregister_trace_##name(void (*probe)(data_proto), void *data) \
| ^
1 warning and 3 errors generated.
vim +1162 net/core/drop_monitor.c
8e94c3bc922e70 Ido Schimmel 2019-08-17 1135
7c747838a55818 Ido Schimmel 2019-08-11 1136 static int net_dm_trace_on_set(struct netlink_ext_ack *extack)
9a8afc8d3962f3 Neil Horman 2009-03-11 1137 {
28315f7999870b Ido Schimmel 2019-08-11 1138 const struct net_dm_alert_ops *ops;
70c69274f354ec Ido Schimmel 2019-08-11 1139 int cpu, rc;
4b706372f18de5 Neil Horman 2010-07-20 1140
28315f7999870b Ido Schimmel 2019-08-11 1141 ops = net_dm_alert_ops_arr[net_dm_alert_mode];
28315f7999870b Ido Schimmel 2019-08-11 1142
cad456d5abbb63 Neil Horman 2012-05-17 1143 if (!try_module_get(THIS_MODULE)) {
965100966efe85 Ido Schimmel 2019-08-06 1144 NL_SET_ERR_MSG_MOD(extack, "Failed to take reference on module");
7c747838a55818 Ido Schimmel 2019-08-11 1145 return -ENODEV;
cad456d5abbb63 Neil Horman 2012-05-17 1146 }
cad456d5abbb63 Neil Horman 2012-05-17 1147
70c69274f354ec Ido Schimmel 2019-08-11 1148 for_each_possible_cpu(cpu) {
70c69274f354ec Ido Schimmel 2019-08-11 1149 struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
44075f56379388 Ido Schimmel 2019-08-11 1150 struct sk_buff *skb;
70c69274f354ec Ido Schimmel 2019-08-11 1151
28315f7999870b Ido Schimmel 2019-08-11 1152 INIT_WORK(&data->dm_alert_work, ops->work_item_func);
70c69274f354ec Ido Schimmel 2019-08-11 1153 timer_setup(&data->send_timer, sched_send_work, 0);
44075f56379388 Ido Schimmel 2019-08-11 1154 /* Allocate a new per-CPU skb for the summary alert message and
44075f56379388 Ido Schimmel 2019-08-11 1155 * free the old one which might contain stale data from
44075f56379388 Ido Schimmel 2019-08-11 1156 * previous tracing.
44075f56379388 Ido Schimmel 2019-08-11 1157 */
44075f56379388 Ido Schimmel 2019-08-11 1158 skb = reset_per_cpu_data(data);
44075f56379388 Ido Schimmel 2019-08-11 1159 consume_skb(skb);
70c69274f354ec Ido Schimmel 2019-08-11 1160 }
70c69274f354ec Ido Schimmel 2019-08-11 1161
28315f7999870b Ido Schimmel 2019-08-11 @1162 rc = register_trace_kfree_skb(ops->kfree_skb_probe, NULL);
7c747838a55818 Ido Schimmel 2019-08-11 1163 if (rc) {
7c747838a55818 Ido Schimmel 2019-08-11 1164 NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to kfree_skb() tracepoint");
7c747838a55818 Ido Schimmel 2019-08-11 1165 goto err_module_put;
7c747838a55818 Ido Schimmel 2019-08-11 1166 }
cad456d5abbb63 Neil Horman 2012-05-17 1167
28315f7999870b Ido Schimmel 2019-08-11 1168 rc = register_trace_napi_poll(ops->napi_poll_probe, NULL);
7c747838a55818 Ido Schimmel 2019-08-11 1169 if (rc) {
7c747838a55818 Ido Schimmel 2019-08-11 1170 NL_SET_ERR_MSG_MOD(extack, "Failed to connect probe to napi_poll() tracepoint");
7c747838a55818 Ido Schimmel 2019-08-11 1171 goto err_unregister_trace;
7c747838a55818 Ido Schimmel 2019-08-11 1172 }
7c747838a55818 Ido Schimmel 2019-08-11 1173
7c747838a55818 Ido Schimmel 2019-08-11 1174 return 0;
7c747838a55818 Ido Schimmel 2019-08-11 1175
7c747838a55818 Ido Schimmel 2019-08-11 1176 err_unregister_trace:
28315f7999870b Ido Schimmel 2019-08-11 1177 unregister_trace_kfree_skb(ops->kfree_skb_probe, NULL);
7c747838a55818 Ido Schimmel 2019-08-11 1178 err_module_put:
9398e9c0b1d44e Ido Schimmel 2021-03-10 1179 for_each_possible_cpu(cpu) {
9398e9c0b1d44e Ido Schimmel 2021-03-10 1180 struct per_cpu_dm_data *data = &per_cpu(dm_cpu_data, cpu);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1181 struct sk_buff *skb;
9398e9c0b1d44e Ido Schimmel 2021-03-10 1182
9398e9c0b1d44e Ido Schimmel 2021-03-10 1183 del_timer_sync(&data->send_timer);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1184 cancel_work_sync(&data->dm_alert_work);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1185 while ((skb = __skb_dequeue(&data->drop_queue)))
9398e9c0b1d44e Ido Schimmel 2021-03-10 1186 consume_skb(skb);
9398e9c0b1d44e Ido Schimmel 2021-03-10 1187 }
7c747838a55818 Ido Schimmel 2019-08-11 1188 module_put(THIS_MODULE);
7c747838a55818 Ido Schimmel 2019-08-11 1189 return rc;
7c747838a55818 Ido Schimmel 2019-08-11 1190 }
7c747838a55818 Ido Schimmel 2019-08-11 1191
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2024-06-01 12:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <451ae2a5c2ddb3c127cfddaf4a6579d6e85791f3.1717206060.git.yan@cloudflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406012054.AjuaAUPn-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox