Re: [PATCH v6 1/2] hwmon: Add PEC attribute support to hardware monitoring core

[kernel test robot <lkp@intel.com>]

Hi Radu,

kernel test robot noticed the following build errors:

[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on linus/master v6.10-rc1 next-20240531]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Radu-Sabau/drivers-hwmon-max31827-Add-PEC-support/20240531-165035
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20240531084645.12935-1-radu.sabau%40analog.com
patch subject: [PATCH v6 1/2] hwmon: Add PEC attribute support to hardware monitoring core
config: arm-imxrt_defconfig (https://download.01.org/0day-ci/archive/20240602/202406020416.G7zcrbxZ-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project bafda89a0944d947fc4b3b5663185e07a397ac30)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240602/202406020416.G7zcrbxZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406020416.G7zcrbxZ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/hwmon/hwmon.c:17:
   In file included from include/linux/i2c.h:19:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:2208:
   include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     522 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/hwmon/hwmon.c:400:7: error: call to undeclared function 'i2c_check_functionality'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     400 |             !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_PEC))
         |              ^
   1 warning and 1 error generated.


vim +/i2c_check_functionality +400 drivers/hwmon/hwmon.c

   393	
   394	static int hwmon_pec_register(struct device *hdev)
   395	{
   396		struct i2c_client *client = i2c_verify_client(hdev->parent);
   397		int err;
   398	
   399		if (!client ||
 > 400		    !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_PEC))
   401			return 0;
   402	
   403		err = device_create_file(&client->dev, &dev_attr_pec);
   404		if (err)
   405			return err;
   406	
   407		return devm_add_action_or_reset(hdev, hwmon_remove_pec, &client->dev);
   408	}
   409	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki