llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Youling Tang <tangyouling@kylinos.cn>,
	Jinyang He <hejinyang@loongson.cn>,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, mengqinggang@loongson.cn,
	cailulu@loongson.cn, wanglei@loongson.cn, luweining@loongson.cn,
	Yujie Liu <yujie.liu@intel.com>,
	Heng Qi <hengqi@linux.alibaba.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] loongarch: Only select HAVE_OBJTOOL and allow ORC unwinder if the inline assembler supports R_LARCH_{32,64}_PCREL
Date: Tue, 4 Jun 2024 22:43:28 -0700	[thread overview]
Message-ID: <20240605054328.GA279426@thelio-3990X> (raw)
In-Reply-To: <20240604150741.30252-1-xry111@xry111.site>

On Tue, Jun 04, 2024 at 11:07:41PM +0800, Xi Ruoyao wrote:
> GAS <= 2.41 does not support generating R_LARCH_{32,64}_PCREL for
> "label - ." and it generates R_LARCH_{ADD,SUB}{32,64} pairs instead.
> objtool cannot handle R_LARCH_{ADD,SUB}{32,64} pair in __jump_table
> (static key implementation) and etc. so it will produce some warnings.
> This is causing the kernel CI systems to complain everywhere.
> 
> For GAS we can check if -mthin-add-sub option is available to know if
> R_LARCH_{32,64}_PCREL are supported.
> 
> For Clang, we require Clang >= 18 and Clang >= 17 already supports
> R_LARCH_{32,64}_PCREL, so we can always assume Clang is fine for
> objtool.

For what it's worth, I have noticed some warnings with clang that I
don't see with GCC but I only filed an issue on our GitHub and never
followed up on the mailing list, so sorry about that.

https://github.com/ClangBuiltLinux/linux/issues/2024

Might be tangential to this patch though but I felt it was worth
mentioning.

Cheers,
Nathan

  parent reply	other threads:[~2024-06-05  5:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 15:07 [PATCH] loongarch: Only select HAVE_OBJTOOL and allow ORC unwinder if the inline assembler supports R_LARCH_{32,64}_PCREL Xi Ruoyao
2024-06-05  1:52 ` Huacai Chen
2024-06-05  4:38   ` Xi Ruoyao
2024-06-05  5:21     ` Huacai Chen
2024-06-05  5:25       ` Xi Ruoyao
2024-06-05  2:04 ` Heng Qi
2024-06-05  5:43 ` Nathan Chancellor [this message]
2024-06-05  5:54   ` Xi Ruoyao
2024-06-05  6:25     ` Nathan Chancellor
2024-06-05 10:57       ` Xi Ruoyao
2024-06-05 13:18         ` Xi Ruoyao
2024-06-05 15:13           ` Xi Ruoyao
2024-06-05 15:47             ` Jinyang He
2024-06-05 19:05               ` Xi Ruoyao
2024-06-06  2:10                 ` Jinyang He
2024-06-07  5:42                   ` Xi Ruoyao
2024-06-07  7:14                     ` Jinyang He
2024-06-07  8:29                       ` Xi Ruoyao
2024-06-15  8:45                         ` Huacai Chen
2024-06-15  8:53                           ` Xi Ruoyao
2024-06-15  9:33                             ` Huacai Chen
2024-06-15 10:22                               ` Xi Ruoyao
2024-06-17 13:11                                 ` Huacai Chen
2024-06-17 13:38                                   ` Xi Ruoyao
2024-06-17 13:47                                     ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605054328.GA279426@thelio-3990X \
    --to=nathan@kernel.org \
    --cc=cailulu@loongson.cn \
    --cc=chenhuacai@kernel.org \
    --cc=hejinyang@loongson.cn \
    --cc=hengqi@linux.alibaba.com \
    --cc=justinstitt@google.com \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=loongarch@lists.linux.dev \
    --cc=luweining@loongson.cn \
    --cc=mengqinggang@loongson.cn \
    --cc=morbo@google.com \
    --cc=ndesaulniers@google.com \
    --cc=tangyouling@kylinos.cn \
    --cc=tj@kernel.org \
    --cc=wanglei@loongson.cn \
    --cc=xry111@xry111.site \
    --cc=yangtiezhu@loongson.cn \
    --cc=yujie.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).