From: kernel test robot <lkp@intel.com>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Mike Snitzer <snitzer@kernel.org>,
Jeff Layton <jeff.layton@primarydata.com>,
Peng Tao <tao.peng@primarydata.com>,
Lance Shelton <lance.shelton@hammerspace.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>
Subject: [snitzer:nfs-localio-for-6.11 10/29] fs/nfs/localio.c:289:6: warning: variable 'flags' set but not used
Date: Thu, 6 Jun 2024 14:45:20 +0800 [thread overview]
Message-ID: <202406061403.xiHdI6Ty-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git nfs-localio-for-6.11
head: 252b0c685ae2eafa0ced0682a496e9eecf23d1ff
commit: 1db309e3046ff4d7bc50071001f56700fec36d46 [10/29] nfs/nfsd: add "local io" support
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20240606/202406061403.xiHdI6Ty-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d7d2d4f53fc79b4b58e8d8d08151b577c3699d4a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240606/202406061403.xiHdI6Ty-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406061403.xiHdI6Ty-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from fs/nfs/localio.c:12:
In file included from include/linux/inet.h:42:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:10:
In file included from include/linux/mm.h:2253:
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from fs/nfs/localio.c:12:
In file included from include/linux/inet.h:42:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from fs/nfs/localio.c:12:
In file included from include/linux/inet.h:42:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from fs/nfs/localio.c:12:
In file included from include/linux/inet.h:42:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
>> fs/nfs/localio.c:289:6: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
289 | int flags = O_LARGEFILE;
| ^
8 warnings generated.
vim +/flags +289 fs/nfs/localio.c
277
278 /*
279 * nfs_local_open_fh - open a local filehandle
280 *
281 * Returns a pointer to a struct file or an ERR_PTR
282 */
283 struct file *
284 nfs_local_open_fh(struct nfs_client *clp, const struct cred *cred,
285 struct nfs_fh *fh, const fmode_t mode)
286 {
287 struct nfs_local_open_ctx *ctx = &__local_open_ctx;
288 struct file *filp;
> 289 int flags = O_LARGEFILE;
290 int status;
291
292 switch (mode & (FMODE_READ | FMODE_WRITE)) {
293 case FMODE_READ | FMODE_WRITE:
294 flags |= O_RDWR;
295 break;
296 case FMODE_READ:
297 flags |= O_RDONLY;
298 break;
299 case FMODE_WRITE:
300 flags |= O_WRONLY;
301 break;
302 default:
303 return ERR_PTR(-EINVAL);
304 }
305
306 status = ctx->open_f(clp->cl_rpcclient, cred, fh, mode, &filp);
307 if (status < 0) {
308 dprintk("%s: open local file failed error=%d\n",
309 __func__, status);
310 trace_nfs_local_open_fh(fh, mode, status);
311 switch (status) {
312 case -ENXIO:
313 nfs_local_disable(clp);
314 fallthrough;
315 case -ETIMEDOUT:
316 status = -EAGAIN;
317 }
318 filp = ERR_PTR(status);
319 }
320 return filp;
321 }
322 EXPORT_SYMBOL_GPL(nfs_local_open_fh);
323
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-06-06 6:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406061403.xiHdI6Ty-lkp@intel.com \
--to=lkp@intel.com \
--cc=dros@primarydata.com \
--cc=jeff.layton@primarydata.com \
--cc=lance.shelton@hammerspace.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=snitzer@kernel.org \
--cc=tao.peng@primarydata.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox