* [sj:damon/next 9/47] mm/damon/core.c:705: warning: expecting prototype for damon_commit_quota_goals(). Prototype was for damos_commit_quota_goals() instead
@ 2024-06-16 6:02 kernel test robot
2024-06-16 15:45 ` SeongJae Park
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-06-16 6:02 UTC (permalink / raw)
To: SeongJae Park; +Cc: llvm, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head: dc8dc5011c1230b2f3b20c53eec91368ee9836b4
commit: 7b2776f2db539d498b8ed2c9e4e40c5f2c42296d [9/47] mm/damon/core: implement DAMOS quota goals online commit function
config: i386-buildonly-randconfig-001-20240616 (https://download.01.org/0day-ci/archive/20240616/202406161331.PjF4uMpc-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240616/202406161331.PjF4uMpc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406161331.PjF4uMpc-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> mm/damon/core.c:705: warning: expecting prototype for damon_commit_quota_goals(). Prototype was for damos_commit_quota_goals() instead
vim +705 mm/damon/core.c
691
692 /**
693 * damon_commit_quota_goals() - Commit DAMOS quota goals to another quota.
694 * @dst: The commit destination DAMOS quota.
695 * @src: The commit source DAMOS quota.
696 *
697 * Copies user-specified parameters for quota goals from @src to @dst. Users
698 * should use this function for quota goals-level parameters update of running
699 * DAMON contexts, instead of manual in-place updates.
700 *
701 * This function should be called from parameters-update safe context, like
702 * DAMON callbacks.
703 */
704 int damos_commit_quota_goals(struct damos_quota *dst, struct damos_quota *src)
> 705 {
706 struct damos_quota_goal *dst_goal, *next, *src_goal, *new_goal;
707 int i = 0, j = 0;
708
709 damos_for_each_quota_goal_safe(dst_goal, next, dst) {
710 src_goal = damos_nth_quota_goal(i++, src);
711 if (src_goal)
712 damos_commit_quota_goal(dst_goal, src_goal);
713 else
714 damos_destroy_quota_goal(dst_goal);
715 }
716 damos_for_each_quota_goal_safe(src_goal, next, src) {
717 if (j++ < i)
718 continue;
719 new_goal = damos_new_quota_goal(
720 src_goal->metric, src_goal->target_value);
721 if (!new_goal)
722 return -ENOMEM;
723 damos_add_quota_goal(dst, new_goal);
724 }
725 return 0;
726 }
727
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-16 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-16 6:02 [sj:damon/next 9/47] mm/damon/core.c:705: warning: expecting prototype for damon_commit_quota_goals(). Prototype was for damos_commit_quota_goals() instead kernel test robot
2024-06-16 15:45 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).