From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B517D35280 for ; Tue, 2 Jul 2024 04:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719893944; cv=none; b=PvRoSg6Yepps3Ca5AK95ka23tu0qP1QkPrN+YinPrtCzlHTCUDf1KBAnqgjArje+LkI5CNWRKsdrUVRY8GZfkfSCwTQZeYpjFrmcY96Hewc0ChHQmuxxVAkf50+uwlNjOCaTHTwIFzrdBmwm/tO7Sl1h6oWEK0jHBxO6uySibHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719893944; c=relaxed/simple; bh=rNKqoG/0GCOM8GsjneII0jQL2RDBeKx9Rcnbn0AGs/E=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=FTx0UrU4c8G5R5BE8wXEr4VEUnJ7d/9LFp4aWKM0duOvicoBJmJUC89nAiRf+eiw7/QTLBovq8jv7ac2giH6jNm8ts2Wb91DBN6x3HkE1Df7VHM0Vsl+WiqhMQXi/UpIjZVde27e4bB1k25lGbxTpTYL8W4RNtmAFTvZ19FkuqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WCqR35N7jznYLd; Tue, 2 Jul 2024 12:18:39 +0800 (CST) Received: from kwepemd100011.china.huawei.com (unknown [7.221.188.204]) by mail.maildlp.com (Postfix) with ESMTPS id A6973180064; Tue, 2 Jul 2024 12:18:54 +0800 (CST) Received: from M910t.huawei.com (10.110.54.157) by kwepemd100011.china.huawei.com (7.221.188.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Tue, 2 Jul 2024 12:18:53 +0800 From: Changbin Du To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Nathan Chancellor CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Nick Desaulniers , Bill Wendling , Justin Stitt , , , , Hui Wang , Changbin Du Subject: [PATCH v5 0/8] perf: support specify vdso path in cmdline Date: Tue, 2 Jul 2024 12:18:29 +0800 Message-ID: <20240702041837.5306-1-changbin.du@huawei.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd100011.china.huawei.com (7.221.188.204) The vdso dumped from process memory (in buildid-cache) lacks debugging info. To annotate vdso symbols with source lines we need a debugging version. For x86, we can find them from your local build as 'arch/x86/entry/vdso/vdso{32,64}.so.dbg'. Or they may resides in '/lib/modules//vdso/vdso{32,64}.so' on Ubuntu. But notice that the builid has to match. If user doesn't specify the path, perf will search them internally as long as vmlinux when recording samples. The searched debugging vdso will add to buildid cache. Below samples are captured on my local build kernel. perf succesfully find debugging version vdso and we can annotate with source without specifying vdso path. $ sudo perf record -a $ sudo perf report --objdump=llvm-objdump Samples: 17K of event 'cycles:P', 4000 Hz, Event count (approx.): 1760 __vdso_clock_gettime /work/linux-host/arch/x86/entry/vdso/vdso64.so.d Percent│ movq -48(%rbp),%rsi │ testq %rax,%rax │ ; return vread_hvclock(); │ movq %rax,%rdx │ ; if (unlikely(!vdso_cycles_ok(cycles))) │ ↑ js eb │ ↑ jmp 74 │ ; ts->tv_sec = vdso_ts->sec; 0.02 │147: leaq 2(%rbx),%rax │ shlq $4, %rax │ addq %r10,%rax │ ; while ((seq = READ_ONCE(vd->seq)) & 1) { 9.38 │152: movl (%r10),%ecx When doing cross platform analysis, we need to specify the vdso path if we are interested in its symbols. At most two vdso can be given. Also you can pack your buildid cache with perf-archive if the debugging vdso can be found on the sampled machine. $ sudo perf report --objdump=llvm-objdump \ --vdso arch/x86/entry/vdso/vdso64.so.dbg,arch/x86/entry/vdso/vdso32.so.dbg I also improved perf-buildid-cache command recognize vdso when adding files, then place it at correct place. v5: - Searching the vdso in record stage instead of report. So the debugging vdso will be in build-id cache. This is friendly for cross-machine analysis. - Improve perf-buildid-cache command recognize vdso when adding files v4: - split the refactoring from the actual change. v3: - update documentation. v2: - now search vdso automatically as long as vmlinux, as suggested by Adrian. - remove change 'prefer symsrc_filename for filename'. Changbin Du (8): perf: support specify vdso path in cmdline perf: disasm: refactor function dso__disassemble_filename perf: disasm: use build_id_path if fallback failed perf: build-id: name debugging vdso as "debug" perf: symbol: generalize vmlinux path searching perf: build-id: try to search debugging vdso and add to cache perf: disasm: prefer debugging files in build-id cache perf buildid-cache: recognize vdso when adding files tools/perf/Documentation/perf-annotate.txt | 3 + tools/perf/Documentation/perf-c2c.txt | 3 + tools/perf/Documentation/perf-inject.txt | 3 + tools/perf/Documentation/perf-report.txt | 3 + tools/perf/Documentation/perf-script.txt | 3 + tools/perf/Documentation/perf-top.txt | 3 + tools/perf/builtin-annotate.c | 2 + tools/perf/builtin-buildid-cache.c | 26 ++- tools/perf/builtin-c2c.c | 2 + tools/perf/builtin-inject.c | 2 + tools/perf/builtin-report.c | 2 + tools/perf/builtin-script.c | 2 + tools/perf/builtin-top.c | 2 + tools/perf/util/build-id.c | 57 +++++- tools/perf/util/disasm.c | 131 ++++++++----- tools/perf/util/machine.c | 4 +- tools/perf/util/symbol.c | 209 ++++++++++++++++----- tools/perf/util/symbol.h | 9 +- tools/perf/util/symbol_conf.h | 5 + 19 files changed, 359 insertions(+), 112 deletions(-) -- 2.34.1