[morimoto:sound-msiof-2024-07-19 16/16] sound/soc/sh/msiof.c:470:3: error: use of undeclared identifier 'stop'

[kernel test robot <lkp@intel.com>]

tree:   https://github.com/morimoto/linux sound-msiof-2024-07-19
head:   a12bc552b3fd774fec2214ece9ee022c4808d676
commit: a12bc552b3fd774fec2214ece9ee022c4808d676 [16/16] msiof
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240722/202407221317.aoAlPrsD-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240722/202407221317.aoAlPrsD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407221317.aoAlPrsD-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> sound/soc/sh/msiof.c:470:3: error: use of undeclared identifier 'stop'
     470 |                 stop = 1;
         |                 ^
   sound/soc/sh/msiof.c:477:6: error: use of undeclared identifier 'stop'; did you mean 'stac'?
     477 |         if (stop) {
         |             ^~~~
         |             stac
   arch/x86/include/asm/smap.h:36:29: note: 'stac' declared here
      36 | static __always_inline void stac(void)
         |                             ^
>> sound/soc/sh/msiof.c:482:30: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
     482 |                         dev_warn(dev, "SISTR = %08x\n");
         |                                                ~~~^
   include/linux/dev_printk.h:156:62: note: expanded from macro 'dev_warn'
     156 |         dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                                     ^~~
   include/linux/dev_printk.h:19:22: note: expanded from macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   include/linux/dev_printk.h:110:16: note: expanded from macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   1 warning and 2 errors generated.


vim +/stop +470 sound/soc/sh/msiof.c

   450	
   451	static int msiof_trigger(struct snd_soc_component *component,
   452				 struct snd_pcm_substream *substream, int cmd)
   453	{
   454		struct device *dev = component->dev;
   455		struct msiof_priv *priv = dev_get_drvdata(dev);
   456		unsigned long flags;
   457		int is_play = msiof_is_play(substream);
   458		int ret = -EINVAL;
   459	
   460		spin_lock_irqsave(&priv->lock, flags);
   461	
   462		switch (cmd) {
   463		case SNDRV_PCM_TRIGGER_START:
   464			priv->substream[is_play] = substream;
   465			/* fallthrough */
   466		case SNDRV_PCM_TRIGGER_RESUME:
   467			ret = msiof_hw_start(component, substream, cmd);
   468			break;
   469		case SNDRV_PCM_TRIGGER_STOP:
 > 470			stop = 1;
   471			/* fallthrough */
   472		case SNDRV_PCM_TRIGGER_SUSPEND:
   473			ret = msiof_hw_stop(component, substream, cmd);
   474			break;
   475		}
   476	
 > 477		if (stop) {
   478			u32 sistr = msiof_read(priv, SISTR);
   479	
   480			/* indicate error status if exist */
   481			if (sistr)
 > 482				dev_warn(dev, "SISTR = %08x\n");
   483	
   484			priv->substream[is_play] = NULL;
   485		}
   486	
   487		spin_unlock_irqrestore(&priv->lock, flags);
   488	
   489		return ret;
   490	}
   491	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki