Re: [PATCH v2 1/3] pmdomain: ti_sci: add per-device latency constraint management

Re: [PATCH v2 1/3] pmdomain: ti_sci: add per-device latency constraint management

[kernel test robot]

Hi Kevin,

kernel test robot noticed the following build errors:

[auto build test ERROR on ad7eb1b6b92ee0c959a0a6ae846ddadd7a79ea64]

url:    https://github.com/intel-lab-lkp/linux/commits/Kevin-Hilman/pmdomain-ti_sci-add-per-device-latency-constraint-management/20240820-080207
base:   ad7eb1b6b92ee0c959a0a6ae846ddadd7a79ea64
patch link:    https://lore.kernel.org/r/20240819-lpm-v6-10-constraints-pmdomain-v2-1-461325a6008f%40baylibre.com
patch subject: [PATCH v2 1/3] pmdomain: ti_sci: add per-device latency constraint management
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240820/202408201832.dBeZprIs-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240820/202408201832.dBeZprIs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408201832.dBeZprIs-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/pmdomain/ti/ti_sci_pm_domains.c:68:20: error: no member named 'pm_ops' in 'struct ti_sci_ops'
           ret = ti_sci->ops.pm_ops.set_latency_constraint(ti_sci, val, TISCI_MSG_CONSTRAINT_SET);
                 ~~~~~~~~~~~ ^
>> drivers/pmdomain/ti/ti_sci_pm_domains.c:68:63: error: use of undeclared identifier 'TISCI_MSG_CONSTRAINT_SET'
           ret = ti_sci->ops.pm_ops.set_latency_constraint(ti_sci, val, TISCI_MSG_CONSTRAINT_SET);
                                                                        ^
   drivers/pmdomain/ti/ti_sci_pm_domains.c:236:34: error: no member named 'pm_ops' in 'struct ti_sci_ops'
                                   if (pd_provider->ti_sci->ops.pm_ops.set_device_constraint &&
                                       ~~~~~~~~~~~~~~~~~~~~~~~~ ^
   drivers/pmdomain/ti/ti_sci_pm_domains.c:237:34: error: no member named 'pm_ops' in 'struct ti_sci_ops'
                                       pd_provider->ti_sci->ops.pm_ops.set_latency_constraint)
                                       ~~~~~~~~~~~~~~~~~~~~~~~~ ^
   4 errors generated.


vim +68 drivers/pmdomain/ti/ti_sci_pm_domains.c

    60	
    61	static int ti_sci_pd_set_lat_constraint(struct device *dev, s32 val)
    62	{
    63		struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain);
    64		struct ti_sci_pm_domain *pd = genpd_to_ti_sci_pd(genpd);
    65		const struct ti_sci_handle *ti_sci = pd->parent->ti_sci;
    66		int ret;
    67	
  > 68		ret = ti_sci->ops.pm_ops.set_latency_constraint(ti_sci, val, TISCI_MSG_CONSTRAINT_SET);
    69		if (ret)
    70			dev_err(dev, "ti_sci_pd: set latency constraint failed: ret=%d\n",
    71				ret);
    72		else
    73			dev_dbg(dev, "ti_sci_pd: ID:%d set latency constraint %d\n",
    74				pd->idx, val);
    75	
    76		return ret;
    77	}
    78	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki