Re: [PATCH 1/5] iommu: Enhance domain allocation code to take additional flags

[kernel test robot <lkp@intel.com>]

Hi Vasant,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.11-rc4 next-20240821]
[cannot apply to joro-iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vasant-Hegde/iommu-Enhance-domain-allocation-code-to-take-additional-flags/20240821-214124
base:   linus/master
patch link:    https://lore.kernel.org/r/20240821133554.7405-2-vasant.hegde%40amd.com
patch subject: [PATCH 1/5] iommu: Enhance domain allocation code to take additional flags
config: arm-footbridge_defconfig (https://download.01.org/0day-ci/archive/20240822/202408220940.YjSy3Avg-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 26670e7fa4f032a019d23d56c6a02926e854e8af)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408220940.YjSy3Avg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408220940.YjSy3Avg-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/pci/pci-driver.c:7:
   In file included from include/linux/pci.h:1646:
   In file included from include/linux/dmapool.h:14:
   In file included from include/linux/scatterlist.h:8:
   In file included from include/linux/mm.h:2228:
   include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     517 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   In file included from drivers/pci/pci-driver.c:23:
   include/linux/iommu.h:1103:1: error: declaration of anonymous struct must be a definition
    1103 | struct inline iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
         | ^
   include/linux/iommu.h:1103:1: warning: declaration does not declare anything [-Wmissing-declarations]
>> drivers/pci/pci-driver.c:1657:9: error: call to undeclared function 'iommu_device_use_default_domain'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1657 |                 ret = iommu_device_use_default_domain(dev);
         |                       ^
>> drivers/pci/pci-driver.c:1670:3: error: call to undeclared function 'iommu_device_unuse_default_domain'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1670 |                 iommu_device_unuse_default_domain(dev);
         |                 ^
   2 warnings and 3 errors generated.


vim +/iommu_device_use_default_domain +1657 drivers/pci/pci-driver.c

02e0bea6c83c657 Phil Sutter       2017-01-18  1629  
07397df29e57cde Nipun Gupta       2018-04-28  1630  /**
07397df29e57cde Nipun Gupta       2018-04-28  1631   * pci_dma_configure - Setup DMA configuration
07397df29e57cde Nipun Gupta       2018-04-28  1632   * @dev: ptr to dev structure
07397df29e57cde Nipun Gupta       2018-04-28  1633   *
07397df29e57cde Nipun Gupta       2018-04-28  1634   * Function to update PCI devices's DMA configuration using the same
07397df29e57cde Nipun Gupta       2018-04-28  1635   * info from the OF node or ACPI node of host bridge's parent (if any).
07397df29e57cde Nipun Gupta       2018-04-28  1636   */
07397df29e57cde Nipun Gupta       2018-04-28  1637  static int pci_dma_configure(struct device *dev)
07397df29e57cde Nipun Gupta       2018-04-28  1638  {
512881eacfa72c2 Lu Baolu          2022-04-18  1639  	struct pci_driver *driver = to_pci_driver(dev->driver);
07397df29e57cde Nipun Gupta       2018-04-28  1640  	struct device *bridge;
07397df29e57cde Nipun Gupta       2018-04-28  1641  	int ret = 0;
07397df29e57cde Nipun Gupta       2018-04-28  1642  
07397df29e57cde Nipun Gupta       2018-04-28  1643  	bridge = pci_get_host_bridge_device(to_pci_dev(dev));
07397df29e57cde Nipun Gupta       2018-04-28  1644  
07397df29e57cde Nipun Gupta       2018-04-28  1645  	if (IS_ENABLED(CONFIG_OF) && bridge->parent &&
07397df29e57cde Nipun Gupta       2018-04-28  1646  	    bridge->parent->of_node) {
3d6ce86ee79465e Christoph Hellwig 2018-05-03  1647  		ret = of_dma_configure(dev, bridge->parent->of_node, true);
07397df29e57cde Nipun Gupta       2018-04-28  1648  	} else if (has_acpi_companion(bridge)) {
07397df29e57cde Nipun Gupta       2018-04-28  1649  		struct acpi_device *adev = to_acpi_device_node(bridge->fwnode);
07397df29e57cde Nipun Gupta       2018-04-28  1650  
e5361ca29f2fea3 Robin Murphy      2018-12-06  1651  		ret = acpi_dma_configure(dev, acpi_get_dma_attr(adev));
07397df29e57cde Nipun Gupta       2018-04-28  1652  	}
07397df29e57cde Nipun Gupta       2018-04-28  1653  
07397df29e57cde Nipun Gupta       2018-04-28  1654  	pci_put_host_bridge_device(bridge);
512881eacfa72c2 Lu Baolu          2022-04-18  1655  
512881eacfa72c2 Lu Baolu          2022-04-18  1656  	if (!ret && !driver->driver_managed_dma) {
512881eacfa72c2 Lu Baolu          2022-04-18 @1657  		ret = iommu_device_use_default_domain(dev);
512881eacfa72c2 Lu Baolu          2022-04-18  1658  		if (ret)
512881eacfa72c2 Lu Baolu          2022-04-18  1659  			arch_teardown_dma_ops(dev);
512881eacfa72c2 Lu Baolu          2022-04-18  1660  	}
512881eacfa72c2 Lu Baolu          2022-04-18  1661  
07397df29e57cde Nipun Gupta       2018-04-28  1662  	return ret;
07397df29e57cde Nipun Gupta       2018-04-28  1663  }
07397df29e57cde Nipun Gupta       2018-04-28  1664  
512881eacfa72c2 Lu Baolu          2022-04-18  1665  static void pci_dma_cleanup(struct device *dev)
512881eacfa72c2 Lu Baolu          2022-04-18  1666  {
512881eacfa72c2 Lu Baolu          2022-04-18  1667  	struct pci_driver *driver = to_pci_driver(dev->driver);
512881eacfa72c2 Lu Baolu          2022-04-18  1668  
512881eacfa72c2 Lu Baolu          2022-04-18  1669  	if (!driver->driver_managed_dma)
512881eacfa72c2 Lu Baolu          2022-04-18 @1670  		iommu_device_unuse_default_domain(dev);
512881eacfa72c2 Lu Baolu          2022-04-18  1671  }
512881eacfa72c2 Lu Baolu          2022-04-18  1672  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki