From: kernel test robot <lkp@intel.com>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
mptcp@lists.linux.dev
Subject: [mptcp:export 6/29] net/hsr/hsr_slave.c:74:22: error: no member named 'seqnr_lock' in 'struct hsr_priv'
Date: Fri, 13 Sep 2024 18:24:45 +0800 [thread overview]
Message-ID: <202409131819.Lpi4A47e-lkp@intel.com> (raw)
tree: https://github.com/multipath-tcp/mptcp_net-next.git export
head: c5b5a7a0aee30449ff22ac8cca06d6d6d61dfa55
commit: f9cd7819a1b49a8eaa14f5ca178290bdb4258133 [6/29] TopGit-driven merge of branches:
config: i386-buildonly-randconfig-001-20240913 (https://download.01.org/0day-ci/archive/20240913/202409131819.Lpi4A47e-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240913/202409131819.Lpi4A47e-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409131819.Lpi4A47e-lkp@intel.com/
All errors (new ones prefixed by >>):
>> net/hsr/hsr_slave.c:74:22: error: no member named 'seqnr_lock' in 'struct hsr_priv'
74 | spin_lock_bh(&hsr->seqnr_lock);
| ~~~ ^
net/hsr/hsr_slave.c:76:24: error: no member named 'seqnr_lock' in 'struct hsr_priv'
76 | spin_unlock_bh(&hsr->seqnr_lock);
| ~~~ ^
2 errors generated.
vim +74 net/hsr/hsr_slave.c
451d8123f89791 Murali Karicheri 2020-07-22 23
f266a683a4804d Arvid Brodin 2014-07-04 24 static rx_handler_result_t hsr_handle_frame(struct sk_buff **pskb)
51f3c605318b05 Arvid Brodin 2014-07-04 25 {
f266a683a4804d Arvid Brodin 2014-07-04 26 struct sk_buff *skb = *pskb;
f266a683a4804d Arvid Brodin 2014-07-04 27 struct hsr_port *port;
451d8123f89791 Murali Karicheri 2020-07-22 28 struct hsr_priv *hsr;
f5dda315b63775 Murali Karicheri 2020-05-06 29 __be16 protocol;
51f3c605318b05 Arvid Brodin 2014-07-04 30
451d8123f89791 Murali Karicheri 2020-07-22 31 /* Packets from dev_loopback_xmit() do not have L2 header, bail out */
451d8123f89791 Murali Karicheri 2020-07-22 32 if (unlikely(skb->pkt_type == PACKET_LOOPBACK))
451d8123f89791 Murali Karicheri 2020-07-22 33 return RX_HANDLER_PASS;
451d8123f89791 Murali Karicheri 2020-07-22 34
f266a683a4804d Arvid Brodin 2014-07-04 35 if (!skb_mac_header_was_set(skb)) {
f266a683a4804d Arvid Brodin 2014-07-04 36 WARN_ONCE(1, "%s: skb invalid", __func__);
f266a683a4804d Arvid Brodin 2014-07-04 37 return RX_HANDLER_PASS;
51f3c605318b05 Arvid Brodin 2014-07-04 38 }
51f3c605318b05 Arvid Brodin 2014-07-04 39
f266a683a4804d Arvid Brodin 2014-07-04 40 port = hsr_port_get_rcu(skb->dev);
2b5b8251bc9fe2 Eric Dumazet 2020-02-03 41 if (!port)
2b5b8251bc9fe2 Eric Dumazet 2020-02-03 42 goto finish_pass;
451d8123f89791 Murali Karicheri 2020-07-22 43 hsr = port->hsr;
51f3c605318b05 Arvid Brodin 2014-07-04 44
f266a683a4804d Arvid Brodin 2014-07-04 45 if (hsr_addr_is_self(port->hsr, eth_hdr(skb)->h_source)) {
f266a683a4804d Arvid Brodin 2014-07-04 46 /* Directly kill frames sent by ourselves */
f266a683a4804d Arvid Brodin 2014-07-04 47 kfree_skb(skb);
f266a683a4804d Arvid Brodin 2014-07-04 48 goto finish_consume;
51f3c605318b05 Arvid Brodin 2014-07-04 49 }
51f3c605318b05 Arvid Brodin 2014-07-04 50
dcf0cd1cc58b8e George McCollister 2021-02-09 51 /* For HSR, only tagged frames are expected (unless the device offloads
dcf0cd1cc58b8e George McCollister 2021-02-09 52 * HSR tag removal), but for PRP there could be non tagged frames as
dcf0cd1cc58b8e George McCollister 2021-02-09 53 * well from Single attached nodes (SANs).
451d8123f89791 Murali Karicheri 2020-07-22 54 */
ee1c2797728490 Peter Heise 2016-04-13 55 protocol = eth_hdr(skb)->h_proto;
dcf0cd1cc58b8e George McCollister 2021-02-09 56
dcf0cd1cc58b8e George McCollister 2021-02-09 57 if (!(port->dev->features & NETIF_F_HW_HSR_TAG_RM) &&
5055cccfc2d1cc Lukasz Majewski 2024-04-23 58 port->type != HSR_PT_INTERLINK &&
dcf0cd1cc58b8e George McCollister 2021-02-09 59 hsr->proto_ops->invalid_dan_ingress_frame &&
451d8123f89791 Murali Karicheri 2020-07-22 60 hsr->proto_ops->invalid_dan_ingress_frame(protocol))
f266a683a4804d Arvid Brodin 2014-07-04 61 goto finish_pass;
51f3c605318b05 Arvid Brodin 2014-07-04 62
f266a683a4804d Arvid Brodin 2014-07-04 63 skb_push(skb, ETH_HLEN);
48b491a5cc7433 George McCollister 2021-05-24 64 skb_reset_mac_header(skb);
48b491a5cc7433 George McCollister 2021-05-24 65 if ((!hsr->prot_version && protocol == htons(ETH_P_PRP)) ||
48b491a5cc7433 George McCollister 2021-05-24 66 protocol == htons(ETH_P_HSR))
48b491a5cc7433 George McCollister 2021-05-24 67 skb_set_network_header(skb, ETH_HLEN + HSR_HLEN);
48b491a5cc7433 George McCollister 2021-05-24 68 skb_reset_mac_len(skb);
451d8123f89791 Murali Karicheri 2020-07-22 69
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 70 /* Only the frames received over the interlink port will assign a
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 71 * sequence number and require synchronisation vs other sender.
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 72 */
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 73 if (port->type == HSR_PT_INTERLINK) {
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 @74 spin_lock_bh(&hsr->seqnr_lock);
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 75 hsr_forward_skb(skb, port);
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 76 spin_unlock_bh(&hsr->seqnr_lock);
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 77 } else {
f266a683a4804d Arvid Brodin 2014-07-04 78 hsr_forward_skb(skb, port);
430d67bdcb04ee Sebastian Andrzej Siewior 2024-09-06 79 }
81ba6afd6e6443 Arvid Brodin 2014-07-04 80
f266a683a4804d Arvid Brodin 2014-07-04 81 finish_consume:
f266a683a4804d Arvid Brodin 2014-07-04 82 return RX_HANDLER_CONSUMED;
81ba6afd6e6443 Arvid Brodin 2014-07-04 83
f266a683a4804d Arvid Brodin 2014-07-04 84 finish_pass:
f266a683a4804d Arvid Brodin 2014-07-04 85 return RX_HANDLER_PASS;
81ba6afd6e6443 Arvid Brodin 2014-07-04 86 }
81ba6afd6e6443 Arvid Brodin 2014-07-04 87
:::::: The code at line 74 was first introduced by commit
:::::: 430d67bdcb04ee8502c2b10dcbaced4253649189 net: hsr: Use the seqnr lock for frames received via interlink port.
:::::: TO: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
:::::: CC: Jakub Kicinski <kuba@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-13 10:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409131819.Lpi4A47e-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox