From: kernel test robot <lkp@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [axboe-block:rw_iter 440/447] drivers/platform/x86/intel/intel_plr_tpmi.c:255:1: error: use of undeclared identifier 'plr_status_write_iter'; did you mean 'plr_status_write'?
Date: Wed, 18 Sep 2024 00:03:52 +0800 [thread overview]
Message-ID: <202409180017.Gzv254ce-lkp@intel.com> (raw)
Hi Jens,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git rw_iter
head: 097956626f11860fdba8b8919604f57b4a69957d
commit: f3422615616703b0056097588146982e90e412a1 [440/447] seq_file: switch to using ->read_iter()
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240918/202409180017.Gzv254ce-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240918/202409180017.Gzv254ce-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409180017.Gzv254ce-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/platform/x86/intel/intel_plr_tpmi.c:255:1: error: use of undeclared identifier 'plr_status_write_iter'; did you mean 'plr_status_write'?
255 | DEFINE_SHOW_STORE_ATTRIBUTE(plr_status);
| ^
include/linux/seq_file.h:230:16: note: expanded from macro 'DEFINE_SHOW_STORE_ATTRIBUTE'
230 | .write_iter = __name ## _write_iter, \
| ^
<scratch space>:135:1: note: expanded from here
135 | plr_status_write_iter
| ^
drivers/platform/x86/intel/intel_plr_tpmi.c:224:16: note: 'plr_status_write' declared here
224 | static ssize_t plr_status_write(struct kiocb *iocb, struct iov_iter *from)
| ^
1 error generated.
vim +255 drivers/platform/x86/intel/intel_plr_tpmi.c
811f67c51636d4 Tero Kristo 2024-05-27 223
d81c9b5f82e85b Jens Axboe 2024-04-04 224 static ssize_t plr_status_write(struct kiocb *iocb, struct iov_iter *from)
811f67c51636d4 Tero Kristo 2024-05-27 225 {
d81c9b5f82e85b Jens Axboe 2024-04-04 226 struct seq_file *s = iocb->ki_filp->private_data;
811f67c51636d4 Tero Kristo 2024-05-27 227 struct tpmi_plr_die *plr_die = s->private;
d81c9b5f82e85b Jens Axboe 2024-04-04 228 size_t count = iov_iter_count(from);
811f67c51636d4 Tero Kristo 2024-05-27 229 bool val;
811f67c51636d4 Tero Kristo 2024-05-27 230 int ret;
811f67c51636d4 Tero Kristo 2024-05-27 231
d81c9b5f82e85b Jens Axboe 2024-04-04 232 ret = kstrtobool_from_iter(from, count, &val);
811f67c51636d4 Tero Kristo 2024-05-27 233 if (ret)
811f67c51636d4 Tero Kristo 2024-05-27 234 return ret;
811f67c51636d4 Tero Kristo 2024-05-27 235
811f67c51636d4 Tero Kristo 2024-05-27 236 if (val != 0)
811f67c51636d4 Tero Kristo 2024-05-27 237 return -EINVAL;
811f67c51636d4 Tero Kristo 2024-05-27 238
811f67c51636d4 Tero Kristo 2024-05-27 239 plr_write(0, plr_die, PLR_DIE_LEVEL);
811f67c51636d4 Tero Kristo 2024-05-27 240
9e9397a41b7b1d Tero Kristo 2024-05-27 241 guard(mutex)(&plr_die->lock);
9e9397a41b7b1d Tero Kristo 2024-05-27 242
9e9397a41b7b1d Tero Kristo 2024-05-27 243 for (int cpu = 0; cpu < nr_cpu_ids; cpu++) {
9e9397a41b7b1d Tero Kristo 2024-05-27 244 if (plr_die->die_id != tpmi_get_power_domain_id(cpu))
9e9397a41b7b1d Tero Kristo 2024-05-27 245 continue;
9e9397a41b7b1d Tero Kristo 2024-05-27 246
9e9397a41b7b1d Tero Kristo 2024-05-27 247 if (plr_die->package_id != topology_physical_package_id(cpu))
9e9397a41b7b1d Tero Kristo 2024-05-27 248 continue;
9e9397a41b7b1d Tero Kristo 2024-05-27 249
9e9397a41b7b1d Tero Kristo 2024-05-27 250 plr_clear_cpu_status(plr_die, cpu);
9e9397a41b7b1d Tero Kristo 2024-05-27 251 }
9e9397a41b7b1d Tero Kristo 2024-05-27 252
811f67c51636d4 Tero Kristo 2024-05-27 253 return count;
811f67c51636d4 Tero Kristo 2024-05-27 254 }
811f67c51636d4 Tero Kristo 2024-05-27 @255 DEFINE_SHOW_STORE_ATTRIBUTE(plr_status);
811f67c51636d4 Tero Kristo 2024-05-27 256
:::::: The code at line 255 was first introduced by commit
:::::: 811f67c51636d43791995bf483c5c1904900b531 platform/x86/intel/tpmi: Add new auxiliary driver for performance limits
:::::: TO: Tero Kristo <tero.kristo@linux.intel.com>
:::::: CC: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-17 16:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409180017.Gzv254ce-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox