llvm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* Re: [RFC] cxl: Update Soft Reserved resources upon region creation
       [not found] <20241004181754.8960-1-nathan.fontenot@amd.com>
@ 2024-10-07 14:53 ` kernel test robot
  2024-10-07 19:30 ` kernel test robot
  1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-10-07 14:53 UTC (permalink / raw)
  To: Nathan Fontenot; +Cc: llvm, oe-kbuild-all

Hi Nathan,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/x86/core]
[also build test WARNING on linus/master v6.12-rc2 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Fontenot/cxl-Update-Soft-Reserved-resources-upon-region-creation/20241005-021920
base:   tip/x86/core
patch link:    https://lore.kernel.org/r/20241004181754.8960-1-nathan.fontenot%40amd.com
patch subject: [RFC] cxl: Update Soft Reserved resources upon region creation
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20241007/202410072203.uX5lXYkD-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241007/202410072203.uX5lXYkD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410072203.uX5lXYkD-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/x86/kernel/e820.c:1311:42: warning: declaration of 'union acpi_subtable_headers' will not be visible outside of this function [-Wvisibility]
    1311 | static int __init e820_parse_cfmws(union acpi_subtable_headers *hdr, void *arg,
         |                                          ^
   arch/x86/kernel/e820.c:1361:9: error: call to undeclared function 'acpi_table_parse_cedt'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1361 |                         rc = acpi_table_parse_cedt(ACPI_CEDT_TYPE_CFMWS,
         |                              ^
   arch/x86/kernel/e820.c:1361:9: note: did you mean 'acpi_table_parse'?
   include/linux/acpi.h:913:19: note: 'acpi_table_parse' declared here
     913 | static inline int acpi_table_parse(char *id,
         |                   ^
   1 warning and 1 error generated.


vim +1311 arch/x86/kernel/e820.c

  1310	
> 1311	static int __init e820_parse_cfmws(union acpi_subtable_headers *hdr, void *arg,
  1312					   const unsigned long unused)
  1313	{
  1314		struct acpi_cedt_cfmws *cfmws;
  1315		struct resource *res = arg;
  1316		struct resource cfmws_res;
  1317	
  1318		/* Validation check, remove when finished debugging */
  1319		if (!res->parent && res->end)
  1320			pr_err("CXL DEBUG Should insert %pr\n", res);
  1321	
  1322		if (res->parent || !res->end)
  1323			return 0;
  1324	
  1325		cfmws = (struct acpi_cedt_cfmws *)hdr;
  1326		cfmws_res = DEFINE_RES_MEM(cfmws->base_hpa,
  1327					   cfmws->base_hpa + cfmws->window_size);
  1328		pr_err("CXL DEBUG Found CFMWS: %pr\n", &cfmws_res);
  1329	
  1330		if (resource_overlaps(&cfmws_res, res)) {
  1331			pr_err("CXL DEBUG Found SOFT RESERVE intersection %llx - %llx : %llx - %llx\n",
  1332			       res->start, res->end, cfmws_res.start, cfmws_res.end);
  1333			e820__add_soft_reserve(res->start, resource_size(res),
  1334					       res->flags);
  1335			return 1;
  1336		}
  1337	
  1338		return 0;
  1339	}
  1340	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFC] cxl: Update Soft Reserved resources upon region creation
       [not found] <20241004181754.8960-1-nathan.fontenot@amd.com>
  2024-10-07 14:53 ` [RFC] cxl: Update Soft Reserved resources upon region creation kernel test robot
@ 2024-10-07 19:30 ` kernel test robot
  1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-10-07 19:30 UTC (permalink / raw)
  To: Nathan Fontenot; +Cc: llvm, oe-kbuild-all

Hi Nathan,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/x86/core]
[also build test WARNING on linus/master v6.12-rc2 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Fontenot/cxl-Update-Soft-Reserved-resources-upon-region-creation/20241005-021920
base:   tip/x86/core
patch link:    https://lore.kernel.org/r/20241004181754.8960-1-nathan.fontenot%40amd.com
patch subject: [RFC] cxl: Update Soft Reserved resources upon region creation
config: i386-defconfig (https://download.01.org/0day-ci/archive/20241008/202410080207.DfKmNFfh-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241008/202410080207.DfKmNFfh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410080207.DfKmNFfh-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/x86/kernel/e820.c:1243:10: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1242 |                 pr_err("CXL DEBUG Couldn't add Soft Reserved %llx (%llx)\n",
         |                                                              ~~~~
         |                                                              %x
    1243 |                        start, len);
         |                        ^~~~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
     437 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   arch/x86/kernel/e820.c:1243:17: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1242 |                 pr_err("CXL DEBUG Couldn't add Soft Reserved %llx (%llx)\n",
         |                                                                    ~~~~
         |                                                                    %x
    1243 |                        start, len);
         |                               ^~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
     437 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   arch/x86/kernel/e820.c:1275:15: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1274 |                 pr_err("CXL DEBUG Adjusting resource %pr (%llx - %llx)\n",
         |                                                           ~~~~
         |                                                           %x
    1275 |                        res, new_start, new_end);
         |                             ^~~~~~~~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
     437 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   arch/x86/kernel/e820.c:1275:26: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1274 |                 pr_err("CXL DEBUG Adjusting resource %pr (%llx - %llx)\n",
         |                                                                  ~~~~
         |                                                                  %x
    1275 |                        res, new_start, new_end);
         |                                        ^~~~~~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
     437 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   arch/x86/kernel/e820.c:1286:10: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1285 |                 pr_err("CXL DEBUG Adjusting resource %pr (%llx - %llx)\n", res,
         |                                                           ~~~~
         |                                                           %x
    1286 |                        new_start, cxl_res->start);
         |                        ^~~~~~~~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
     437 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   arch/x86/kernel/e820.c:1286:21: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1285 |                 pr_err("CXL DEBUG Adjusting resource %pr (%llx - %llx)\n", res,
         |                                                                  ~~~~
         |                                                                  %x
    1286 |                        new_start, cxl_res->start);
         |                                   ^~~~~~~~~~~~~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:437:19: note: expanded from macro 'printk_index_wrap'
     437 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   arch/x86/kernel/e820.c:1332:10: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
    1331 |                 pr_err("CXL DEBUG Found SOFT RESERVE intersection %llx - %llx : %llx - %llx\n",
         |                                                                   ~~~~
         |                                                                   %x
    1332 |                        res->start, res->end, cfmws_res.start, cfmws_res.end);
         |                        ^~~~~~~~~~
   include/linux/printk.h:508:33: note: expanded from macro 'pr_err'
     508 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                                ~~~     ^~~~~~~~~~~
   include/linux/printk.h:465:60: note: expanded from macro 'printk'
     465 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)


vim +1243 arch/x86/kernel/e820.c

  1234	
  1235	static void e820__add_soft_reserve(resource_size_t start, resource_size_t len,
  1236					   unsigned long flags)
  1237	{
  1238		struct resource *res;
  1239	
  1240		res = kzalloc(sizeof(*res), GFP_KERNEL);
  1241		if (!res) {
  1242			pr_err("CXL DEBUG Couldn't add Soft Reserved %llx (%llx)\n",
> 1243			       start, len);
  1244			return;
  1245		}
  1246	
  1247		*res = DEFINE_RES_NAMED(start, len, "Soft Reserved", flags);
  1248		res->desc = IORES_DESC_SOFT_RESERVED;
  1249		pr_err("CXL DEBUG Inserting new Soft Reserved %pr\n", res);
  1250		insert_resource(&e820_sr_res, res);
  1251	}
  1252	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-07 19:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20241004181754.8960-1-nathan.fontenot@amd.com>
2024-10-07 14:53 ` [RFC] cxl: Update Soft Reserved resources upon region creation kernel test robot
2024-10-07 19:30 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).