From: kernel test robot <lkp@intel.com>
To: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v1 13/13] mm: vmscan, swap, zswap: Compress batching of folios in shrink_folio_list().
Date: Sat, 19 Oct 2024 12:45:52 +0800 [thread overview]
Message-ID: <202410191245.1RsX8FF0-lkp@intel.com> (raw)
In-Reply-To: <20241018064101.336232-14-kanchana.p.sridhar@intel.com>
Hi Kanchana,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on 817952b8be34aad40e07f6832fb9d1fc08961550]
url: https://github.com/intel-lab-lkp/linux/commits/Kanchana-P-Sridhar/crypto-acomp-Add-a-poll-operation-to-acomp_alg-and-acomp_req/20241018-144331
base: 817952b8be34aad40e07f6832fb9d1fc08961550
patch link: https://lore.kernel.org/r/20241018064101.336232-14-kanchana.p.sridhar%40intel.com
patch subject: [RFC PATCH v1 13/13] mm: vmscan, swap, zswap: Compress batching of folios in shrink_folio_list().
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241019/202410191245.1RsX8FF0-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410191245.1RsX8FF0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410191245.1RsX8FF0-lkp@intel.com/
All errors (new ones prefixed by >>):
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:484:10: note: expanded from macro '__native_word'
484 | (sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
| ^
include/linux/compiler_types.h:517:22: note: expanded from macro 'compiletime_assert'
517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~
include/linux/compiler_types.h:505:23: note: expanded from macro '_compiletime_assert'
505 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~
include/linux/compiler_types.h:497:9: note: expanded from macro '__compiletime_assert'
497 | if (!(condition)) \
| ^~~~~~~~~
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:484:39: note: expanded from macro '__native_word'
484 | (sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
| ^
include/linux/compiler_types.h:517:22: note: expanded from macro 'compiletime_assert'
517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~
include/linux/compiler_types.h:505:23: note: expanded from macro '_compiletime_assert'
505 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~
include/linux/compiler_types.h:497:9: note: expanded from macro '__compiletime_assert'
497 | if (!(condition)) \
| ^~~~~~~~~
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:485:10: note: expanded from macro '__native_word'
485 | sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
| ^
include/linux/compiler_types.h:517:22: note: expanded from macro 'compiletime_assert'
517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~
include/linux/compiler_types.h:505:23: note: expanded from macro '_compiletime_assert'
505 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~
include/linux/compiler_types.h:497:9: note: expanded from macro '__compiletime_assert'
497 | if (!(condition)) \
| ^~~~~~~~~
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:485:38: note: expanded from macro '__native_word'
485 | sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
| ^
include/linux/compiler_types.h:517:22: note: expanded from macro 'compiletime_assert'
517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~
include/linux/compiler_types.h:505:23: note: expanded from macro '_compiletime_assert'
505 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~
include/linux/compiler_types.h:497:9: note: expanded from macro '__compiletime_assert'
497 | if (!(condition)) \
| ^~~~~~~~~
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
49 | compiletime_assert_rwonce_type(x); \
| ^
include/asm-generic/rwonce.h:36:48: note: expanded from macro 'compiletime_assert_rwonce_type'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^
include/linux/compiler_types.h:517:22: note: expanded from macro 'compiletime_assert'
517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~
include/linux/compiler_types.h:505:23: note: expanded from macro '_compiletime_assert'
505 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~
include/linux/compiler_types.h:497:9: note: expanded from macro '__compiletime_assert'
497 | if (!(condition)) \
| ^~~~~~~~~
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:50:14: note: expanded from macro 'READ_ONCE'
50 | __READ_ONCE(x); \
| ^
include/asm-generic/rwonce.h:44:65: note: expanded from macro '__READ_ONCE'
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
include/linux/compiler_types.h:473:13: note: expanded from macro '__unqual_scalar_typeof'
473 | _Generic((x), \
| ^
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:50:14: note: expanded from macro 'READ_ONCE'
50 | __READ_ONCE(x); \
| ^
include/asm-generic/rwonce.h:44:65: note: expanded from macro '__READ_ONCE'
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
include/linux/compiler_types.h:480:15: note: expanded from macro '__unqual_scalar_typeof'
480 | default: (x)))
| ^
>> mm/page_io.c:412:35: error: no member named 'zswap_writeback' in 'struct mem_cgroup'
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ~~~~~~~~~~~~~~~~~~ ^
include/asm-generic/rwonce.h:50:14: note: expanded from macro 'READ_ONCE'
50 | __READ_ONCE(x); \
| ^
include/asm-generic/rwonce.h:44:72: note: expanded from macro '__READ_ONCE'
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^
>> mm/page_io.c:412:4: error: invalid argument type 'void' to unary expression
412 | !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
9 errors generated.
vim +412 mm/page_io.c
343
344 /*
345 * zswap batching of folios with IAA:
346 *
347 * Reclaim batching note for pmd-mappable folios:
348 * Any pmd-mappable folio in the reclaim path will be processed in a batch
349 * comprising only that folio. There will be no mixed batches containing
350 * pmd-mappable folios for batch compression with IAA.
351 * There are no restrictions with other large folios: a reclaim batch
352 * can comprise of any-order mix of non-pmd-mappable folios.
353 */
354 /*
355 * We may have stale swap cache pages in memory: notice
356 * them here and get rid of the unnecessary final write.
357 */
358 int swap_writepage(struct page *page, struct writeback_control *wbc)
359 {
360 struct folio *folio = page_folio(page);
361 int ret;
362
363 if (folio_free_swap(folio)) {
364 folio_unlock(folio);
365 return 0;
366 }
367 /*
368 * Arch code may have to preserve more data than just the page
369 * contents, e.g. memory tags.
370 */
371 ret = arch_prepare_to_swap(folio);
372 if (ret) {
373 folio_mark_dirty(folio);
374 folio_unlock(folio);
375 return ret;
376 }
377
378 /*
379 * Use a bitmap (zeromap) to avoid doing IO for zero-filled pages.
380 * The bits in zeromap are protected by the locked swapcache folio
381 * and atomic updates are used to protect against read-modify-write
382 * corruption due to other zero swap entries seeing concurrent updates.
383 */
384 if (is_folio_zero_filled(folio)) {
385 swap_zeromap_folio_set(folio);
386 folio_unlock(folio);
387 return 0;
388 } else {
389 /*
390 * Clear bits this folio occupies in the zeromap to prevent
391 * zero data being read in from any previous zero writes that
392 * occupied the same swap entries.
393 */
394 swap_zeromap_folio_clear(folio);
395 }
396
397 /*
398 * Batching of compressions with IAA: If reclaim path pageout has
399 * invoked swap_writepage with a wbc->swap_in_memory_cache_plug,
400 * add the page to the plug, or invoke zswap_store_batch() if
401 * "vm.compress-batchsize" elements have been stored in
402 * the plug.
403 *
404 * If swap_writepage has been called from other kernel code without
405 * a wbc->swap_in_memory_cache_plug, call zswap_store() with the folio
406 * (i.e. without adding the folio to a plug for batch processing).
407 */
408 if (wbc && wbc->swap_in_memory_cache_plug) {
409 if (!mem_cgroup_zswap_writeback_enabled(folio_memcg(folio)) &&
410 !zswap_is_enabled() &&
411 folio_memcg(folio) &&
> 412 !READ_ONCE(folio_memcg(folio)->zswap_writeback)) {
413 folio_mark_dirty(folio);
414 return AOP_WRITEPAGE_ACTIVATE;
415 }
416
417 if (swap_writepage_in_memory_cache(folio, wbc))
418 return AOP_PAGE_BATCH_SUCCESS;
419 else
420 return AOP_PAGE_BATCHED;
421 } else if (zswap_store(folio)) {
422 count_mthp_stat(folio_order(folio), MTHP_STAT_ZSWPOUT);
423 folio_unlock(folio);
424 return 0;
425 }
426 if (!mem_cgroup_zswap_writeback_enabled(folio_memcg(folio))) {
427 folio_mark_dirty(folio);
428 return AOP_WRITEPAGE_ACTIVATE;
429 }
430
431 __swap_writepage(folio, wbc);
432 return 0;
433 }
434
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2024-10-19 4:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241018064101.336232-14-kanchana.p.sridhar@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410191245.1RsX8FF0-lkp@intel.com \
--to=lkp@intel.com \
--cc=kanchana.p.sridhar@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox