From: kernel test robot <lkp@intel.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH net-next 3/3] net: phylink: simplify how SFP PHYs are attached
Date: Wed, 23 Oct 2024 21:11:03 +0800 [thread overview]
Message-ID: <202410232116.IgRFPrAS-lkp@intel.com> (raw)
In-Reply-To: <E1t3DSr-000Vxg-Qx@rmk-PC.armlinux.org.uk>
Hi Russell,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-phylink-add-common-validation-for-sfp_select_interface/20241022-234251
base: net-next/main
patch link: https://lore.kernel.org/r/E1t3DSr-000Vxg-Qx%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next 3/3] net: phylink: simplify how SFP PHYs are attached
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241023/202410232116.IgRFPrAS-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241023/202410232116.IgRFPrAS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410232116.IgRFPrAS-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/phy/phylink.c:3429:6: warning: unused variable 'ret' [-Wunused-variable]
3429 | int ret;
| ^~~
1 warning generated.
vim +/ret +3429 drivers/net/phy/phylink.c
7adb5b2126bc013 Russell King 2019-12-11 3424
ce0aa27ff3f68ed Russell King 2017-07-25 3425 static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy)
ce0aa27ff3f68ed Russell King 2017-07-25 3426 {
7e4183752735deb Baruch Siach 2018-10-03 3427 struct phylink *pl = upstream;
7adb5b2126bc013 Russell King 2019-12-11 3428 u8 mode;
938d44c2b502ba4 Russell King 2019-12-11 @3429 int ret;
7e4183752735deb Baruch Siach 2018-10-03 3430
52c956003a9d5bc Russell King 2019-12-11 3431 /*
52c956003a9d5bc Russell King 2019-12-11 3432 * This is the new way of dealing with flow control for PHYs,
52c956003a9d5bc Russell King 2019-12-11 3433 * as described by Timur Tabi in commit 529ed1275263 ("net: phy:
52c956003a9d5bc Russell King 2019-12-11 3434 * phy drivers should not set SUPPORTED_[Asym_]Pause") except
52c956003a9d5bc Russell King 2019-12-11 3435 * using our validate call to the MAC, we rely upon the MAC
52c956003a9d5bc Russell King 2019-12-11 3436 * clearing the bits from both supported and advertising fields.
52c956003a9d5bc Russell King 2019-12-11 3437 */
52c956003a9d5bc Russell King 2019-12-11 3438 phy_support_asym_pause(phy);
52c956003a9d5bc Russell King 2019-12-11 3439
7adb5b2126bc013 Russell King 2019-12-11 3440 if (phylink_phy_no_inband(phy))
7adb5b2126bc013 Russell King 2019-12-11 3441 mode = MLO_AN_PHY;
7adb5b2126bc013 Russell King 2019-12-11 3442 else
7adb5b2126bc013 Russell King 2019-12-11 3443 mode = MLO_AN_INBAND;
7adb5b2126bc013 Russell King 2019-12-11 3444
eca68a3c7d05b38 Marek Behún 2022-09-30 3445 /* Set the PHY's host supported interfaces */
eca68a3c7d05b38 Marek Behún 2022-09-30 3446 phy_interface_and(phy->host_interfaces, phylink_sfp_interfaces,
eca68a3c7d05b38 Marek Behún 2022-09-30 3447 pl->config->supported_interfaces);
eca68a3c7d05b38 Marek Behún 2022-09-30 3448
52c956003a9d5bc Russell King 2019-12-11 3449 /* Do the initial configuration */
e48bc58d0fa1e08 Russell King (Oracle 2024-10-22 3450) return phylink_sfp_config_phy(pl, mode, phy);
ce0aa27ff3f68ed Russell King 2017-07-25 3451 }
ce0aa27ff3f68ed Russell King 2017-07-25 3452
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2024-10-23 13:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <E1t3DSr-000Vxg-Qx@rmk-PC.armlinux.org.uk>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410232116.IgRFPrAS-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox