From: kernel test robot <lkp@intel.com>
To: SeongJae Park <sj@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: [sj:damon/next 52/79] mm/damon/sysfs-schemes.c:2129: warning: Function parameter or struct member 'sz_filter_passed' not described in 'damos_sysfs_populate_region_dir'
Date: Thu, 19 Dec 2024 12:51:39 +0800 [thread overview]
Message-ID: <202412191225.f6bEMRT2-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head: acaaeb549248b361cb0586af34b317d05a61512b
commit: d92ceeda1fde0fd17da7d3dfe5d51e6684e20c6c [52/79] mm/damon/sysfs-schemes: expose per-region filter-passed bytes
config: arm-randconfig-001-20241219 (https://download.01.org/0day-ci/archive/20241219/202412191225.f6bEMRT2-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241219/202412191225.f6bEMRT2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412191225.f6bEMRT2-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> mm/damon/sysfs-schemes.c:2129: warning: Function parameter or struct member 'sz_filter_passed' not described in 'damos_sysfs_populate_region_dir'
vim +2129 mm/damon/sysfs-schemes.c
f1d13cacabe140 SeongJae Park 2022-11-01 2113
aa2ebc50289e65 SeongJae Park 2024-12-01 2114 /**
aa2ebc50289e65 SeongJae Park 2024-12-01 2115 * damos_sysfs_populate_region_dir() - Populate a schemes tried region dir.
aa2ebc50289e65 SeongJae Park 2024-12-01 2116 * @sysfs_schemes: Schemes directory to populate regions directory.
aa2ebc50289e65 SeongJae Park 2024-12-01 2117 * @ctx: Corresponding DAMON context.
aa2ebc50289e65 SeongJae Park 2024-12-01 2118 * @t: DAMON target of @r.
aa2ebc50289e65 SeongJae Park 2024-12-01 2119 * @r: DAMON region to populate the directory for.
aa2ebc50289e65 SeongJae Park 2024-12-01 2120 * @s: Corresponding scheme.
aa2ebc50289e65 SeongJae Park 2024-12-01 2121 * @total_bytes_only: Whether the request is for bytes update only.
aa2ebc50289e65 SeongJae Park 2024-12-01 2122 *
aa2ebc50289e65 SeongJae Park 2024-12-01 2123 * Called from DAMOS walk callback while holding damon_sysfs_lock.
aa2ebc50289e65 SeongJae Park 2024-12-01 2124 */
aa2ebc50289e65 SeongJae Park 2024-12-01 2125 void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,
aa2ebc50289e65 SeongJae Park 2024-12-01 2126 struct damon_ctx *ctx, struct damon_target *t,
d92ceeda1fde0f SeongJae Park 2024-12-16 2127 struct damon_region *r, struct damos *s, bool total_bytes_only,
d92ceeda1fde0f SeongJae Park 2024-12-16 2128 unsigned long sz_filter_passed)
aa2ebc50289e65 SeongJae Park 2024-12-01 @2129 {
aa2ebc50289e65 SeongJae Park 2024-12-01 2130 struct damos *scheme;
aa2ebc50289e65 SeongJae Park 2024-12-01 2131 struct damon_sysfs_scheme_regions *sysfs_regions;
aa2ebc50289e65 SeongJae Park 2024-12-01 2132 struct damon_sysfs_scheme_region *region;
aa2ebc50289e65 SeongJae Park 2024-12-01 2133 int schemes_idx = 0;
aa2ebc50289e65 SeongJae Park 2024-12-01 2134
aa2ebc50289e65 SeongJae Park 2024-12-01 2135 damon_for_each_scheme(scheme, ctx) {
aa2ebc50289e65 SeongJae Park 2024-12-01 2136 if (scheme == s)
aa2ebc50289e65 SeongJae Park 2024-12-01 2137 break;
aa2ebc50289e65 SeongJae Park 2024-12-01 2138 schemes_idx++;
aa2ebc50289e65 SeongJae Park 2024-12-01 2139 }
aa2ebc50289e65 SeongJae Park 2024-12-01 2140
aa2ebc50289e65 SeongJae Park 2024-12-01 2141 /* user could have removed the scheme sysfs dir */
aa2ebc50289e65 SeongJae Park 2024-12-01 2142 if (schemes_idx >= sysfs_schemes->nr)
aa2ebc50289e65 SeongJae Park 2024-12-01 2143 return;
aa2ebc50289e65 SeongJae Park 2024-12-01 2144
aa2ebc50289e65 SeongJae Park 2024-12-01 2145 sysfs_regions = sysfs_schemes->schemes_arr[schemes_idx]->tried_regions;
aa2ebc50289e65 SeongJae Park 2024-12-01 2146 sysfs_regions->total_bytes += r->ar.end - r->ar.start;
aa2ebc50289e65 SeongJae Park 2024-12-01 2147 if (total_bytes_only)
aa2ebc50289e65 SeongJae Park 2024-12-01 2148 return;
aa2ebc50289e65 SeongJae Park 2024-12-01 2149
aa2ebc50289e65 SeongJae Park 2024-12-01 2150 region = damon_sysfs_scheme_region_alloc(r);
aa2ebc50289e65 SeongJae Park 2024-12-01 2151 if (!region)
aa2ebc50289e65 SeongJae Park 2024-12-01 2152 return;
d92ceeda1fde0f SeongJae Park 2024-12-16 2153 region->sz_filter_passed = sz_filter_passed;
aa2ebc50289e65 SeongJae Park 2024-12-01 2154 list_add_tail(®ion->list, &sysfs_regions->regions_list);
aa2ebc50289e65 SeongJae Park 2024-12-01 2155 sysfs_regions->nr_regions++;
aa2ebc50289e65 SeongJae Park 2024-12-01 2156 if (kobject_init_and_add(®ion->kobj,
aa2ebc50289e65 SeongJae Park 2024-12-01 2157 &damon_sysfs_scheme_region_ktype,
aa2ebc50289e65 SeongJae Park 2024-12-01 2158 &sysfs_regions->kobj, "%d",
aa2ebc50289e65 SeongJae Park 2024-12-01 2159 sysfs_regions->nr_regions++)) {
aa2ebc50289e65 SeongJae Park 2024-12-01 2160 kobject_put(®ion->kobj);
aa2ebc50289e65 SeongJae Park 2024-12-01 2161 }
aa2ebc50289e65 SeongJae Park 2024-12-01 2162 }
aa2ebc50289e65 SeongJae Park 2024-12-01 2163
:::::: The code at line 2129 was first introduced by commit
:::::: aa2ebc50289e6594cd72ec76b13f108d2cc33bed mm/damon/sysfs: use damos_walk() for update_schemes_tried_{bytes,regions}
:::::: TO: SeongJae Park <sj@kernel.org>
:::::: CC: SeongJae Park <sj@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-12-19 4:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 4:51 kernel test robot [this message]
2024-12-19 18:59 ` [sj:damon/next 52/79] mm/damon/sysfs-schemes.c:2129: warning: Function parameter or struct member 'sz_filter_passed' not described in 'damos_sysfs_populate_region_dir' SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412191225.f6bEMRT2-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox