From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Brian Norris <briannorris@chromium.org>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
devel@driverdev.osuosl.org, Maxime Ripard <mripard@kernel.org>,
David Gow <davidgow@google.com>
Subject: Re: [driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function
Date: Sat, 4 Jan 2025 09:16:00 +0100 [thread overview]
Message-ID: <2025010433-fretful-gallery-e9cd@gregkh> (raw)
In-Reply-To: <Z3gjL50fsmh-fQPH@google.com>
On Fri, Jan 03, 2025 at 09:49:35AM -0800, Brian Norris wrote:
> On Fri, Jan 03, 2025 at 04:52:01PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Jan 02, 2025 at 10:39:11AM -0800, Brian Norris wrote:
> > > On Tue, Dec 24, 2024 at 07:37:20PM +0800, kernel test robot wrote:
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > In file included from drivers/base/test/platform-device-test.c:3:
> > > > >> include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function [-Wvisibility]
> > > > 15 | struct completion *x);
> > > > | ^
> > > > 1 warning generated.
> > >
> > > Same:
> > >
> > > https://lore.kernel.org/lkml/20241213180841.3023843-1-briannorris@chromium.org/
> > > Subject: [PATCH] kunit: platform: Resolve 'struct completion' warning
> >
> > I guess it should have been cc:ed me. I'll go dig it up now...
>
> I sent it where get_maintainer pointed me:
>
> $ scripts/get_maintainer.pl -f include/kunit/platform_device.h
> Brendan Higgins <brendan.higgins@linux.dev> (maintainer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> David Gow <davidgow@google.com> (maintainer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> Rae Moar <rmoar@google.com> (reviewer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> linux-kselftest@vger.kernel.org (open list:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> kunit-dev@googlegroups.com (open list:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> linux-kernel@vger.kernel.org (open list)
That's good, but you also need to send it to the maintainer that owns
the git tree where the bug is showing up in :)
Something to remember for future stuff, thanks!
greg k-h
prev parent reply other threads:[~2025-01-04 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 11:37 [driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function kernel test robot
2025-01-02 18:39 ` Brian Norris
2025-01-03 15:52 ` Greg Kroah-Hartman
2025-01-03 17:49 ` Brian Norris
2025-01-04 8:16 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025010433-fretful-gallery-e9cd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=briannorris@chromium.org \
--cc=davidgow@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox