* Re: [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages
[not found] <20250115120625.3785-1-donettom@linux.ibm.com>
@ 2025-01-17 14:16 ` kernel test robot
2025-01-17 14:48 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-01-17 14:16 UTC (permalink / raw)
To: Donet Tom; +Cc: llvm, oe-kbuild-all
Hi Donet,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Donet-Tom/mm-swap-c-Enable-promotion-of-unmapped-MGLRU-page-cache-pages/20250115-200910
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250115120625.3785-1-donettom%40linux.ibm.com
patch subject: [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages
config: arm64-randconfig-003-20250116 (https://download.01.org/0day-ci/archive/20250117/202501172113.JJBKAvMq-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250117/202501172113.JJBKAvMq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501172113.JJBKAvMq-lkp@intel.com/
All errors (new ones prefixed by >>):
mm/swap.c:413:4: error: use of undeclared identifier 'sysctl_numa_balancing_mode'
(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) &&
^
mm/swap.c:413:33: error: use of undeclared identifier 'NUMA_BALANCING_MEMORY_TIERING'
(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) &&
^
mm/swap.c:414:3: error: use of undeclared identifier 'numa_pagecache_promotion_enabled'
numa_pagecache_promotion_enabled) {
^
>> mm/swap.c:421:5: error: call to undeclared function 'promotion_candidate'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
promotion_candidate(folio);
^
4 errors generated.
vim +/promotion_candidate +421 mm/swap.c
382
383 static void lru_gen_inc_refs(struct folio *folio)
384 {
385 struct mem_cgroup *memcg;
386 struct lruvec *lruvec;
387 int gen;
388 unsigned long new_flags, old_flags = READ_ONCE(folio->flags);
389
390 if (folio_test_unevictable(folio))
391 return;
392
393 /* see the comment on LRU_REFS_FLAGS */
394 if (!folio_test_referenced(folio)) {
395 set_mask_bits(&folio->flags, LRU_REFS_MASK, BIT(PG_referenced));
396 return;
397 }
398
399 do {
400 if ((old_flags & LRU_REFS_MASK) == LRU_REFS_MASK) {
401 if (!folio_test_workingset(folio)) {
402 folio_set_workingset(folio);
403 return;
404 }
405 goto promo_candid;
406 }
407
408 new_flags = old_flags + BIT(LRU_REFS_PGOFF);
409 } while (!try_cmpxchg(&folio->flags, &old_flags, new_flags));
410
411 promo_candid:
412 if (!folio_test_isolated(folio) &&
> 413 (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) &&
414 numa_pagecache_promotion_enabled) {
415 memcg = folio_memcg(folio);
416 if (memcg) {
417 lruvec = mem_cgroup_lruvec(memcg, folio_pgdat(folio));
418 gen = folio_lru_gen(folio);
419
420 if ((gen < MAX_NR_GENS) && lru_gen_is_active(lruvec, gen))
> 421 promotion_candidate(folio);
422 }
423 }
424 }
425
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages
[not found] <20250115120625.3785-1-donettom@linux.ibm.com>
2025-01-17 14:16 ` [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages kernel test robot
@ 2025-01-17 14:48 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-01-17 14:48 UTC (permalink / raw)
To: Donet Tom; +Cc: llvm, oe-kbuild-all
Hi Donet,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Donet-Tom/mm-swap-c-Enable-promotion-of-unmapped-MGLRU-page-cache-pages/20250115-200910
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250115120625.3785-1-donettom%40linux.ibm.com
patch subject: [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages
config: i386-buildonly-randconfig-003-20250116 (https://download.01.org/0day-ci/archive/20250117/202501172215.r6eZaaVD-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250117/202501172215.r6eZaaVD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501172215.r6eZaaVD-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from mm/swap.c:26:
include/linux/mm_inline.h:47:41: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
47 | __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages);
| ~~~~~~~~~~~ ^ ~~~
include/linux/mm_inline.h:49:22: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
49 | NR_ZONE_LRU_BASE + lru, nr_pages);
| ~~~~~~~~~~~~~~~~ ^ ~~~
>> mm/swap.c:413:4: error: use of undeclared identifier 'sysctl_numa_balancing_mode'
413 | (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) &&
| ^
>> mm/swap.c:413:33: error: use of undeclared identifier 'NUMA_BALANCING_MEMORY_TIERING'
413 | (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) &&
| ^
>> mm/swap.c:414:3: error: use of undeclared identifier 'numa_pagecache_promotion_enabled'
414 | numa_pagecache_promotion_enabled) {
| ^
>> mm/swap.c:421:5: error: call to undeclared function 'promotion_candidate'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
421 | promotion_candidate(folio);
| ^
2 warnings and 4 errors generated.
vim +/sysctl_numa_balancing_mode +413 mm/swap.c
382
383 static void lru_gen_inc_refs(struct folio *folio)
384 {
385 struct mem_cgroup *memcg;
386 struct lruvec *lruvec;
387 int gen;
388 unsigned long new_flags, old_flags = READ_ONCE(folio->flags);
389
390 if (folio_test_unevictable(folio))
391 return;
392
393 /* see the comment on LRU_REFS_FLAGS */
394 if (!folio_test_referenced(folio)) {
395 set_mask_bits(&folio->flags, LRU_REFS_MASK, BIT(PG_referenced));
396 return;
397 }
398
399 do {
400 if ((old_flags & LRU_REFS_MASK) == LRU_REFS_MASK) {
401 if (!folio_test_workingset(folio)) {
402 folio_set_workingset(folio);
403 return;
404 }
405 goto promo_candid;
406 }
407
408 new_flags = old_flags + BIT(LRU_REFS_PGOFF);
409 } while (!try_cmpxchg(&folio->flags, &old_flags, new_flags));
410
411 promo_candid:
412 if (!folio_test_isolated(folio) &&
> 413 (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) &&
> 414 numa_pagecache_promotion_enabled) {
415 memcg = folio_memcg(folio);
416 if (memcg) {
417 lruvec = mem_cgroup_lruvec(memcg, folio_pgdat(folio));
418 gen = folio_lru_gen(folio);
419
420 if ((gen < MAX_NR_GENS) && lru_gen_is_active(lruvec, gen))
> 421 promotion_candidate(folio);
422 }
423 }
424 }
425
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-17 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250115120625.3785-1-donettom@linux.ibm.com>
2025-01-17 14:16 ` [RFC] mm/swap.c: Enable promotion of unmapped MGLRU page cache pages kernel test robot
2025-01-17 14:48 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).