From: Peter Zijlstra <peterz@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: lkp@intel.com, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, vincent.guittot@linaro.org
Subject: Re: [PATCH] sched: Fix static declaration of 'sched_clock_irqtime' follows non-static declaration
Date: Tue, 4 Feb 2025 12:32:34 +0100 [thread overview]
Message-ID: <20250204113234.GG14028@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250204084915.4887-1-laoar.shao@gmail.com>
On Tue, Feb 04, 2025 at 04:49:15PM +0800, Yafang Shao wrote:
> kernel test robot reported the following error:
>
> All errors (new ones prefixed by >>):
>
> In file included from kernel/sched/build_policy.c:59:
> >> kernel/sched/cputime.c:25:12: error: static declaration of 'sched_clock_irqtime' follows non-static declaration
> 25 | static int sched_clock_irqtime;
> | ^
> kernel/sched/sched.h:3262:12: note: previous declaration is here
> 3262 | extern int sched_clock_irqtime;
> | ^
> 1 error generated.
>
> vim +/sched_clock_irqtime +25 kernel/sched/cputime.c
>
> 24
> > 25 static int sched_clock_irqtime;
> 26
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502012207.b8iyB4Fh-lkp@intel.com/
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Once the build robot complained I dropped the patch. This don't apply to
anything.
prev parent reply other threads:[~2025-02-04 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 14:32 [peterz-queue:sched/urgent 2/2] kernel/sched/cputime.c:25:12: error: static declaration of 'sched_clock_irqtime' follows non-static declaration kernel test robot
2025-02-04 8:49 ` [PATCH] sched: Fix " Yafang Shao
2025-02-04 11:32 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204113234.GG14028@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=laoar.shao@gmail.com \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox