Re: [PATCH v2 08/11] PCI/IDE: Add IDE establishment helpers

[kernel test robot <lkp@intel.com>]

Hi Dan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 7eb172143d5508b4da468ed59ee857c6e5e01da6]

url:    https://github.com/intel-lab-lkp/linux/commits/Dan-Williams/configfs-tsm-Namespace-TSM-report-symbols/20250304-152958
base:   7eb172143d5508b4da468ed59ee857c6e5e01da6
patch link:    https://lore.kernel.org/r/174107250147.1288555.16948528371146013276.stgit%40dwillia2-xfh.jf.intel.com
patch subject: [PATCH v2 08/11] PCI/IDE: Add IDE establishment helpers
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250305/202503050439.9Ubeq0dP-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250305/202503050439.9Ubeq0dP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503050439.9Ubeq0dP-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/pci/ide.c:7:
   In file included from include/linux/pci.h:37:
   In file included from include/linux/device.h:32:
   In file included from include/linux/device/driver.h:21:
   In file included from include/linux/module.h:19:
   In file included from include/linux/elf.h:6:
   In file included from arch/s390/include/asm/elf.h:181:
   In file included from arch/s390/include/asm/mmu_context.h:11:
   In file included from arch/s390/include/asm/pgalloc.h:18:
   In file included from include/linux/mm.h:2224:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/ide.c:322:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
     322 |                 struct pci_dev *rp = pcie_find_root_port(ide->pdev);
         |                 ^
   4 warnings generated.


vim +322 drivers/pci/ide.c

   306	
   307	static struct pci_ide_partner *to_settings(struct pci_dev *pdev, struct pci_ide *ide)
   308	{
   309		if (!pci_is_pcie(pdev)) {
   310			pci_warn_once(pdev, "not a PCIe device\n");
   311			return NULL;
   312		}
   313	
   314		switch (pci_pcie_type(pdev)) {
   315		case PCI_EXP_TYPE_ENDPOINT:
   316			if (pdev != ide->pdev) {
   317				pci_warn_once(pdev, "setup expected Endpoint: %s\n", pci_name(ide->pdev));
   318				return NULL;
   319			}
   320			return &ide->partner[PCI_IDE_EP];
   321		case PCI_EXP_TYPE_ROOT_PORT:
 > 322			struct pci_dev *rp = pcie_find_root_port(ide->pdev);
   323	
   324			if (pdev != pcie_find_root_port(ide->pdev)) {
   325				pci_warn_once(pdev, "setup expected Root Port: %s\n",
   326					      pci_name(rp));
   327				return NULL;
   328			}
   329			return &ide->partner[PCI_IDE_RP];
   330		default:
   331			pci_warn_once(pdev, "invalid device type\n");
   332			return NULL;
   333		}
   334	}
   335	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki