From: Nathan Chancellor <nathan@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Marek Behún" <kabel@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
"kernel test robot" <lkp@intel.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] platform: cznic: fix function parameter names
Date: Tue, 25 Mar 2025 08:59:06 -0700 [thread overview]
Message-ID: <20250325155906.GA1886499@ax162> (raw)
In-Reply-To: <20250321085315.915808-1-arnd@kernel.org>
On Fri, Mar 21, 2025 at 09:53:07AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A invalid prototype made it into a previous patch, causing an clang warning:
>
> drivers/platform/cznic/turris-signing-key.c:25:55: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>
> and a slightly different warning with gcc-11 and earlier but not gcc-12 and up:
>
> drivers/platform/cznic/turris-signing-key.c: In function 'turris_signing_key_instantiate':
> drivers/platform/cznic/turris-signing-key.c:25:43: error: parameter name omitted
>
> Add the parameters to get a clean build with all compilers.
>
> Fixes: 0b28b7080ef5 ("platform: cznic: Add keyctl helpers for Turris platform")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503210450.AoOpbJXC-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
You will be taking this I assume?
> ---
> drivers/platform/cznic/turris-signing-key.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/cznic/turris-signing-key.c b/drivers/platform/cznic/turris-signing-key.c
> index 3b12e5245fb7..3827178565e2 100644
> --- a/drivers/platform/cznic/turris-signing-key.c
> +++ b/drivers/platform/cznic/turris-signing-key.c
> @@ -22,7 +22,8 @@
>
> #include <linux/turris-signing-key.h>
>
> -static int turris_signing_key_instantiate(struct key *, struct key_preparsed_payload *)
> +static int turris_signing_key_instantiate(struct key *key,
> + struct key_preparsed_payload *payload)
> {
> return 0;
> }
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-03-25 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 8:53 [PATCH] platform: cznic: fix function parameter names Arnd Bergmann
2025-03-25 15:59 ` Nathan Chancellor [this message]
2025-03-26 9:38 ` Marek Behún
2025-03-26 16:23 ` Nathan Chancellor
2025-03-26 16:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325155906.GA1886499@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=justinstitt@google.com \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox