From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64C94221F34 for ; Tue, 1 Apr 2025 18:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531920; cv=none; b=B5YguXi8A4TnZ7MHNLMpydpvuj34jYcA+YaCfoKGY+D4/qdE7DOOX37OvFRlFHQbRiT5QVgZWex8NF/PZBtZ92uDUu9KhfW2tTcXLlvJAGf7ZuBOrPQY6PTWt4nkFjptucS0HHSEtxED4W6uFdQLzDgv10wNZFG+uH5zySPMrQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743531920; c=relaxed/simple; bh=aWhjaWaNDxw7ETA3oWWKbhRWDFg1+yjRGI+RbsdYOsU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=thgN/C9JkxssrGIrpI1sbiNo2W7d6Wzcu0eluvZKBUX8tOkCbmYL0yUQQ95HEEpgYq4pbGhGmswnbph7ApGMCOmtFEH7sHi9CxgvVEvdAHChxvX9BGeAhw1/yL0pyB0j/chSi4Wewi8vUzeXrkKMniN7MAMK7iIAT+Ab0oH+aFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fY7RXIy3; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fY7RXIy3" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2ff798e8c90so9669526a91.1 for ; Tue, 01 Apr 2025 11:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1743531919; x=1744136719; darn=lists.linux.dev; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=PrYWWuE6sPSS+h6suzb5zsvazVTJqNriEiozkF9ksBc=; b=fY7RXIy3YjstQijKcyu5njNI5M2Qb+nhOI/AAYlqtsiv3s5vozR5/+0NQRtb1hueaV mgE8HbbZYi42O97O5ndTS3cXVuHOrHns3suZeJif5zJ+0XL6SOPhVVbAZ53ilSOx27yH Bj/wb5ER+DyMm0sYtnJfp0XVO0fcivk0zVcl6Bqg0FRTiH/iPDvgDOOhjETiCsXb/TWk abRthEEPJIOKtPFxW3p2JfifYh1K444BfTrrxpB/JvrxLvKTf0rJEVI4TjkIfI1LlPzb SjGdqXiQGoFrOzETj0dFLAQGyK2pKFAggiUokAMRR4bb/EWp98yAX4/w3IjU9sqXbl08 cKqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743531919; x=1744136719; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PrYWWuE6sPSS+h6suzb5zsvazVTJqNriEiozkF9ksBc=; b=m9+G5WrVZIjUk1fnv6T+8diqfMAycrvSrt+mJmi+VWgQGcZ8DuokIx2zjwEghCgaTd FCz63YpZj76ewu9ZAstPedyuBQZQoj/Gnbn8Mm4Pk2Zwqlx/J4PA5YX5S4RV/xLf6ZOL U+JY7aeNN3jWEz7gIW+eelV05gfF2+Zm0k883QwVbSlLefXli6LKyMbOMOuWkrzdUasu Ici1jxUsnK6d4vk50rMBtc1sH5JAZgcIydvIOWyoizaj03JsQwV/4LvOrtNJeBTm7wiK qkOEww03axDXfy8waKCxmf5Ay57BdX3lFNPabRQANqjMIoSgUPOsWS3srgk/sH+d9mmg RGrg== X-Forwarded-Encrypted: i=1; AJvYcCWvioDxoMImFs6d8NIlCeZ4uOjaXZ9n+JzXNpZThXQO5hSB+EiQN3oD+YuWxQveW0fO1kif@lists.linux.dev X-Gm-Message-State: AOJu0YztqxSSDx7yk7rMO0S/j2qnTSWw1n82ugTlwNt1dkFhw9na/p3x O6QNa+aI2eLpD0rJQj/mDSFE21+oU/mDtPrQrHmFrGy5vnbkIX+hidretFc4+CKotxHyH420pdm 15vddgw== X-Google-Smtp-Source: AGHT+IE1i0iieUCDh7eWrhy6Ik1SYOR9eTB7LYFda3ROvNxcBt4D/jdzBlQzp5ihSJVDTMonP2rg4A/ftUf8 X-Received: from pfbdf3.prod.google.com ([2002:a05:6a00:4703:b0:739:4820:6f18]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6300:668c:b0:1f5:97c3:41b9 with SMTP id adf61e73a8af0-2009f5c4a5emr19263259637.5.1743531918807; Tue, 01 Apr 2025 11:25:18 -0700 (PDT) Date: Tue, 1 Apr 2025 11:23:19 -0700 In-Reply-To: <20250401182347.3422199-1-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250401182347.3422199-1-irogers@google.com> X-Mailer: git-send-email 2.49.0.504.g3bcea36a83-goog Message-ID: <20250401182347.3422199-22-irogers@google.com> Subject: [PATCH v1 21/48] perf demangle: Silence -Wshorten-64-to-32 warnings From: Ian Rogers To: Yury Norov , Rasmus Villemoes , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Thomas Gleixner , Darren Hart , Davidlohr Bueso , "=?UTF-8?q?Andr=C3=A9=20Almeida?=" , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Yicong Yang , Jonathan Cameron , Nathan Chancellor , Bill Wendling , Justin Stitt , Josh Poimboeuf , Al Viro , Kyle Meyer , Ben Gainey , Athira Rajeev , Kajol Jain , Aditya Gupta , Eder Zulian , Dapeng Mi , Kuan-Wei Chiu , He Zhe , Dirk Gouders , Brian Geffon , Ravi Bangoria , Howard Chu , Charlie Jenkins , Colin Ian King , Dominique Martinet , Jann Horn , Masahiro Yamada , Arnd Bergmann , Yang Jihong , Dmitry Vyukov , Andi Kleen , Graham Woodward , Ilkka Koskinen , Anshuman Khandual , Zhongqiu Han , Hao Ge , Tengda Wu , Gabriele Monaco , Chun-Tse Shao , Casey Chen , "Dr. David Alan Gilbert" , Li Huafei , "Steinar H. Gunderson" , Levi Yun , Weilin Wang , Thomas Falcon , Thomas Richter , Andrew Kreimer , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Christophe Leroy , Jean-Philippe Romain , Junhao He , "Masami Hiramatsu (Google)" , Xu Yang , Steve Clevenger , Zixian Cai , Stephen Brennan , Yujie Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" The clang warning -Wshorten-64-to-32 can be useful to catch inadvertent truncation. In some instances this truncation can lead to changing the sign of a result, for example, truncation to return an int to fit a sort routine. Silence the warning by making the implicit truncation explicit. Signed-off-by: Ian Rogers --- tools/perf/util/demangle-java.c | 4 ++-- tools/perf/util/demangle-ocaml.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/demangle-java.c b/tools/perf/util/demangle-java.c index ddf33d58bcd3..ee20f4d08765 100644 --- a/tools/perf/util/demangle-java.c +++ b/tools/perf/util/demangle-java.c @@ -42,9 +42,9 @@ static const char *base_types['Z' - 'A' + 1] = { * error : NULL */ static char * -__demangle_java_sym(const char *str, const char *end, char *buf, int maxlen, int mode) +__demangle_java_sym(const char *str, const char *end, char *buf, size_t maxlen, int mode) { - int rlen = 0; + size_t rlen = 0; int array = 0; int narg = 0; const char *q; diff --git a/tools/perf/util/demangle-ocaml.c b/tools/perf/util/demangle-ocaml.c index 9d707bb60b4b..25fe755df5ab 100644 --- a/tools/perf/util/demangle-ocaml.c +++ b/tools/perf/util/demangle-ocaml.c @@ -30,8 +30,7 @@ ocaml_demangle_sym(const char *sym) { char *result; int j = 0; - int i; - int len; + size_t i, len; if (!ocaml_is_mangled(sym)) { return NULL; -- 2.49.0.504.g3bcea36a83-goog